All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhao Liu <zhao1.liu@intel.com>
To: Xiaoyao Li <xiaoyao.li@intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>,
	Manish <manish.mishra@nutanix.com>,
	John Levon <john.levon@nutanix.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH] i386/cpu: Introduce enable_cpuid_0x1f to force exposing CPUID 0x1f
Date: Tue, 13 Aug 2024 15:36:14 +0800	[thread overview]
Message-ID: <ZrsM7rf5C65CJDMJ@intel.com> (raw)
In-Reply-To: <ec35b71a-15af-4547-8989-ed4368fa9c58@intel.com>

On Tue, Aug 13, 2024 at 10:52:27AM +0800, Xiaoyao Li wrote:

[snip]

> > Any levels that 0xb doesn't cover.
> 
> The name of extended_topo is so misleading. At least, it misleads me.
> 
> Both Intel and AMD support leaf 0xb and the name of leaf 0xb is "Extended
> topology enumeration". And here, x86_has_extended_topo() is used for topo
> levels that cannot be covered by 0xb.
> 

Yes, names are really hard, Intel and AMD have different naming for
topology leafs (the ones 0xb doesn't cover)... This helper has a
comment, which is also a clear expression of what it is doing.

Thanks,
Zhao



      reply	other threads:[~2024-08-13  7:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-02  7:24 [PATCH] i386/cpu: Introduce enable_cpuid_0x1f to force exposing CPUID 0x1f Xiaoyao Li
2024-08-08  9:29 ` Igor Mammedov
2024-08-08 14:03   ` Xiaoyao Li
2024-08-08 10:09 ` Zhao Liu
2024-08-08 13:59   ` Xiaoyao Li
2024-08-08 14:46     ` Zhao Liu
2024-08-13  2:52       ` Xiaoyao Li
2024-08-13  7:36         ` Zhao Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZrsM7rf5C65CJDMJ@intel.com \
    --to=zhao1.liu@intel.com \
    --cc=imammedo@redhat.com \
    --cc=john.levon@nutanix.com \
    --cc=manish.mishra@nutanix.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=xiaoyao.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.