From: Ido Schimmel <idosch@idosch.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Wen Gu <guwen@linux.alibaba.com>,
wenjia@linux.ibm.com, jaka@linux.ibm.com, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com,
alibuda@linux.alibaba.com, tonylu@linux.alibaba.com,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
netdev@vger.kernel.org, danieller@nvidia.com
Subject: Re: [PATCH net-next v2 1/2] net/smc: introduce statistics for allocated ringbufs of link group
Date: Tue, 13 Aug 2024 18:13:48 +0300 [thread overview]
Message-ID: <Zrt4LGFh7kMwGczb@shredder.mtl.com> (raw)
In-Reply-To: <20240813074042.14e20842@kernel.org>
On Tue, Aug 13, 2024 at 07:40:42AM -0700, Jakub Kicinski wrote:
> On Tue, 13 Aug 2024 17:55:17 +0800 Wen Gu wrote:
> > On 2024/8/13 08:41, Jakub Kicinski wrote:
> > > On Wed, 7 Aug 2024 15:59:38 +0800 Wen Gu wrote:
> > >> + if (nla_put_u64_64bit(skb, SMC_NLA_LGR_R_SNDBUF_ALLOC,
> > >> + lgr->alloc_sndbufs, SMC_NLA_LGR_R_PAD))
> > >
> > > nla_put_uint()
> >
> > Hi, Jakub. Thank you for reminder.
> >
> > I read the commit log and learned the advantages of this helper.
> > But it seems that the support for corresponding user-space helpers
> > hasn't kept up yet, e.g. can't find a helper like nla_get_uint in
> > latest libnl.
>
> Add it, then.
Danielle added one to libmnl:
https://git.netfilter.org/libmnl/commit/?id=102942be401a99943b2c68981b238dadfa788f2d
Intention is to use it in ethtool once it appears in a released version
of libmnl.
next prev parent reply other threads:[~2024-08-13 15:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 7:59 [PATCH net-next v2 0/2] net/smc: introduce ringbufs usage statistics Wen Gu
2024-08-07 7:59 ` [PATCH net-next v2 1/2] net/smc: introduce statistics for allocated ringbufs of link group Wen Gu
2024-08-13 0:41 ` Jakub Kicinski
2024-08-13 9:55 ` Wen Gu
2024-08-13 14:40 ` Jakub Kicinski
2024-08-13 15:13 ` Ido Schimmel [this message]
2024-08-14 3:12 ` Wen Gu
2024-08-14 14:48 ` Jakub Kicinski
2024-08-15 6:51 ` Wen Gu
2024-08-14 3:10 ` Wen Gu
2024-08-14 14:50 ` Jakub Kicinski
2024-08-07 7:59 ` [PATCH net-next v2 2/2] net/smc: introduce statistics for ringbufs usage of net namespace Wen Gu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zrt4LGFh7kMwGczb@shredder.mtl.com \
--to=idosch@idosch.org \
--cc=alibuda@linux.alibaba.com \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=guwen@linux.alibaba.com \
--cc=jaka@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tonylu@linux.alibaba.com \
--cc=wenjia@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.