From: "Juan José Arboleda" <soyjuanarbol@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ALSA: usb-audio: reduce checkpatch issues in quirks-table.h
Date: Tue, 13 Aug 2024 11:04:11 -0500 [thread overview]
Message-ID: <ZruD-9ccJL6tlBM1@fedora> (raw)
In-Reply-To: <87sev8l97e.wl-tiwai@suse.de>
> > Honestly speaking, I don't find it's much improvement from the code
> > readability POV. (And you don't have to "correct" the spaces in
> > comment lines :)
> FWIW, the patches below are what I had in my mind.
Right. Your patchset makes way more sense when you read the codebase.
As you already made the code better, I dropped the patch for the
"cleanup" and, left only the support for Yamaha P-125 patch.
Regards,
-Juan
prev parent reply other threads:[~2024-08-13 16:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 3:31 [PATCH 0/2] ALSA: usb-audio: Support Yamaha P-125 and cleanup Juan José Arboleda
2024-08-13 3:31 ` [PATCH 1/2] ALSA: usb-audio: Support Yamaha P-125 quirk entry Juan José Arboleda
2024-08-13 6:44 ` Takashi Iwai
2024-08-13 3:31 ` [PATCH 2/2] ALSA: usb-audio: reduce checkpatch issues in quirks-table.h Juan José Arboleda
2024-08-13 6:57 ` Takashi Iwai
2024-08-13 15:43 ` Takashi Iwai
2024-08-13 16:04 ` Juan José Arboleda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZruD-9ccJL6tlBM1@fedora \
--to=soyjuanarbol@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.