From: Brian Norris <briannorris@chromium.org>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Francesco Dolcini <francesco@dolcini.it>,
Kalle Valo <kvalo@kernel.org>,
Yogesh Ashok Powar <yogeshp@marvell.com>,
Bing Zhao <bzhao@marvell.com>,
"John W. Linville" <linville@tuxdriver.com>,
Amitkumar Karwar <akarwar@marvell.com>,
Avinash Patil <patila@marvell.com>,
Kiran Divekar <dkiran@marvell.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@pengutronix.de, stable@vger.kernel.org
Subject: Re: [PATCH] mwifiex: duplicate static structs used in driver instances
Date: Tue, 13 Aug 2024 09:47:13 -0700 [thread overview]
Message-ID: <ZruOERPfLACNlw7P@google.com> (raw)
In-Reply-To: <20240809-mwifiex-duplicate-static-structs-v1-1-6837b903b1a4@pengutronix.de>
On Fri, Aug 09, 2024 at 10:11:33AM +0200, Sascha Hauer wrote:
> mwifiex_band_2ghz and mwifiex_band_5ghz are statically allocated, but
> used and modified in driver instances. Duplicate them before using
> them in driver instances so that different driver instances do not
> influence each other.
Ugh, I caught a few problems like this on the first several passes of
review, but I missed a few more. Thanks for the catches.
> This was observed on a board which has one PCIe and one SDIO mwifiex
> adapter. It blew up in mwifiex_setup_ht_caps(). This was called with
> the statically allocated struct which is modified in this function.
>
> Cc: stable@vger.kernel.org
> Fixes: d6bffe8bb520 ("mwifiex: support for creation of AP interface")
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Acked-by: Brian Norris <briannorris@chromium.org>
next prev parent reply other threads:[~2024-08-13 16:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 8:11 [PATCH] mwifiex: duplicate static structs used in driver instances Sascha Hauer
2024-08-09 8:14 ` Kalle Valo
2024-08-09 8:23 ` Sascha Hauer
2024-08-09 8:49 ` Ping-Ke Shih
2024-08-09 9:12 ` Sascha Hauer
2024-08-09 9:26 ` Ping-Ke Shih
2024-08-09 12:42 ` Francesco Dolcini
2024-08-13 16:47 ` Brian Norris [this message]
2024-08-16 9:48 ` wifi: " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZruOERPfLACNlw7P@google.com \
--to=briannorris@chromium.org \
--cc=akarwar@marvell.com \
--cc=bzhao@marvell.com \
--cc=dkiran@marvell.com \
--cc=francesco@dolcini.it \
--cc=kernel@pengutronix.de \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=patila@marvell.com \
--cc=s.hauer@pengutronix.de \
--cc=stable@vger.kernel.org \
--cc=yogeshp@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.