From: Breno Leitao <leitao@debian.org>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
Dmitry Osipenko <digetx@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
leit@meta.com, Michael van der Westhuizen <rmikey@meta.com>,
Andy Shevchenko <andy@kernel.org>,
"open list:I2C SUBSYSTEM HOST DRIVERS"
<linux-i2c@vger.kernel.org>,
"open list:TEGRA ARCHITECTURE SUPPORT"
<linux-tegra@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] Do not mark ACPI devices as irq safe
Date: Wed, 14 Aug 2024 06:40:27 -0700 [thread overview]
Message-ID: <Zryzy9hpT1wyZdLZ@gmail.com> (raw)
In-Reply-To: <7cudtahr26xrfn5uccmvtiv3ngyccu3wcrky4evxdstubz34hf@wtxzjv4z4g4w>
On Wed, Aug 14, 2024 at 12:02:57PM +0100, Andi Shyti wrote:
> Hi Breno,
>
> On Wed, Aug 14, 2024 at 01:47:54AM GMT, Breno Leitao wrote:
> > On Tue, Aug 13, 2024 at 11:53:17PM +0100, Andi Shyti wrote:
> > > You don't need to resend the patch. Because the changes are only
> > > in the commit log, I can take care of them.
> >
> > In fact, the changes are in the code itself, see the changelog:
> >
> > * Replaced ACPI_HANDLE() by has_acpi_companion() (Andy Shevchenko)
> > * Expanded the comment before the change (Andy Shevchenko)
>
> I meant no need to send a v3.
>
> > > Besides, you also need:
> > >
> > > Fixes: ede2299f7101 ("i2c: tegra: Support atomic transfers")
> > > Cc: <stable@vger.kernel.org> # v5.6+
> > >
> > > Can you please check whether this is right?
> >
> > I would say that we probably want to blame the support for ACPI device,
> > which came later than ede2299f7101 ("i2c: tegra: Support atomic
> > transfers").
> >
> > I'd suggest the following:
> >
> > Fixes: bd2fdedbf2ba ("i2c: tegra: Add the ACPI support")
> > CC: <stable@vger.kernel.org> # v5.17+
>
> Makes sense.
>
> > I am not planning to submit a new patch with these changes, please let
> > me know if you need action on my side.
>
> Not for now, you might need to still support the backports to
> stable as there might be some differences and I can already see
> that it doesn't apply that far back (from 6.1, basically).
Sure, count me on, if you need backports to stable.
Thanks for getting this fixed
--breno
next prev parent reply other threads:[~2024-08-14 13:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 16:12 [PATCH v2] Do not mark ACPI devices as irq safe Breno Leitao
2024-08-13 19:45 ` Andy Shevchenko
2024-08-13 19:47 ` Wolfram Sang
2024-08-14 12:56 ` Andy Shevchenko
2024-08-13 22:53 ` Andi Shyti
2024-08-14 8:47 ` Breno Leitao
2024-08-14 11:02 ` Andi Shyti
2024-08-14 13:40 ` Breno Leitao [this message]
2024-08-14 22:30 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zryzy9hpT1wyZdLZ@gmail.com \
--to=leitao@debian.org \
--cc=andi.shyti@kernel.org \
--cc=andy@kernel.org \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=leit@meta.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rmikey@meta.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.