Re: [PATCH -next v2] mm: make use of the helper macro LIST_HEAD()

[Uladzislau Rezki <urezki@gmail.com>]

On Wed, Aug 28, 2024 at 12:12:16PM +0800, Hongbo Li wrote:
> list_head can be initialized automatically with LIST_HEAD()
> instead of calling INIT_LIST_HEAD(). Here we can simplify
> the code.
> 
> Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
> 
> ---
> - v2:
>   - Also adjust decay_list according to Uladzislau's suggestion.
> 
> - v1: https://lore.kernel.org/linux-mm/20240827015724.620110-1-lihongbo22@huawei.com/T/
> ---
>  mm/vmalloc.c | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 3f9b6bd707d2..6fc736f74ae7 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -2131,23 +2131,18 @@ reclaim_list_global(struct list_head *head)
>  static void
>  decay_va_pool_node(struct vmap_node *vn, bool full_decay)
>  {
> +	LIST_HEAD(decay_list);
> +	struct rb_root decay_root = RB_ROOT;
>  	struct vmap_area *va, *nva;
> -	struct list_head decay_list;
> -	struct rb_root decay_root;
>  	unsigned long n_decay;
>  	int i;
>  
> -	decay_root = RB_ROOT;
> -	INIT_LIST_HEAD(&decay_list);
> -
>  	for (i = 0; i < MAX_VA_SIZE_PAGES; i++) {
> -		struct list_head tmp_list;
> +		LIST_HEAD(tmp_list);
>  
>  		if (list_empty(&vn->pool[i].head))
>  			continue;
>  
> -		INIT_LIST_HEAD(&tmp_list);
> -
>  		/* Detach the pool, so no-one can access it. */
>  		spin_lock(&vn->pool_lock);
>  		list_replace_init(&vn->pool[i].head, &tmp_list);
> -- 
> 2.34.1
> 
Reviewed-by: Uladzislau Rezki (Sony) <urezki@gmail.com>

--
Uladzislau Rezki