From: Peter Xu <peterx@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: qemu-devel@nongnu.org, "Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH v7 1/4] migration/multifd: Stop changing the packet on recv side
Date: Wed, 28 Aug 2024 11:59:17 -0400 [thread overview]
Message-ID: <Zs9JVcI7YaLBxFlh@x1n> (raw)
In-Reply-To: <20240828145650.15879-2-farosas@suse.de>
On Wed, Aug 28, 2024 at 11:56:47AM -0300, Fabiano Rosas wrote:
> As observed by Philippe, the multifd_ram_unfill_packet() function
> currently leaves the MultiFDPacket structure with mixed
> endianness. This is harmless, but ultimately not very clean.
>
> Stop touching the received packet and do the necessary work using
> stack variables instead.
>
> While here tweak the error strings and fix the space before
> semicolons. Also remove the "100 times bigger" comment because it's
> just one possible explanation for a size mismatch and it doesn't even
> match the code.
>
> CC: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
next prev parent reply other threads:[~2024-08-28 15:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 14:56 [PATCH v7 0/4] migration/multifd: Remove multifd_send_state->pages (leftovers) Fabiano Rosas
2024-08-28 14:56 ` [PATCH v7 1/4] migration/multifd: Stop changing the packet on recv side Fabiano Rosas
2024-08-28 15:59 ` Peter Xu [this message]
2024-08-28 14:56 ` [PATCH v7 2/4] migration/multifd: Fix p->iov leak in multifd-uadk.c Fabiano Rosas
2024-08-28 15:59 ` Peter Xu
2024-09-06 15:06 ` Michael Tokarev
2024-09-06 16:51 ` Fabiano Rosas
2024-08-28 14:56 ` [PATCH v7 3/4] migration/multifd: Add a couple of asserts for p->iov Fabiano Rosas
2024-08-28 15:59 ` Peter Xu
2024-08-28 14:56 ` [PATCH v7 4/4] migration/multifd: Add documentation for multifd methods Fabiano Rosas
2024-08-28 16:01 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zs9JVcI7YaLBxFlh@x1n \
--to=peterx@redhat.com \
--cc=farosas@suse.de \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.