All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Kundan Kumar <kundan.kumar@samsung.com>
Cc: axboe@kernel.dk, hch@lst.de, kbusch@kernel.org,
	linux-block@vger.kernel.org, joshi.k@samsung.com,
	mcgrof@kernel.org, anuj20.g@samsung.com, nj.shetty@samsung.com,
	c.gameti@samsung.com, gost.dev@samsung.com
Subject: Re: [PATCH v8 5/5] block: unpin user pages belonging to a folio at once
Date: Sat, 17 Aug 2024 05:36:00 +0100	[thread overview]
Message-ID: <ZsAosHAJNWAM811a@casper.infradead.org> (raw)
In-Reply-To: <20240711050750.17792-6-kundan.kumar@samsung.com>

On Thu, Jul 11, 2024 at 10:37:50AM +0530, Kundan Kumar wrote:
> +static inline void bio_release_folio(struct bio *bio, struct folio *folio,
> +				     unsigned long npages)
> +{
> +	unpin_user_folio(folio, npages);
> +}

Why doesn't this need to check BIO_PAGE_PINNED like bio_release_page()
does?  That should be explained, certainly in the commit message or
maybe in a comment.

  parent reply	other threads:[~2024-08-17  4:36 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20240711051521epcas5p348f2cd84a1a80577754929143255352b@epcas5p3.samsung.com>
2024-07-11  5:07 ` [PATCH v8 0/5] block: add larger order folio instead of pages Kundan Kumar
2024-07-11  5:07   ` [PATCH v8 1/5] block: Added folio-ized version of bvec_try_merge_hw_page() Kundan Kumar
2024-08-17  4:23     ` Matthew Wilcox
2024-08-20  7:43       ` Kundan Kumar
2024-08-27  8:22         ` Kundan Kumar
2024-07-11  5:07   ` [PATCH v8 2/5] block: Added folio-ized version of bio_add_hw_page() Kundan Kumar
2024-07-11  5:07   ` [PATCH v8 3/5] block: introduce folio awareness and add a bigger size from folio Kundan Kumar
2024-07-25 20:56     ` Anuj gupta
2024-07-11  5:07   ` [PATCH v8 4/5] mm: release number of pages of a folio Kundan Kumar
2024-07-11  5:07   ` [PATCH v8 5/5] block: unpin user pages belonging to a folio at once Kundan Kumar
2024-07-18  6:17     ` Kundan Kumar
2024-07-25 20:40     ` Anuj gupta
2024-08-17  4:36     ` Matthew Wilcox [this message]
2024-08-08 23:04   ` [PATCH v8 0/5] block: add larger order folio instead of pages Luis Chamberlain
2024-08-12 13:38     ` Christoph Hellwig
2024-08-12 16:35       ` Luis Chamberlain
2024-08-16  8:45         ` Kundan Kumar
2024-08-17  1:22           ` Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZsAosHAJNWAM811a@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=anuj20.g@samsung.com \
    --cc=axboe@kernel.dk \
    --cc=c.gameti@samsung.com \
    --cc=gost.dev@samsung.com \
    --cc=hch@lst.de \
    --cc=joshi.k@samsung.com \
    --cc=kbusch@kernel.org \
    --cc=kundan.kumar@samsung.com \
    --cc=linux-block@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=nj.shetty@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.