All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft,v2 1/2] datatype: reject rate in quota statement
Date: Mon, 19 Aug 2024 12:47:02 +0200	[thread overview]
Message-ID: <ZsMipjpB5QylZ3tH@calendula> (raw)
In-Reply-To: <Zr9FKFg8bnfQrqoZ@orbyte.nwl.cc>

Hi Phil,

On Fri, Aug 16, 2024 at 02:25:12PM +0200, Phil Sutter wrote:
> On Wed, Aug 14, 2024 at 09:26:36PM +0200, Phil Sutter wrote:
> [...]
> > Maybe one could introduce a start condition which allows strings, but
> > it might turn into a mess given the wide use of them. I'll give it a try
> > and let you know.
> 
> Looks like I hit a dead end there: For expressions like 'iif', we have
> to accept STRING on RHS and since I need a token to push SC_STRING, I
> can't just enable it for all relational expressions. The alternative is
> to enable it for the whole rule but I can't disable it selectively (as I
> had to enable it again afterwards without knowing what's next. :(

flex rules also tells what to find first (order implies priority)
maybe a combination of start conditions to carefully placing. I can
take my poor man fix by now so this can be revisited later :)

  reply	other threads:[~2024-08-19 10:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-14 11:51 [PATCH nft,v2 1/2] datatype: reject rate in quota statement Pablo Neira Ayuso
2024-08-14 11:51 ` [PATCH nft,v2 2/2] datatype: improve error reporting when time unit is not correct Pablo Neira Ayuso
2024-08-14 16:00 ` [PATCH nft,v2 1/2] datatype: reject rate in quota statement Phil Sutter
2024-08-14 16:09   ` Pablo Neira Ayuso
2024-08-14 19:26     ` Phil Sutter
2024-08-16 12:25       ` Phil Sutter
2024-08-19 10:47         ` Pablo Neira Ayuso [this message]
2024-08-19 15:18           ` Phil Sutter
2024-08-19 15:57             ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZsMipjpB5QylZ3tH@calendula \
    --to=pablo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.