Re: [PATCH nft 0/5] relax cache requirements, speed up incremental updates

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Thu, Aug 15, 2024 at 11:08:58AM -0400, Eric Garver wrote:
> On Thu, Aug 15, 2024 at 01:37:07PM +0200, Pablo Neira Ayuso wrote:
> > Hi,
> > 
> > The following patchset relaxes cache requirements, this is based on the
> > observation that objects are fetched to report errors and provide hints.
> > 
> > This is a new attempt to speed up incremental updates following a
> > different approach, after reverting:
> > 
> >   e791dbe109b6 ("cache: recycle existing cache with incremental updates")
> > 
> > which is fragile because cache consistency checking needs more, it should
> > be still possible to explore in the future, but this seems a more simple
> > approach at this stage.
> > 
> > This is passing tests/shell and tests/py.
> > 
> > Pablo Neira Ayuso (5):
> >   cache: rule by index requires full cache
> >   cache: populate chains on demand from error path
> >   cache: populate objecs on demand from error path
> >   cache: populate flowtable on demand from error path
> >   cache: do not fetch set inconditionally on delete
> > 
> >  include/cache.h |  1 -
> >  src/cache.c     | 23 ++++++-----------------
> >  src/cmd.c       | 23 +++++++++++++++++++++++
> >  3 files changed, 29 insertions(+), 18 deletions(-)
> 
> I applied this series to nft master and tested it against the latest
> net-next and RHEL-9 kernels. No issues or regressions found.

Pushed out, thanks for testing.