From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Przemek Kitszel <przemyslaw.kitszel@intel.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH net-next] nfc: st95hf: switch to using sleeping variants of gpiod API
Date: Tue, 20 Aug 2024 09:38:24 -0700 [thread overview]
Message-ID: <ZsTGgMWvD8b6_8SN@google.com> (raw)
In-Reply-To: <2a72c443-2aa8-4a98-ae2e-62a781e0dd94@lunn.ch>
On Tue, Aug 20, 2024 at 03:53:21PM +0200, Andrew Lunn wrote:
> On Tue, Aug 20, 2024 at 10:10:37AM +0200, Przemek Kitszel wrote:
> > On 8/20/24 03:10, Dmitry Torokhov wrote:
> > > The driver does not not use gpiod API calls in an atomic context. Switch
> >
> > please remove one "not"
> >
> > > to gpiod_set_value_cansleep() calls to allow using the driver with GPIO
> > > controllers that might need process context to operate.
> > >
> > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> >
> > Code is fine, but why not as a fix?
>
> Why would this be a fix? What is broken?
No, this is not a fix but a tiny enhancement. As far as I know no
existing devices actually require it.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2024-08-20 16:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 1:10 [PATCH net-next] nfc: st95hf: switch to using sleeping variants of gpiod API Dmitry Torokhov
2024-08-20 8:10 ` Przemek Kitszel
2024-08-20 13:53 ` Andrew Lunn
2024-08-20 16:38 ` Dmitry Torokhov [this message]
2024-08-20 15:26 ` Jakub Kicinski
2024-08-20 16:37 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZsTGgMWvD8b6_8SN@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=andrew@lunn.ch \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.