From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Rosen Penev <rosenp@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, linux@armlinux.org.uk,
linux-kernel@vger.kernel.org, p.zabel@pengutronix.de
Subject: Re: [PATCHv4 net-next] net: ag71xx: get reset control using devm api
Date: Thu, 29 Aug 2024 06:49:13 +0200 [thread overview]
Message-ID: <Zs_9yVMp8moxGfpE@pengutronix.de> (raw)
In-Reply-To: <20240826192904.100181-1-rosenp@gmail.com>
On Mon, Aug 26, 2024 at 12:28:45PM -0700, Rosen Penev wrote:
> Currently, the of variant is missing reset_control_put in error paths.
> The devm variant does not require it.
>
> Allows removing mdio_reset from the struct as it is not used outside the
> function.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
You forgot to include my Reviewed-by tags from v3
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2024-08-29 4:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 19:28 [PATCHv4 net-next] net: ag71xx: get reset control using devm api Rosen Penev
2024-08-28 21:09 ` Jacob Keller
2024-08-29 4:49 ` Oleksij Rempel [this message]
2024-08-29 5:56 ` Rosen Penev
-- strict thread matches above, loose matches on Subject: below --
2024-08-26 21:21 Rosen Penev
2024-08-27 23:12 ` Jakub Kicinski
2024-08-27 23:36 ` Rosen Penev
2024-08-29 22:20 ` Luiz Angelo Daros de Luca
2024-08-30 3:54 ` Rosen Penev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zs_9yVMp8moxGfpE@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.