From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
xfs <linux-xfs@vger.kernel.org>,
Chandan Babu R <chandanbabu@kernel.org>
Subject: Re: [PATCH] xfs: don't bother reporting blocks trimmed via FITRIM
Date: Wed, 21 Aug 2024 23:30:44 -0700 [thread overview]
Message-ID: <ZsbbFJpCY9BhroY8@infradead.org> (raw)
In-Reply-To: <20240822050328.GS6082@frogsfrogsfrogs>
On Wed, Aug 21, 2024 at 10:03:28PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Don't bother reporting the number of bytes that we "trimmed" because the
> underlying storage isn't required to do anything(!) and failed discard
> IOs aren't reported to the caller anyway. It's not like userspace can
> use the reported value for anything useful like adjusting the offset
> parameter of the next call, and it's not like anyone ever wrote a
> manpage about FITRIM's out parameters.
Look good and fixes the reporting issues I've seen:
Reviewed-by: Christoph Hellwig <hch@lst.de>
Tested-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2024-08-22 6:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 5:03 [PATCH] xfs: don't bother reporting blocks trimmed via FITRIM Darrick J. Wong
2024-08-22 6:30 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZsbbFJpCY9BhroY8@infradead.org \
--to=hch@infradead.org \
--cc=chandanbabu@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.