From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CE7738F9A for ; Thu, 22 Aug 2024 17:50:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724349027; cv=none; b=Y4zSCx5/JiZvXZeTVG/wNxJeL6aX39hXkcFvd+a2sp8niDsN4V3f9G6ObpYPtUBKMcuzz/qZT63QN/yBheF9iEj5VBBtkqs5yIo9h728feClikDxf0z3lwU2wEP7c3OnpkV2MyWz3XBmHwZLKYPJyRFmPHBCiZVF1hGuJBWDtqQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724349027; c=relaxed/simple; bh=dvjLhd87vCdRo/xiVsfDDYj5ouJ7dOsDPOl5m/jQnB8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Lzck3invs3pd6vE7cMOtv0gTfjy/CRKN8ZGkSn2blb4s8JgGN0tmn7ZZB8H43TXID/Kr3nAJSJ9Ju7b9PS7i1Of2Fuhcy5I/rzKU0u6AFwRBFtGGa0iutJ/r68+Gf1A9Ep/ulEqcQWUD9yAbQMXQznZuNy/ijfOgLcY7HV1eemg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=HdmhTDMH; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="HdmhTDMH" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-714302e7285so938472b3a.2 for ; Thu, 22 Aug 2024 10:50:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1724349025; x=1724953825; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tCVHnlO2pIa86JaK5QjGr85qfeXpWfBdUE9lyP9m+/o=; b=HdmhTDMHdO0Cld6OncFcPIZAjg/uddeimxjulI3Ld4XVDE5G+5872NDI0wXrAVpx51 uGbPsNkdAXEOyZfWZNgTi//CDbasczllkNQiMCBZ0gblO9nFUTXxjfYLfVyJVB4Aq7n7 owSWzVTi64B+XpCgePSRh/V277TT/NWvHyv9Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724349025; x=1724953825; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tCVHnlO2pIa86JaK5QjGr85qfeXpWfBdUE9lyP9m+/o=; b=EkhVT9KiHNwZUg0NTm+U1PxlapndkZueIc467AC3IJIuyR/qMgCevzycB+C6/GPCu9 qSSRuWXXCxCH2SItceogYVY5PacyOXsFzUhq9WqIEDlsUJVq4RWd0XpoDhEw4how+C2H cS3qGhEdRqt+ZT/NG6pzx004Z6rkjRrS1p34DF6z96EANZY4UcC3+mvB5ih3ZSj3k4eP dGr+sMFHBVcjT1lroGL6RicqYy2+7gE5/HUtR+FrDZP/Z33MxTpAyFY8jJhwXjxH7V+B 1lvtbftlzPzPA3nn39FM65KVwQFijbO7UbPZbC0+2vsvTfqr1ZqYFDGhD2KfcGnfjq5k MEoQ== X-Forwarded-Encrypted: i=1; AJvYcCVjDR6graLIhUZb1+gRcjcbAdXH2UICYhURlflvquL7yCj73vbV/KdKOoURkSJ/3pIyups4RBpxAWhi6otAkIY=@vger.kernel.org X-Gm-Message-State: AOJu0YzPUwSJfFakLGeOceX0KPGlgldTZoMHEmhutrV8Cy1HbeCQRPa9 92kmiMRpPqYUuES0B+81JXekX9c8VysgTzoEZ2Woa/RK7ESSyJkL3ej+bP4cFg== X-Google-Smtp-Source: AGHT+IGfoGIJeQ5mwpQoLfvcD1BDbE9Q0hdoNktosEIXDb7FIO+5WC0W5xfEfFjtY5088xV28XfHJg== X-Received: by 2002:a05:6a21:3418:b0:1c6:f043:693f with SMTP id adf61e73a8af0-1cada054f37mr7146439637.17.1724349025477; Thu, 22 Aug 2024 10:50:25 -0700 (PDT) Received: from localhost ([2a00:79e0:2e14:7:414c:5b44:2fea:fb6e]) by smtp.gmail.com with UTF8SMTPSA id d2e1a72fcca58-7143577090fsm1537422b3a.137.2024.08.22.10.50.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Aug 2024 10:50:25 -0700 (PDT) Date: Thu, 22 Aug 2024 10:50:24 -0700 From: Brian Norris To: "Gustavo A. R. Silva" Cc: Francesco Dolcini , Kalle Valo , Andy Shevchenko , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH][next] wifi: mwifiex: Fix memcpy() field-spanning write warning in mwifiex_cmd_802_11_scan_ext() Message-ID: References: Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Aug 21, 2024 at 03:23:51PM -0600, Gustavo A. R. Silva wrote: > Replace one-element array with a flexible-array member in > `struct host_cmd_ds_802_11_scan_ext`. > > With this, fix the following warning: > > elo 16 17:51:58 surfacebook kernel: ------------[ cut here ]------------ > elo 16 17:51:58 surfacebook kernel: memcpy: detected field-spanning write (size 243) of single field "ext_scan->tlv_buffer" at drivers/net/wireless/marvell/mwifiex/scan.c:2239 (size 1) > elo 16 17:51:58 surfacebook kernel: WARNING: CPU: 0 PID: 498 at drivers/net/wireless/marvell/mwifiex/scan.c:2239 mwifiex_cmd_802_11_scan_ext+0x83/0x90 [mwifiex] > > Reported-by: Andy Shevchenko > Closes: https://lore.kernel.org/linux-hardening/ZsZNgfnEwOcPdCly@black.fi.intel.com/ > Signed-off-by: Gustavo A. R. Silva Acked-by: Brian Norris