From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: remove unnecessary display includes
Date: Fri, 23 Aug 2024 10:31:49 -0400 [thread overview]
Message-ID: <ZsidVbQKnjuuSgb3@intel.com> (raw)
In-Reply-To: <20240823123318.3189503-1-jani.nikula@intel.com>
On Fri, Aug 23, 2024 at 03:33:18PM +0300, Jani Nikula wrote:
> There are a number of leftover #include "display/..." directives that
> are completely unnecessary. Remove them to make it easier to spot the
> relevant ones. In one case, switch to a more specific include.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
trusting more the compiler then manual inspection:
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 2 --
> drivers/gpu/drm/i915/gt/intel_ggtt.c | 1 -
> drivers/gpu/drm/i915/i915_driver.c | 4 +---
> drivers/gpu/drm/i915/i915_gem.c | 2 --
> drivers/gpu/drm/i915/i915_gem_gtt.c | 1 -
> drivers/gpu/drm/i915/i915_irq.c | 1 -
> drivers/gpu/drm/i915/i915_pci.c | 1 -
> 7 files changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> index c58290274f97..01b7587dd1f8 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> @@ -12,8 +12,6 @@
> #include <drm/drm_auth.h>
> #include <drm/drm_syncobj.h>
>
> -#include "display/intel_frontbuffer.h"
> -
> #include "gem/i915_gem_ioctls.h"
> #include "gt/intel_context.h"
> #include "gt/intel_gpu_commands.h"
> diff --git a/drivers/gpu/drm/i915/gt/intel_ggtt.c b/drivers/gpu/drm/i915/gt/intel_ggtt.c
> index 206a5e0fedf1..d60a6ca0cae5 100644
> --- a/drivers/gpu/drm/i915/gt/intel_ggtt.c
> +++ b/drivers/gpu/drm/i915/gt/intel_ggtt.c
> @@ -12,7 +12,6 @@
> #include <drm/intel/i915_drm.h>
> #include <drm/intel/intel-gtt.h>
>
> -#include "display/intel_display.h"
> #include "gem/i915_gem_lmem.h"
>
> #include "intel_context.h"
> diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
> index e32766286369..ccdd2983cfb5 100644
> --- a/drivers/gpu/drm/i915/i915_driver.c
> +++ b/drivers/gpu/drm/i915/i915_driver.c
> @@ -49,7 +49,7 @@
> #include "display/intel_bw.h"
> #include "display/intel_cdclk.h"
> #include "display/intel_display_driver.h"
> -#include "display/intel_display_types.h"
> +#include "display/intel_display.h"
> #include "display/intel_dmc.h"
> #include "display/intel_dp.h"
> #include "display/intel_dpt.h"
> @@ -58,10 +58,8 @@
> #include "display/intel_hotplug.h"
> #include "display/intel_overlay.h"
> #include "display/intel_pch_refclk.h"
> -#include "display/intel_pipe_crc.h"
> #include "display/intel_pps.h"
> #include "display/intel_sprite.h"
> -#include "display/intel_vga.h"
> #include "display/skl_watermark.h"
>
> #include "gem/i915_gem_context.h"
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index 1391c01d7663..070ab6546987 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -39,8 +39,6 @@
> #include <drm/drm_cache.h>
> #include <drm/drm_vma_manager.h>
>
> -#include "display/intel_display.h"
> -
> #include "gem/i915_gem_clflush.h"
> #include "gem/i915_gem_context.h"
> #include "gem/i915_gem_ioctls.h"
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index 7bd1861ddbdf..a9662cc6ed1e 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -15,7 +15,6 @@
> #include <asm/set_memory.h>
> #include <asm/smp.h>
>
> -#include "display/intel_frontbuffer.h"
> #include "gt/intel_gt.h"
> #include "gt/intel_gt_requests.h"
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index 8059ac7e15fe..2321de48d169 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -34,7 +34,6 @@
> #include <drm/drm_drv.h>
>
> #include "display/intel_display_irq.h"
> -#include "display/intel_display_types.h"
> #include "display/intel_hotplug.h"
> #include "display/intel_hotplug_irq.h"
> #include "display/intel_lpe_audio.h"
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index 94c89ca2ef30..d37bb3a704d0 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -26,7 +26,6 @@
> #include <drm/drm_drv.h>
> #include <drm/intel/i915_pciids.h>
>
> -#include "display/intel_display.h"
> #include "display/intel_display_driver.h"
> #include "gt/intel_gt_regs.h"
> #include "gt/intel_sa_media.h"
> --
> 2.39.2
>
next prev parent reply other threads:[~2024-08-23 14:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-23 12:33 [PATCH] drm/i915: remove unnecessary display includes Jani Nikula
2024-08-23 13:33 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-08-23 14:31 ` Rodrigo Vivi [this message]
2024-08-26 8:38 ` [PATCH] " Jani Nikula
2024-08-24 13:15 ` ✗ Fi.CI.IGT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZsidVbQKnjuuSgb3@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.