From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 287A0187FFC; Fri, 23 Aug 2024 14:48:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724424492; cv=none; b=YPjPOigx16UyHx2zSGUaDubSE4YCMVZFjyiYihgXdDQAFCjvf2oBzq2e5zf/kJKk8a1oPWTx9lT9KQDngLuGbVrxEA68eyFBH2djY2/63Kyt2IG5WfoZIVw64ulWCWcv1HsSfe1F1OKf8/BDmGDZ/xMZZ2/WvPbz08zqJcv90KM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724424492; c=relaxed/simple; bh=oRK6C/+tY1XXLhNr5QfIgOfUkuRNl5VuJiB4P1b7u8E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=J4n4il/NMf/4u5YJJ5d5QadPWFx2NnUeJ2DCT+kcI//FVIjqR26EtaT7oAdANhp6GmUmLKhhPWQPI7zE7bRCN98osNYD5heWQtKGxkvQqJ8fCV3nnAhPvwOdjYddNmoGNgYZThLEM9j/yXxL10iweLH7ZUi9wpGY/j+dC9kRvKc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=FnEb8l61; arc=none smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="FnEb8l61" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724424491; x=1755960491; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=oRK6C/+tY1XXLhNr5QfIgOfUkuRNl5VuJiB4P1b7u8E=; b=FnEb8l61/vCnJIb9FRcudbziax1602kub0yAzg29Gk1RpBXkZ5fi7Esp 2DCboiRsqLZFe40W2kmOXSPWS+MsnViIIV7dQFLb1rTqNbgbl5ULTHp5n jqrPPLN/6hkFD1WUT0Y/XSk9Ihs8VuaxWpu/LQd/TLXt5lkq/zSiSOjnw loC0cA7w+xLg2e1bq0Cq4BlEgsqo7M+fpu7aUSzrdYGaeU+cddNEyY47o 104TXx8eBKnzclyPSCYVQMVMvrC54PErQYwYACZF5AeFVeGQlBEgOFeIT ydowAVTSegJqelT4FL/SWsghs7hEws2abW1qBmJMfD+9a3vy0WiiNi+JR Q==; X-CSE-ConnectionGUID: K1w6F9/rT46r8EBFdeNUVg== X-CSE-MsgGUID: h+m4/Vi2TzOKf+ZtAdMUQw== X-IronPort-AV: E=McAfee;i="6700,10204,11172"; a="23065988" X-IronPort-AV: E=Sophos;i="6.10,170,1719903600"; d="scan'208";a="23065988" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Aug 2024 07:48:10 -0700 X-CSE-ConnectionGUID: d/4Oulh+QpmEw0y6SEvIpg== X-CSE-MsgGUID: o5xH+gyqTVm500thYnpgAA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,170,1719903600"; d="scan'208";a="92542653" Received: from smile.fi.intel.com ([10.237.72.54]) by orviesa002.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Aug 2024 07:48:06 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1shVa7-00000000pED-1VXN; Fri, 23 Aug 2024 17:48:03 +0300 Date: Fri, 23 Aug 2024 17:48:03 +0300 From: Andy Shevchenko To: Ye Zhang Cc: linus.walleij@linaro.org, brgl@bgdev.pl, heiko@sntech.de, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, mika.westerberg@linux.intel.com, tao.huang@rock-chips.com, finley.xiao@rock-chips.com, tim.chen@rock-chips.com, elaine.zhang@rock-chips.com Subject: Re: [PATCH v2] gpio: rockchip: resolve overflow issues Message-ID: References: <20240823034314.62305-1-ye.zhang@rock-chips.com> <20240823034314.62305-4-ye.zhang@rock-chips.com> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240823034314.62305-4-ye.zhang@rock-chips.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Fri, Aug 23, 2024 at 11:43:06AM +0800, Ye Zhang wrote: > Prevent overflow issues when performing debounce-related calculations. ... > - max_debounce = (GENMASK(23, 0) + 1) * 2 * 1000000 / freq; > + div = (u64)(GENMASK(23, 0) + 1) * 2 * 1000000; You probably want to use HZ_PER_MHZ from units.h or so? -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8201C531DC for ; Fri, 23 Aug 2024 14:49:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Sq96N2676K2mDWg97NXdls/7kVnJc12d0dffGqt+dEA=; b=DZIN4fhOE725QR K0b+Dq7j4fwdxQPGwKxoWJWJ5q7IeLksPRS+4v+QpsmNF3IYraLvfjYJMZSimoHpJqhSONtSeGxF1 HaYVSeJ5Ln0AjMypR/McqyPO8K7mNB6f93AIbIBCAHAG9IGRQcAK8xBHcCVcZ/7Ar/ZExghilYSRe WHKLln2IoEwB7/37Tq+SgefwESWOcAySLByXeozlLrg64dN2KKnWyq+A548K9xjOPYv6/TLg5Kfyx +thsiV/AzyYzYf0cfbq3jaBgBtgCBjSqpT50rKOdHXQEpl66fIzn/iIf4sEKaF5QkxpkX9GPQJCfR rHFnup1H84igxKJaB4yQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1shVb2-0000000HAM2-37tU; Fri, 23 Aug 2024 14:49:00 +0000 Received: from mgamail.intel.com ([198.175.65.17]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1shVaF-0000000HAAj-3qKf; Fri, 23 Aug 2024 14:48:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724424492; x=1755960492; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=oRK6C/+tY1XXLhNr5QfIgOfUkuRNl5VuJiB4P1b7u8E=; b=KaKYicXBjqZmg2i9Doh2acJ/CxDN1SmIGsF8DTZDGuJ2AOGAogVkvWn/ 5bIGWEKm73QiMHVE3Hf8G643HIfZoyOmMcV/LAtNpS0w99WFSKcBMufNP 2hQjs0347xTlbjW8n2q9nJ7taaN5x0nW/rsdXw3cMR2t5bNutnmnElBlj NTCrxD0HtpHrJJ4ZVX1LFwwChjXdcndT1bPUtpuaruhvFUB3HDqJLqpZl paC8nf+UqpqhZXbe6crPmjd8eLWgPQiMH8aSUE3ZEn3OwI8ZeWHQS961H 9Sa32vBWlOXuSVzfZDH8syMxsHH6zwtl8dTsILuRftXUA4I3Bv7m06ofl w==; X-CSE-ConnectionGUID: ZKVwRPraRGmWA7QBszQTBw== X-CSE-MsgGUID: FSPp6mr9Q0SexxoA66LEJw== X-IronPort-AV: E=McAfee;i="6700,10204,11172"; a="23065990" X-IronPort-AV: E=Sophos;i="6.10,170,1719903600"; d="scan'208";a="23065990" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Aug 2024 07:48:10 -0700 X-CSE-ConnectionGUID: d/4Oulh+QpmEw0y6SEvIpg== X-CSE-MsgGUID: o5xH+gyqTVm500thYnpgAA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,170,1719903600"; d="scan'208";a="92542653" Received: from smile.fi.intel.com ([10.237.72.54]) by orviesa002.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Aug 2024 07:48:06 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1shVa7-00000000pED-1VXN; Fri, 23 Aug 2024 17:48:03 +0300 Date: Fri, 23 Aug 2024 17:48:03 +0300 From: Andy Shevchenko To: Ye Zhang Cc: linus.walleij@linaro.org, brgl@bgdev.pl, heiko@sntech.de, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, mika.westerberg@linux.intel.com, tao.huang@rock-chips.com, finley.xiao@rock-chips.com, tim.chen@rock-chips.com, elaine.zhang@rock-chips.com Subject: Re: [PATCH v2] gpio: rockchip: resolve overflow issues Message-ID: References: <20240823034314.62305-1-ye.zhang@rock-chips.com> <20240823034314.62305-4-ye.zhang@rock-chips.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240823034314.62305-4-ye.zhang@rock-chips.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240823_074812_076739_CE27DEA4 X-CRM114-Status: UNSURE ( 6.61 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Fri, Aug 23, 2024 at 11:43:06AM +0800, Ye Zhang wrote: > Prevent overflow issues when performing debounce-related calculations. ... > - max_debounce = (GENMASK(23, 0) + 1) * 2 * 1000000 / freq; > + div = (u64)(GENMASK(23, 0) + 1) * 2 * 1000000; You probably want to use HZ_PER_MHZ from units.h or so? -- With Best Regards, Andy Shevchenko _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip