From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3981A42A9F for ; Fri, 23 Aug 2024 17:15:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724433359; cv=none; b=Aw8QPOogNE+rD6Qdc5sDZ9731U46yXU777hG2gvg/whaetq6stQzyu00jsArlqqq/cW4T4ybIUMRSfAekWOkmhoTEdCb9A6YlV/ydbmqeKsIL8+80i7Es29+XGWI92IBimMgWjeWoX3nWOBP3vctxgaXh/Yz5Z+03YTWZqLrOp0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724433359; c=relaxed/simple; bh=VPZAtg08Wy5/FG+Kj/wTZuQQZpFnItvR2PIwTa5Vc/I=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=i8pP8MPuZmeQWExyK7sjRslR3Y90dKY7mqtJA3uopk5z+ZWzq9kCl8rbmQ/+UE7feHWxUQhrI6ptXQxWZDI6mRjm9tPVhwqZyUCeQ+kITyCuL6DZJ1OCeaNhQ4l5Nom9tTgo48DIOhBqJulUud5MWFlQwmPfh7q+Fgu2KQpxB9Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=fXIE0q43; arc=none smtp.client-ip=209.85.208.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="fXIE0q43" Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-5bf0261f162so2927846a12.0 for ; Fri, 23 Aug 2024 10:15:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1724433355; x=1725038155; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=Q5kboO0j45Is859BAgD4iFoFAta2hgxS6Xgur8E+680=; b=fXIE0q43JG/afuGoJEo+1ZFmAZyWLPTmqGuQgqMJ/4lFrRm0qZuHBzQqU5pb+FghpW h9I+J8sE1cbOerZ1XocD/Dsjwv0sbkDb32VVtnF1twJKGQ21qxpF9uoorvT2sCcHwf+f E68DXoobn8xvzK4zt9C+WC6FwLmWrhsoMdKaO9jWeCLyYa4VSPEBQifovEROjvrizcCJ zdYaEmq2IsAmQ6sS1DHygrF7Deu/CD1RCjMmo5B0fHQbG3J5ndKE/SQDnbvlvUfpdMbU 1mEq6JtTvaicqO++blC68QVaO4O2PyziwJPlE3P24TJ8Dfy6CkEplcuE68KAAQANAHAi nrMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724433355; x=1725038155; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Q5kboO0j45Is859BAgD4iFoFAta2hgxS6Xgur8E+680=; b=B9DO28pmp7igQA2dmeqGX+ZlDCpDF5QwLJ/eCZbSYcwO6DABbBelonPZcaT/Y1GdEF asyRXH9JlSas81nBql4p1xwqPKfB8HHME3kA5q4j3/yndl/DGE9q+J3OwNvIcEHfiQbj 3Z7fR+MsqLM9SJl88wGqWcNOhgy1FKW3ljitj1DUroirN9wrVSHe3j3q7/TJ6txxj4ws NxmZV2T7BL8KqJWnP7k2AkaMF4MNggUVANNiS/m4fknaHDjWzrEaG/ILmv4TZeC6BqUA oIQXQU3wT7vg9G886+DgqS382SwdIYSEG24ZxQ3A8cOz9yDC9VGO63Mv5YKLgO2q42dT 5Csw== X-Forwarded-Encrypted: i=1; AJvYcCUUTMHAGK0VSZ5EPRBK/Dn4JcbBb2bsjgfrTpjZ5/NMqS+56nE59rXAzFk4pVe0oLWB8tUxYSsk+UJO@vger.kernel.org X-Gm-Message-State: AOJu0YyCAh++nYyY0KT015aEqjTNsJvehkxa+3MVo76rSSRwsDlCHt4N FuLSbFBcMiHs+uyn2TZfKhFaAl7WcfBVpCGpTQ7QeSMFaWBG/FNr+Hsvjr5Qw7E= X-Google-Smtp-Source: AGHT+IGi+ju94qIZV+5dh+FC4edd1LJS/Rb5jnDSsIsgwxHk/+itiIP1aidxM/8be626D3wcbLPt/A== X-Received: by 2002:a17:907:2d0a:b0:a86:7199:af37 with SMTP id a640c23a62f3a-a86a54f142dmr198119466b.58.1724433354052; Fri, 23 Aug 2024 10:15:54 -0700 (PDT) Received: from localhost ([87.13.33.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a868f4862e8sm287339466b.173.2024.08.23.10.15.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Aug 2024 10:15:53 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Fri, 23 Aug 2024 19:16:00 +0200 To: Simon Horman Cc: Andrea della Porta , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Linus Walleij , Catalin Marinas , Will Deacon , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Nicolas Ferre , Claudiu Beznea , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Saravana Kannan , Bjorn Helgaas , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-arch@vger.kernel.org, Lee Jones , Andrew Lunn , Stefan Wahren Subject: Re: [PATCH 07/11] pinctrl: rp1: Implement RaspberryPi RP1 gpio support Message-ID: Mail-Followup-To: Simon Horman , Andrea della Porta , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Linus Walleij , Catalin Marinas , Will Deacon , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Nicolas Ferre , Claudiu Beznea , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Saravana Kannan , Bjorn Helgaas , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-arch@vger.kernel.org, Lee Jones , Andrew Lunn , Stefan Wahren References: <20240821132754.GC6387@kernel.org> Precedence: bulk X-Mailing-List: linux-arch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240821132754.GC6387@kernel.org> On 14:27 Wed 21 Aug , Simon Horman wrote: > On Tue, Aug 20, 2024 at 04:36:09PM +0200, Andrea della Porta wrote: > > The RP1 is an MFD supporting a gpio controller and /pinmux/pinctrl. > > Add minimum support for the gpio only portion. The driver is in > > pinctrl folder since upcoming patches will add the pinmux/pinctrl > > support where the gpio part can be seen as an addition. > > > > Signed-off-by: Andrea della Porta > > ... > > > diff --git a/drivers/pinctrl/pinctrl-rp1.c b/drivers/pinctrl/pinctrl-rp1.c > > ... > > > +const struct rp1_iobank_desc rp1_iobanks[RP1_NUM_BANKS] = { > > + /* gpio inte ints rio pads */ > > + { 0, 28, 0x0000, 0x011c, 0x0124, 0x0000, 0x0004 }, > > + { 28, 6, 0x4000, 0x411c, 0x4124, 0x4000, 0x4004 }, > > + { 34, 20, 0x8000, 0x811c, 0x8124, 0x8000, 0x8004 }, > > +}; > > rp1_iobanks seems to only be used in this file. > If so, it should be static. Fixed, thanks. > > Flagged by Sparse. > > ... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B8B8C531DC for ; Fri, 23 Aug 2024 17:17:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:Date:From:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Q5kboO0j45Is859BAgD4iFoFAta2hgxS6Xgur8E+680=; b=b3l83yNXPz4izvas50UWvtrDOa KJPVFyMA5sGz62rUXgHslIpVllS9zyCG/Rx+h8cP1hve7gkmQB6f3AXZ+dg/VsGaIjMpa+uCKa6xg Peq2CvKgTSVVjeMQdwnbgmAPnBn44hc2nOJbx2wOpkj3uSdUlzbTBeh4U6M0ml8nnxIw5YFJewCM7 WvvLIb70AErF+o+wuTWzJw5jJE6kr4wKGx+HxPqEyO/6fHq/rOI8tFOwuWXY7ZqK42kfSstf5D1DV qPYaJZ2rK06u7CQ3Y6CxGKGRZZjdLXBRdk4WQ+05OauetXMvDydKf/GRJZk+EX8nkvHvuZvdGyOiE cB23UBzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1shXuE-000000006CW-12HT; Fri, 23 Aug 2024 17:16:58 +0000 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1shXtE-0000000060T-0bLT for linux-arm-kernel@lists.infradead.org; Fri, 23 Aug 2024 17:15:58 +0000 Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-5bed72ff443so2775601a12.1 for ; Fri, 23 Aug 2024 10:15:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1724433355; x=1725038155; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=Q5kboO0j45Is859BAgD4iFoFAta2hgxS6Xgur8E+680=; b=RbFR0TddYRqqc0cSSpYjpVpoedgTz2JMk4wvPcTmsn2IbZGAxD99bQT0IXyL9pUbDV j8MHyV5xKxiaZFMQT65g1rHOegZ2Z6oqJhYHri9NG6LFNymWKcE8MsDCCT+qBKHb2Bvz rNmRqaaSdD88vL+Ugu5bz37jwi0k7+PMuf7VfO6udfoRd0PRHSQPZpeWvQXLb3Ln/6nJ VtlTWdz8ufyweAbLqgFEcTQvqiRr/ml6zVxdLdf1Z6RenxVs+CXwHGthCzr3gFcWxtmx VNKMb9SEvSeAxgDnMFX11qQfUk6IdHFjLYJzBLbrw59H4HPxWb+d1Vlbhmocucp8pOTw 69jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724433355; x=1725038155; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Q5kboO0j45Is859BAgD4iFoFAta2hgxS6Xgur8E+680=; b=imH/6lPcCInJ1fCnd+CtxQWj5zZ6uelv/x4mmbw78jenQivNYamMOkT5But2kuLswu HdO5UDC6RHuHecgZL+lPMVaiNR3kBC0mi2uUxr6EPCQ++GpobXvfs7ads++LhYHZw3MY vfc/rc+qLA8bVgwc6UNgYTWuqcQ9WMp9f98H0SjBNZrx/uCjq/RVnPCJmUGawhtD2uWn 6OWjO02eBtz85fkni9/H+dfcRsj1dnde5uJ3IPxZUYSeWrzP34VbGRCfgds/wP4gV1Qd 8k4IqFUjql343iWNKcFCYoL0bCA9kLqzwvwcAFT87AE3BtrBF2wuzlRTgingXJ0F/CcV zWQg== X-Forwarded-Encrypted: i=1; AJvYcCWwAaeXy6LPwwON3MeoOO8hYfcjFNOHJuQAVUM+4TWhHiFJ/pa1aEELQshnMrh3tuAcAj0H4lvd7CdMJjujSS7E@lists.infradead.org X-Gm-Message-State: AOJu0Yy3Q4toFxeMDrurDIkd7Ar5vNV3eMjTjB6n3CziFPBNQQ/YBdZH fzCGdHCeWakQP99DxMf0CczAXdcRrkooHy5rnlNeD5hs9+MbX6N6/uWEzBRnVVc= X-Google-Smtp-Source: AGHT+IGi+ju94qIZV+5dh+FC4edd1LJS/Rb5jnDSsIsgwxHk/+itiIP1aidxM/8be626D3wcbLPt/A== X-Received: by 2002:a17:907:2d0a:b0:a86:7199:af37 with SMTP id a640c23a62f3a-a86a54f142dmr198119466b.58.1724433354052; Fri, 23 Aug 2024 10:15:54 -0700 (PDT) Received: from localhost ([87.13.33.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a868f4862e8sm287339466b.173.2024.08.23.10.15.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Aug 2024 10:15:53 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Fri, 23 Aug 2024 19:16:00 +0200 To: Simon Horman Subject: Re: [PATCH 07/11] pinctrl: rp1: Implement RaspberryPi RP1 gpio support Message-ID: Mail-Followup-To: Simon Horman , Andrea della Porta , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Linus Walleij , Catalin Marinas , Will Deacon , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Nicolas Ferre , Claudiu Beznea , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Saravana Kannan , Bjorn Helgaas , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-arch@vger.kernel.org, Lee Jones , Andrew Lunn , Stefan Wahren References: <20240821132754.GC6387@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240821132754.GC6387@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240823_101556_238531_E525E2F4 X-CRM114-Status: GOOD ( 19.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Catalin Marinas , Michael Turquette , Claudiu Beznea , Eric Dumazet , Dragan Cvetic , Will Deacon , linux-clk@vger.kernel.org, linux-arch@vger.kernel.org, Rob Herring , Florian Fainelli , Lee Jones , Saravana Kannan , Broadcom internal kernel review list , linux-pci@vger.kernel.org, Jakub Kicinski , Paolo Abeni , Linus Walleij , devicetree@vger.kernel.org, Conor Dooley , Arnd Bergmann , linux-gpio@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Bjorn Helgaas , Andrea della Porta , linux-arm-kernel@lists.infradead.org, Derek Kiernan , Stephen Boyd , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Stefan Wahren , netdev@vger.kernel.org, Krzysztof Kozlowski , "David S. Miller" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 14:27 Wed 21 Aug , Simon Horman wrote: > On Tue, Aug 20, 2024 at 04:36:09PM +0200, Andrea della Porta wrote: > > The RP1 is an MFD supporting a gpio controller and /pinmux/pinctrl. > > Add minimum support for the gpio only portion. The driver is in > > pinctrl folder since upcoming patches will add the pinmux/pinctrl > > support where the gpio part can be seen as an addition. > > > > Signed-off-by: Andrea della Porta > > ... > > > diff --git a/drivers/pinctrl/pinctrl-rp1.c b/drivers/pinctrl/pinctrl-rp1.c > > ... > > > +const struct rp1_iobank_desc rp1_iobanks[RP1_NUM_BANKS] = { > > + /* gpio inte ints rio pads */ > > + { 0, 28, 0x0000, 0x011c, 0x0124, 0x0000, 0x0004 }, > > + { 28, 6, 0x4000, 0x411c, 0x4124, 0x4000, 0x4004 }, > > + { 34, 20, 0x8000, 0x811c, 0x8124, 0x8000, 0x8004 }, > > +}; > > rp1_iobanks seems to only be used in this file. > If so, it should be static. Fixed, thanks. > > Flagged by Sparse. > > ...