Re: [PATCH nft,v2 0/7] cache updates

[Eric Garver <eric@garver.life>]

On Mon, Aug 26, 2024 at 10:54:48AM +0200, Pablo Neira Ayuso wrote:
> Hi,
> 
> The following patchset contains cache updates for nft:
> 
> Patch #1 resets filtering for each new command
> 
> Patch #2 accumulates cache flags for each command, recent patches are
> 	 relaxing cache requirements which could uncover bugs.
> 
> Patch #3 updates objects to use the netlink dump filtering infrastructure
> 	 to build the cache (
> 
> Patch #4 only dumps rules for the given table
> 
> Patch #5 updates reset commands to use the cache infrastructure
> 
> Patch #6 and #7 extend tests coverage for reset commands.
> 
> Pablo Neira Ayuso (7):
>   cache: reset filter for each command
>   cache: accumulate flags in batch
>   cache: add filtering support for objects
>   cache: only dump rules for the given table
>   cache: consolidate reset command
>   tests: shell: cover anonymous set with reset command
>   tests: shell: cover reset command with counter and quota
> 
>  include/cache.h                               |  12 +-
>  include/netlink.h                             |   5 -
>  src/cache.c                                   | 201 ++++++++++++++----
>  src/evaluate.c                                |   2 +
>  src/mnl.c                                     |   7 +-
>  src/netlink.c                                 |  78 -------
>  src/parser_bison.y                            |   8 +-
>  src/rule.c                                    |  48 +----
>  tests/shell/testcases/listing/reset_objects   | 104 +++++++++
>  .../testcases/rule_management/0011reset_0     |  31 ++-
>  10 files changed, 305 insertions(+), 191 deletions(-)
>  create mode 100755 tests/shell/testcases/listing/reset_objects
> 
> -- 
> 2.30.2

I ran this against the firewalld testsuite; lgtm. It does not cover
"reset" commands.

Tested-by: Eric Garver <eric@garver.life>