All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Szabolcs Nagy <nsz@port70.net>,
	Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
	Szabolcs Nagy <szabolcs.nagy@arm.com>,
	netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
	edumazet@google.com, pabeni@redhat.com, mst@redhat.com,
	jasowang@redhat.com, arefev@swemel.ru, alexander.duyck@gmail.com,
	Willem de Bruijn <willemb@google.com>,
	stable@vger.kernel.org, Jakub Sitnicki <jakub@cloudflare.com>,
	Felix Fietkau <nbd@nbd.name>,
	Yury Khrustalev <yury.khrustalev@arm.com>,
	Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH net v2] net: drop bad gso csum_start and offset in virtio_net_hdr
Date: Mon, 9 Sep 2024 16:14:47 +0100	[thread overview]
Message-ID: <Zt8Q5wTHofvERY8p@bogus> (raw)
In-Reply-To: <0b14a8a8-4d98-46a3-9441-254345faa5df@sirena.org.uk>

On Mon, Sep 09, 2024 at 12:14:28PM +0100, Mark Brown wrote:
> On Mon, Sep 09, 2024 at 11:45:27AM +0200, Szabolcs Nagy wrote:
> 
> > fvp is closed source but has freely available binaries
> > for x86_64 glibc based linux systems (behind registration
> > and license agreements) so in principle the issue can be
> > reproduced outside of arm but using fvp is not obvious.
> 
> > hopefully somebody at arm can pick it up or at least
> > report this thread to the fvp team internally.
> 
> FWIW there's a tool called shrinkwrap which makes it quite a lot easier
> to get going:
> 
>    https://gitlab.arm.com/tooling/shrinkwrap
> 
> though since the models are very flexibile valid configurations that
> people see issues with aren't always covered by shrinkwrap.

It is fairly trivial to change the default config and use virtio-net to
reproduce this issue. If anyone tries the above tool, they can apply below
diff and should be able to reproduce the issue.

--
Regards,
Sudeep

diff --git i/config/FVP_Base_RevC-2xAEMvA-base.yaml w/config/FVP_Base_RevC-2xAEMvA-base.yaml
index 86d8cf9cb0f8..9951c5a948bb 100644
--- i/config/FVP_Base_RevC-2xAEMvA-base.yaml
+++ w/config/FVP_Base_RevC-2xAEMvA-base.yaml
@@ -39,8 +39,10 @@ description: >-
     # Networking. By default use user-space networking, mapping port 22 in the
     # FVP to a user-specified port on the host (see rtvar:LOCAL_NET_PORT). This
     # enables ssh.
-    -C bp.smsc_91c111.enabled: 1
-    -C bp.hostbridge.userNetworking: 1
+    -C bp.smsc_91c111.enabled: 0
+    -C bp.hostbridge.userNetworking: 0
+    -C bp.virtio_net.enabled: 1
+    -C bp.virtio_net.hostbridge.userNetworking: 1
     -C bp.hostbridge.userNetPorts: ${rtvar:LOCAL_NET_PORT}=22

     # FVP Performance tweaks.


  reply	other threads:[~2024-09-09 15:14 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-29 20:10 [PATCH net v2] net: drop bad gso csum_start and offset in virtio_net_hdr Willem de Bruijn
2024-07-31  2:00 ` patchwork-bot+netdevbpf
2024-09-06 14:35 ` Szabolcs Nagy
2024-09-06 15:52   ` Willem de Bruijn
2024-09-08 20:09     ` Willem de Bruijn
2024-09-08 20:43       ` Michael S. Tsirkin
2024-09-09  2:33         ` Jason Wang
2024-09-09  3:02           ` Willem de Bruijn
2024-09-09  3:24             ` Jason Wang
2024-09-09  3:39               ` Willem de Bruijn
2024-09-09  4:14                 ` Jason Wang
2024-09-09 15:20                   ` Willem de Bruijn
2024-09-09 21:09                     ` Willem de Bruijn
2024-09-10  1:12                       ` Willem de Bruijn
2024-09-09  9:45       ` Szabolcs Nagy
2024-09-09 11:14         ` Mark Brown
2024-09-09 15:14           ` Sudeep Holla [this message]
2024-09-09 15:21           ` Willem de Bruijn
2024-09-09 10:13     ` Yury Khrustalev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zt8Q5wTHofvERY8p@bogus \
    --to=sudeep.holla@arm.com \
    --cc=alexander.duyck@gmail.com \
    --cc=arefev@swemel.ru \
    --cc=broonie@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jakub@cloudflare.com \
    --cc=jasowang@redhat.com \
    --cc=kuba@kernel.org \
    --cc=mst@redhat.com \
    --cc=nbd@nbd.name \
    --cc=netdev@vger.kernel.org \
    --cc=nsz@port70.net \
    --cc=pabeni@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=szabolcs.nagy@arm.com \
    --cc=willemb@google.com \
    --cc=willemdebruijn.kernel@gmail.com \
    --cc=yury.khrustalev@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.