From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Kan Liang <kan.liang@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 1/1] tools build: Remove leftover libcap tests that prevents fast path feature detection from working
Date: Thu, 29 Aug 2024 11:54:39 -0300 [thread overview]
Message-ID: <ZtCLrySDaZNJAEQB@x1> (raw)
In-Reply-To: <CAP-5=fX-Viz40=J+WQTT8PUDQ+Wtsj1sjA5ZPTxXY4eZo2eXUA@mail.gmail.com>
On Wed, Aug 28, 2024 at 11:32:06PM -0700, Ian Rogers wrote:
> On Wed, Aug 28, 2024 at 3:11 PM Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > I noticed that the fast path feature detection was failing:
> > $ cat /tmp/build/perf-tools-next/feature/test-all.make.output
> > /usr/bin/ld: cannot find -lcap: No such file or directory
> > collect2: error: ld returned 1 exit status
> > $
> > The patch removing the dependency (Fixes tag below) didn't remove the
> > detection of libcap, and as the fast path feature detection (test-all.c)
> > had -lcap in its Makefile link list of libraries to link, it was failing
> > when libcap-devel is not available, fix it by removing those leftover
> > files.
> Isn't the feature test still in use by bpftool:
> https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/bpf/bpftool/Makefile?h=perf-tools-next#n103
> I'd deliberately not followed up in removing it because of this.
Right, I just reverted that patch, documenting in the revert text that
bpftool uses it, etc.
Thanks a lot!
- Arnaldo
prev parent reply other threads:[~2024-08-29 14:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 22:11 [PATCH 1/1] tools build: Remove leftover libcap tests that prevents fast path feature detection from working Arnaldo Carvalho de Melo
2024-08-29 6:32 ` Ian Rogers
2024-08-29 14:54 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZtCLrySDaZNJAEQB@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.