All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: Miao Wang <shankerwangmiao@gmail.com>
Cc: Hanjun Guo <guohanjun@huawei.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>, Sunil V L <sunilvl@ventanamicro.com>,
	linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] ACPI: introduce acpi_arch_init
Date: Thu, 29 Aug 2024 17:00:44 +0100	[thread overview]
Message-ID: <ZtCbLIfCklb5kQN1@bogus> (raw)
In-Reply-To: <4EC8AF0D-321F-437B-93C6-E597E4D4BB34@gmail.com>

On Wed, Aug 28, 2024 at 04:40:29AM +0800, Miao Wang wrote:
> 
> 
> > 2024年8月8日 17:43,Hanjun Guo <guohanjun@huawei.com> 写道:
> > 
> > On 2024/8/8 17:00, Miao Wang via B4 Relay wrote:
> >> From: Miao Wang <shankerwangmiao@gmail.com>
> >> To avoid arch-specific code in general ACPI initialization flow,
> >> we introduce a weak symbol acpi_arch_init. Currently, arm64 can
> >> utillize this to insert its specific flow. In the future,
> >> other architectures can also have chance to define their own
> >> arch-specific acpi initialization process if necessary.
> >> Signed-off-by: Miao Wang <shankerwangmiao@gmail.com>
> >> Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
> >> Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
> >> ---
> >> Changes from v1
> >> - Change acpi_arch_init from a static inline stub to a weak function
> >>   according to Haijun Guo's advice
> >> ---
> >> Changes from v2:
> >> - Add __init attribute to the weak acpi_arch_init stub
> >> - Link to v2: https://lore.kernel.org/r/20240807-intro-acpi-arch-init-v2-1-9231e23a7721@gmail.com
> > 
> > Thanks for the quick update,
> > 
> > Acked-by: Hanjun Guo <guohanjun@huawei.com>
> 
> Hi, all. I wonder whether this patch is good to be applied or
> any improvement is needed.
> 

LGTM. Rafael, do you want to take this via your tree or arm64(need your ack)
once you are happy with the change ?

-- 
Regards,
Sudeep

  reply	other threads:[~2024-08-29 16:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-08  9:00 [PATCH v3] ACPI: introduce acpi_arch_init Miao Wang
2024-08-08  9:00 ` Miao Wang via B4 Relay
2024-08-08  9:43 ` Hanjun Guo
2024-08-27 20:40   ` Miao Wang
2024-08-29 16:00     ` Sudeep Holla [this message]
2024-08-29 16:42       ` Rafael J. Wysocki
2024-08-29 17:58         ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZtCbLIfCklb5kQN1@bogus \
    --to=sudeep.holla@arm.com \
    --cc=guohanjun@huawei.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=rafael@kernel.org \
    --cc=shankerwangmiao@gmail.com \
    --cc=sunilvl@ventanamicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.