From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 338BECA0EE1 for ; Fri, 30 Aug 2024 05:56:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oTvnkSeBGngd+sfSI2B/hiRy8wkQHIGC4hg/cVEzvKM=; b=G4x1/PfD1ysD4X FQpn6QA9VenkXWiccy4NuAwwBKo+PcBSq9vbZFfx58V0TluCNqjg44IGLBaxoArVN1NIbmHKQUAdy ajcIxr6JI+Gu1UenJOhMRg+Nj3jyuDh6MOPS7ghfULJ++WhQ7vUY6zFAlvhtg3HtdDzBKUOCPEhyb vvG3HcxiGgEm87S2+60Ct1CJe2xvnnmvxkSA2jMzfCokguMePLJFjPFNh/YCJhgvoKQi0F0FAE5E8 EiPq8FO0dpSbNdFxnEdK7JwYcCqpyJoLSgpkZMfNyNmqxYqrojgGQ4zVIsSpssNA3Z+2EHpC3sMsE CI//15jCln/SJOeQyYww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjucm-00000004sK6-3o0z; Fri, 30 Aug 2024 05:56:44 +0000 Received: from gw2.atmark-techno.com ([35.74.137.57]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjucj-00000004sIs-469x for linux-phy@lists.infradead.org; Fri, 30 Aug 2024 05:56:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=atmark-techno.com; s=gw2_bookworm; t=1724997397; bh=x9yjOjFAohZtscac1sFvxpeu7yLK+GwtoV5bfW1JrOk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wXcaaVJUCXBWpGxgdT3ZXp3PUtR1mfC92445ncE9J5Hhp60v4Nm+H29gfkbQODNSr 8OdCMlo/ZuLmlYmX9XhILyiP4BCsn94ymbuFdM/wga9/Y10z0StkqDYWvUBN7U7ZMg 2zauCYVfGANlzVyieFXKONS4h6jJPMZ61dlM0Z5v5c+Y5gAegH6T5frUJLy5okLMv/ F/eLMfhT4rMRC9opHOF6i83BsX3xTtmwSlxKtcoFh0yco1zH61yTSflcpxWBN81Hnj wapTx9r43kX/21f+XiK4izKaOHTH8gi4R4Ns/sP0tm4kcno/pmsbkP2kyTtZbyTXHc rhP5mz3FK/INg== Received: from gw2.atmark-techno.com (localhost [127.0.0.1]) by gw2.atmark-techno.com (Postfix) with ESMTP id AC6D199F for ; Fri, 30 Aug 2024 14:56:37 +0900 (JST) Authentication-Results: gw2.atmark-techno.com; dkim=pass (2048-bit key; unprotected) header.d=atmark-techno.com header.i=@atmark-techno.com header.a=rsa-sha256 header.s=google header.b=hYg8QKfo; dkim-atps=neutral Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by gw2.atmark-techno.com (Postfix) with ESMTPS id ABCFE355 for ; Fri, 30 Aug 2024 14:56:35 +0900 (JST) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-714203541e1so1360365b3a.0 for ; Thu, 29 Aug 2024 22:56:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atmark-techno.com; s=google; t=1724997395; x=1725602195; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=mkYZPDGmaBN190bl0HbQlkXjB4c4DMUzWPODIPceod0=; b=hYg8QKfoa27YraLE/Fs7ec17kPJaOvFVu4l63teM5FmY/NBcKw4W2p5LQasJ8vwFwM xKH/8z2LCw0/35n5gCrrbTk7r6u9pgPAlsZOHC3AUN8WwJPeeAa163bDpkqH5LpMoLWX me5aGJk3GzYDmRNa58iv3hfQ3cPHVppkbZxZ/qio+F+I+aaK4QGqvrvcfPcWH0gxDXHh ae4gtZRsUQoSXJ1uBWjvNDt3RcBDiCjbi8KH314uGm9IBAozPueM+8NGRZkhT+YQu8Kn N5215PZkxarrpyd9ycXkULEzHyvQak1KnGkJL2n/poRVkBNemCWWU2z/5u7ZASg8jgIu 9Log== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724997395; x=1725602195; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mkYZPDGmaBN190bl0HbQlkXjB4c4DMUzWPODIPceod0=; b=nFktA0nyZBM4L1AGMDHGzO+pFPKzlcIxHbj/SoY0qHzFfZRXIOT+vTGii9z+BWWjS7 ZAwTtq9AS8uGCeI35avJbaQhLTQkPCvD9r/2m2l7gKtizOK6uGGK+MNf/J3SXmadmReR m0rDokllCYRRT+DAi8Kkju5C5DZvgEIvgii1E1zMWsdWygo4RF0/scNdgcFdxmdo57oA vM8+IppFHMU4QozZ5jwZUS6b8pXwGSSJyUwlmgEOxhik3LJBd1QZqZzaIrdq9gDzbo8B D+HMOgERcZENXXvF3pBT9lLPctv2OgGTwccYWVXSG+iLm4xw0tW/I0H98uNvxbU76shN BhqQ== X-Gm-Message-State: AOJu0YwEZB4TiDwOgLhHNEQz9k42nbQq9p8UfbLYlGPov1dFYCBJH89L 22fVaJWAC8DCvCXmVTIQMRLHCvMTXwUavX135J/hYUD3Ackpcf2AtM4ujiE2OwrUv2e5IsKX1Ic zfApG8A5AKNlzDi1a03u1UaHRvh9TiVwdlvVSfkHDQUEvNxZzbKKfUpRrWdLxZTBIZx5NUcEkr4 k= X-Received: by 2002:a05:6a00:234a:b0:714:1fc3:79f7 with SMTP id d2e1a72fcca58-715dfc506a0mr7113317b3a.17.1724997394663; Thu, 29 Aug 2024 22:56:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEospLhuiiaJ+JXW7SbcBkbVDDo2i03cNpb6xUMWtOllEbOfcXeI36XV92dVw14GmctIFDlqw== X-Received: by 2002:a05:6a00:234a:b0:714:1fc3:79f7 with SMTP id d2e1a72fcca58-715dfc506a0mr7113295b3a.17.1724997394145; Thu, 29 Aug 2024 22:56:34 -0700 (PDT) Received: from pc-0182.atmarktech (117.209.187.35.bc.googleusercontent.com. [35.187.209.117]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-715e55a44e4sm2019480b3a.56.2024.08.29.22.56.33 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Aug 2024 22:56:33 -0700 (PDT) Received: from martinet by pc-0182.atmarktech with local (Exim 4.96) (envelope-from ) id 1sjuca-00E9Fv-0o; Fri, 30 Aug 2024 14:56:32 +0900 Date: Fri, 30 Aug 2024 14:56:22 +0900 From: Dominique Martinet To: Adam Ford Cc: linux-phy@lists.infradead.org, linux-imx@nxp.com, festevam@gmail.com, frieder.schrempf@kontron.de, aford@beaconembedded.com, Vinod Koul , Kishon Vijay Abraham I , Marco Felsch , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Lucas Stach , linux-kernel@vger.kernel.org, Makoto Sato Subject: Re: [RFC V3 3/3] phy: freescale: fsl-samsung-hdmi: Support dynamic integer Message-ID: References: <20240830032442.226031-1-aford173@gmail.com> <20240830032442.226031-3-aford173@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240830032442.226031-3-aford173@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240829_225642_158967_9B378CCB X-CRM114-Status: GOOD ( 46.72 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org QWRhbSBGb3JkIHdyb3RlIG9uIFRodSwgQXVnIDI5LCAyMDI0IGF0IDEwOjI0OjI3UE0gLTA1MDA6 Cj4gVGhlcmUgaXMgY3VycmVudGx5IGEgbG9vay11cCB0YWJsZSBmb3IgYSB2YXJpZXR5IG9mIHJl c29sdXRpb25zLgo+IFNpbmNlIHRoZSBwaHkgaGFzIHRoZSBhYmlsaXR5IHRvIGR5bmFtaWNhbGx5 IGNhbGN1bGF0ZSB0aGUgdmFsdWVzCj4gbmVjZXNzYXJ5IHRvIHVzZSB0aGUgaW50Z2VyIGRpdmlk ZXIgd2hpY2ggc2hvdWxkIGFsbG93IG1vcmUKPiByZXNvbHV0aW9ucyB3aXRob3V0IGhhdmluZyB0 byB1cGRhdGUgdGhlIGxvb2stdXAtdGFibGUuCj4gCj4gSWYgdGhlIGxvb2t1cCB0YWJsZSBjYW5u b3QgZmluZCBhbiBleGFjdCBtYXRjaCwgZmFsbCBiYWNrIHRvIHRoZQo+IGR5bmFtaWMgY2FsY3Vs YXRvciBvZiB0aGUgaW50ZWdlciBkaXZpZGVyLgo+IAo+IFByZXZpb3VzbHksIHRoZSB2YWx1ZSBv ZiBQIHdhcyBoYXJkLWNvZGVkIHRvIDEsIHRoaXMgcmVxdWlyZWQgYW4KPiB1cGRhdGUgdG8gdGhl IHBoeV9wbGxfY2ZnIHRhYmxlIHRvIGFkZCBpbiB0aGUgZXh0cmEgdmFsdWUgaW50byB0aGUKPiB0 YWJsZSwgc28gaWYgdGhlIHZhbHVlIG9mIFAgaXMgY2FsY3VsYXRlZCB0byBiZSBzb21ldGhpbmcg ZWxzZQo+IGJ5IHRoZSBQTVMgY2FsY3VsYXRvciwgdGhlIGNhbGN1bGF0ZWRfcGh5X3BsbF9jZmcg c3RydWN0dXJlCj4gY2FuIGJlIHVzZWQgaW5zdGVhZCB3aXRob3V0IGhhdmluZyB0byBrZWVwIHRy YWNrIG9mIHdoaWNoIG1ldGhvZAo+IHdhcyB1c2VkLgoKVGhhbmsgeW91IQoKSSd2ZSB1cGRhdGVk IHRvIHYzIGFuZCB3ZSBtdXN0IGhhdmUgbWlzc2VkIHNvbWV0aGluZyBmaWRkbGluZyB3aXRoIHYx CmJ1dCBvdXIgMzEuNU1Iei1vbmx5IHNjcmVlbiB0dXJucyBvbiB3aXRoIHRoaXMhCgpVbmZvcnR1 bmF0ZWx5IGFtb25nIHRoZSBvdGhlciBvZGQgZGV2aWNlcyB3ZSBzdXBwb3J0LCB0aGVyZSdzIG9u ZQp3aG9zZSBuYXRpdmUgcmVzb2x1dGlvbiBvbmx5IHN1cHBvcnRzIDgzLjVNSHosIGFuZCB0aGF0 IGRvZXNuJ3QgY29tZSBvdXQKcmlnaHQgd2l0aCB0aGUgaW50ZWdlciBkaXZpZGVyICh0aGF0IGZ1 bmN0aW9uIHJldHVybnMgODMuMk1Ieiwgd2hpY2ggaXMKMC40JW9mZikKSWYgd2UgZm9yY2UgdGhl IHJvdW5kL3NldCByYXRlIGZ1bmN0aW9ucyB0byBwcmVmZXIgdGhlIGNhbGN1bGF0ZWQgdmFsdWUK YW5kIGFsbG93IHRoYXQgaW4gaW14OG1wX2hkbWlfY2hlY2tfY2xrX3JhdGUgKGR3X2hkbWktaW14 LmMpIHRoZW4gaXQKYWxzbyB3b3Jrcywgc28gSSBkb24ndCB0aGluayB3ZSBhY3R1YWxseSBuZWVk IHRvIGFmZmluZSB0aGUgbW9kZWwuLi4KQ29taW5nIGJhY2sgdG8gd2hhdCBMdWNhcyByZXBsaWVk IHRvIG15IGluaXRpYWwgbWFpbCBIRE1JIHdvdWxkIGFsc28gYQpyYXRlIG1pc21hdGNoIG9mIMKx MC41JSwgc28gdGhlIGludGVnZXIgY2FsY3VsYXRvciB3b3JrcyBmb3IgYWxsIHRoZQpmcmVxdWVu Y2llcyB3ZSd2ZSBjdXJyZW50bHkgYWRkZWQgbWFudWFsbHkgaWYgd2UgZml4IHRoZSBjaGVjayB0 byBhbGxvdwp0aGF0IGFzIHdlbGw6CjMyMDAwMDAwOiBmb3VuZCAzMjAwMDAwMCAoMTAwLjAlIG1h dGNoKTogcCAxIC8gbSA4MCAvIHMgMTIKNTEyMDAwMDA6IGZvdW5kIDUxMjAwMDAwICgxMDAuMCUg bWF0Y2gpOiBwIDEgLyBtIDY0IC8gcyA2CjY1MDAwMDAwOiBmb3VuZCA2NDgwMDAwMCAoOTkuNiUg bWF0Y2gpOiBwIDEgLyBtIDU0IC8gcyA0CjcxMDAwMDAwOiBmb3VuZCA3MDgwMDAwMCAoOTkuNyUg bWF0Y2gpOiBwIDEgLyBtIDU5IC8gcyA0CjgzNTAwMDAwOiBmb3VuZCA4MzIwMDAwMCAoOTkuNiUg bWF0Y2gpOiBwIDEgLyBtIDEwNCAvIHMgNgoKKG9ubHkgYWN0dWFsbHkgdGVzdGVkIDUxLjIgYW5k IDgzLjUgaGVyZSwgd2UgZG9uJ3QgaGF2ZSBhbGwgdGhlIGhhcmR3YXJlCmF2YWlsYWJsZTsgSSds bCB0cnkgdG8gcGxheSB3aXRoIG5vcm1hbCBtb25pdG9ycyB0aGF0IHN1cHBvcnQgbW9yZSBtb2Rl cwpvbmNlIHRoZSBwYXRjaCBnZXRzIGZ1cnRoZXIgZmluYWxpemVkKQoKClNvLCBhcyBmYXIgYXMg SSdtIGNvbmNlcm5lZCBJJ2QgYmUgaGFwcHkgdG8gbW92ZSBmb3J3YXJkIHdpdGggdGhhdCBhbmQK d2lsbCBiYWNrcG9ydCB0aGlzIHRvIG91ciB0cmVlL3JlbW92ZSBvdXIga2x1ZGdlZCB2YWx1ZXMs IHdvdWxkICJqdXN0IgpuZWVkIHRvIHByb3Blcmx5IHBpY2sgdGhlIGNsb3Nlc3QgdmFsdWUgaWYg bm8gZXhhY3QgbWF0Y2ggaW5zdGVhZCBvZgphbHdheXMgZmFsbGluZyBiYWNrIHRvIHRoZSB0YWJs ZSAob3IganVzdCByZW1vdmUgdGhlIHRhYmxlIGFsdG9nZXRoZXIgaWYKd2UgY2FuIHRlc3QgYSBm ZXcgbW9uaXRvcnM/KQoKQSBjb3VwbGUgb2Ygc3R5bGUgbml0cGlja3MgYmVsb3cKCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvcGh5L2ZyZWVzY2FsZS9waHktZnNsLXNhbXN1bmctaGRtaS5jIGIvZHJp dmVycy9waHkvZnJlZXNjYWxlL3BoeS1mc2wtc2Ftc3VuZy1oZG1pLmMKPiBpbmRleCBhNzAwYTMw MGRjNmYuLjNmYWI0MGNkZTQwZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3BoeS9mcmVlc2NhbGUv cGh5LWZzbC1zYW1zdW5nLWhkbWkuYwo+ICsrKyBiL2RyaXZlcnMvcGh5L2ZyZWVzY2FsZS9waHkt ZnNsLXNhbXN1bmctaGRtaS5jCj4gQEAgLTE2LDYgKzE2LDggQEAKPiAgCj4gICNkZWZpbmUgUEhZ X1JFRyhyZWcpCQkocmVnICogNCkKPiAgCj4gKyNkZWZpbmUgUkVHMDFfUE1TX1BfTUFTSwlHRU5N QVNLKDMsIDApCj4gKyNkZWZpbmUgUkVHMDNfUE1TX1NfTUFTSwlHRU5NQVNLKDcsIDQpCj4gICNk ZWZpbmUgUkVHMTJfQ0tfRElWX01BU0sJR0VOTUFTSyg1LCA0KQo+ICAjZGVmaW5lIFJFRzEzX1RH X0NPREVfTE9XX01BU0sJR0VOTUFTSyg3LCAwKQo+ICAjZGVmaW5lIFJFRzE0X1RPTF9NQVNLCQlH RU5NQVNLKDcsIDQpCj4gQEAgLTI5LDI4MSArMzEsMjk2IEBACj4gICNkZWZpbmUgUkVHMzRfUExM X0xPQ0sJCUJJVCg2KQo+ICAjZGVmaW5lIFJFRzM0X1BIWV9DTEtfUkVBRFkJQklUKDUpCj4gIAo+ IC0jZGVmaW5lIFBIWV9QTExfRElWX1JFR1NfTlVNIDYKPiArI2lmbmRlZiBNSFoKPiArI2RlZmlu ZSBNSFoJKDEwMDBVTCAqIDEwMDBVTCkKPiArI2VuZGlmCj4gKwo+ICsjZGVmaW5lIFBIWV9QTExf RElWX1JFR1NfTlVNIDcKPiAgCj4gIHN0cnVjdCBwaHlfY29uZmlnIHsKPiAgCXUzMglwaXhjbGs7 Cj4gIAl1OAlwbGxfZGl2X3JlZ3NbUEhZX1BMTF9ESVZfUkVHU19OVU1dOwo+ICB9Owo+ICAKPiAr LyoKPiArICogVGhlIGNhbGN1bGF0ZWRfcGh5X3BsbF9jZmcgb25seSBoYW5kbGVzIGludGVnZXIg ZGl2aWRlciBmb3IgUE1TIG9ubHksCj4gKyAqIG1lYW5pbmcgdGhlIGxhc3QgZm91ciBlbnRyaWVz IHdpbGwgYmUgZml4ZWQsIGJ1dCB0aGUgZmlyc3QgdGhyZWUgd2lsbAo+ICsgKiBiZSBjYWxjdWxh dGVkIGJ5IHRoZSBQTVMgY2FsY3VsYXRvcgo+ICsgKi8KPiArc3RhdGljIHN0cnVjdCBwaHlfY29u ZmlnIGNhbGN1bGF0ZWRfcGh5X3BsbF9jZmcgPSB7CgpJJ2QgY2hhbmdlIGN1cl9jZmcgZnJvbSBw b2ludGVyIHRvIHRoZSBzdHJ1Y3QgaXRzZWxmIGxpa2UgdGhpcyAocGFydGlhbApwYXRjaCB0aGF0 IHByb2JhYmx5IHdvbid0IGV2ZW4gYXBwbHkgb24geW91ciBicmFuY2g6KQotLS0tCmRpZmYgLS1n aXQgYS9kcml2ZXJzL3BoeS9mcmVlc2NhbGUvcGh5LWZzbC1zYW1zdW5nLWhkbWkuYyBiL2RyaXZl cnMvcGh5L2ZyZWVzY2FsZS9waHktZnNsLXNhbXN1bmctaGRtaS5jCmluZGV4IDkwNDhjZGM3NjBj Mi4uZDcxMjQ2MDQ4MTljIDEwMDY0NAotLS0gYS9kcml2ZXJzL3BoeS9mcmVlc2NhbGUvcGh5LWZz bC1zYW1zdW5nLWhkbWkuYworKysgYi9kcml2ZXJzL3BoeS9mcmVlc2NhbGUvcGh5LWZzbC1zYW1z dW5nLWhkbWkuYwpAQCAtNDAyLDcgKzQwMiw3IEBAIHN0cnVjdCBmc2xfc2Ftc3VuZ19oZG1pX3Bo eSB7CiAKIAkvKiBjbGsgcHJvdmlkZXIgKi8KIAlzdHJ1Y3QgY2xrX2h3IGh3OwotCWNvbnN0IHN0 cnVjdCBwaHlfY29uZmlnICpjdXJfY2ZnOworCXN0cnVjdCBwaHlfY29uZmlnIGN1cl9jZmc7CiB9 OwogCiBzdGF0aWMgaW5saW5lIHN0cnVjdCBmc2xfc2Ftc3VuZ19oZG1pX3BoeSAqCkBAIC01NjIs OSArNTYyLDkgQEAgc3RhdGljIGludCBwaHlfY2xrX3NldF9yYXRlKHN0cnVjdCBjbGtfaHcgKmh3 LAogCWlmIChpIDwgMCkKIAkJcmV0dXJuIC1FSU5WQUw7CiAKLQlwaHktPmN1cl9jZmcgPSAmcGh5 X3BsbF9jZmdbaV07CisJcGh5LT5jdXJfY2ZnID0gcGh5X3BsbF9jZmdbaV07CiAKLQlyZXR1cm4g ZnNsX3NhbXN1bmdfaGRtaV9waHlfY29uZmlndXJlKHBoeSwgcGh5LT5jdXJfY2ZnKTsKKwlyZXR1 cm4gZnNsX3NhbXN1bmdfaGRtaV9waHlfY29uZmlndXJlKHBoeSwgJnBoeS0+Y3VyX2NmZyk7CiB9 CiAKIHN0YXRpYyBjb25zdCBzdHJ1Y3QgY2xrX29wcyBwaHlfY2xrX29wcyA9IHsKLS0tLQoKVGhl biB5b3UgY2FuIGp1c3Qgc2V0IGl0IGRpcmVjdGx5IGZvciBjYWxjdWxhdGVkIHZhbHVlcy4KQnV0 IGNvbmNlcHR1YWxseSBpdCdzIHRoZSBzYW1lLCBqdXN0IG9uZSBsZXNzIGluZGlyZWN0aW9uLgoK PiBAQCAtNDA2LDYgKzQyNCw3NiBAQCBmc2xfc2Ftc3VuZ19oZG1pX3BoeV9jb25maWd1cmVfcGxs X2xvY2tfZGV0KHN0cnVjdCBmc2xfc2Ftc3VuZ19oZG1pX3BoeSAqcGh5LAo+ICAJICAgICAgIHBo eS0+cmVncyArIFBIWV9SRUcoMTQpKTsKPiAgfQo+ICAKPiArc3RhdGljIHVuc2lnbmVkIGxvbmcg ZnNsX3NhbXN1bmdfaGRtaV9waHlfZmluZF9wbXModW5zaWduZWQgbG9uZyBmb3V0LCB1OCAqcCwg dTE2ICptLCB1OCAqcykKPiArewo+ICsJdW5zaWduZWQgbG9uZyBiZXN0X2ZyZXEgPSAwOwo+ICsJ dTMyIG1pbl9kZWx0YSA9IDB4ZmZmZmZmZmY7Cj4gKwl1OCBfcCwgYmVzdF9wOwo+ICsJdTE2IF9t LCBiZXN0X207Cj4gKwl1OCBfcywgYmVzdF9zOwo+ICsKPiArCS8qIFRoZSByZWYgbWFudWFsIHN0 YXRlcyB0aGUgdmFsdWVzIG9mICdQJyByYW5uZ2UgZnJvbSAxIHRvIDExICovCgp0eXBvOiByYW5n ZQoKPiArCWZvciAoX3AgPSAxOyBfcCA8PSAxMTsgKytfcCkgewo+ICsJCWZvciAoX3MgPSAxOyBf cyA8PSAxNjsgKytfcykgewo+ICsJCQl1NjQgdG1wOwo+ICsJCQl1MzIgZGVsdGE7Cj4gKwo+ICsJ CQkvKiBzIG11c3QgYmUgb25lIG9yIGV2ZW4gKi8KPiArCQkJaWYgKF9zID4gMSAmJiAoX3MgJiAw eDAxKSA9PSAxKQo+ICsJCQkJX3MrKzsKPiArCj4gKwkJCS8qIF9zIGNhbm5vdCBiZSAxNCBwZXIg dGhlIFRSTSAqLwo+ICsJCQlpZiAoX3MgPT0gMTQpCj4gKwkJCQljb250aW51ZTsKPiArCj4gKwkJ CS8qCj4gKwkJCSAqIFRPRE86IFJlZiBNYW51YWwgZG9lc24ndCBzdGF0ZSB0aGUgcmFuZ2Ugb2Yg X20KPiArCQkJICogc28gdGhpcyBzaG91bGQgYmUgZnVydGhlciByZWZpbmVkIGlmIHBvc3NpYmxl Lgo+ICsJCQkgKiBUaGlzIHJhbmdlIHdhcyBzZXQgYmFzZWQgb24gdGhlIG9yaWdpbmFsIHZhbHVl cwo+ICsJCQkgKiBpbiB0aGUgbG9vay11cCB0YWJsZQo+ICsJCQkgKi8KPiArCQkJdG1wID0gKHU2 NClmb3V0ICogKF9wICogX3MpOwo+ICsJCQlkb19kaXYodG1wLCAyNCAqIE1IWik7Cj4gKwkJCV9t ID0gdG1wOwo+ICsJCQlpZiAoX20gPCAweDMwIHx8IF9tID4gMHg3YikKPiArCQkJCWNvbnRpbnVl Owo+ICsKPiArCQkJLyoKPiArCQkJICogUmV2IDIgb2YgdGhlIFJlZiBNYW51YWwgc3RhdGVzIHRo ZQo+ICsJCQkgKiBWQ08gY2FuIHJhbmdlIGJldHdlZW4gNzUwTUh6IGFuZAo+ICsJCQkgKiAzR0h6 LiAgVGhlIFZDTyBpcyBhc3N1bWVkIHRvIGJlIF9tIHgKPiArCQkJICogdGhlIHJlZmVyZW5jZSBm cmVxdWVuY3kgb2YgMjRNSHogZGl2aWRlZAo+ICsJCQkgKiBieSB0aGUgcHJlc2NhbGVyLCBfcAo+ ICsJCQkgKi8KPiArCQkJdG1wID0gKHU2NClfbSAqIDI0ICogTUhaOwo+ICsJCQlkb19kaXYodG1w LCBfcCk7Cj4gKwkJCWlmICh0bXAgPCA3NTAgKiBNSFogfHwKPiArCQkJICAgIHRtcCA+IDMwMDAg KiBNSFopCj4gKwkJCQljb250aW51ZTsKPiArCj4gKwkJCXRtcCA9ICh1NjQpX20gKiAyNCAqIE1I WjsKPiArCQkJZG9fZGl2KHRtcCwgX3AgKiBfcyk7Cj4gKwo+ICsJCQlkZWx0YSA9IGFicyhmb3V0 IC0gdG1wKTsKPiArCQkJaWYgKGRlbHRhIDwgbWluX2RlbHRhKSB7Cj4gKwkJCQliZXN0X3AgPSBf cDsKPiArCQkJCWJlc3RfcyA9IF9zOwo+ICsJCQkJYmVzdF9tID0gX207Cj4gKwkJCQltaW5fZGVs dGEgPSBkZWx0YTsKPiArCQkJCWJlc3RfZnJlcSA9IHRtcDsKPiArCQkJfQo+ICsJCX0KPiArCX0K PiArCj4gKwlpZiAoYmVzdF9mcmVxKSB7Cj4gKwkJKnAgPSBiZXN0X3A7Cj4gKwkJKm0gPSBiZXN0 X207Cj4gKwkJKnMgPSBiZXN0X3M7Cj4gKwl9Cj4gKwo+ICsJcmV0dXJuIGJlc3RfZnJlcTsKPiAr fQo+ICsKPiAgc3RhdGljIGludCBmc2xfc2Ftc3VuZ19oZG1pX3BoeV9jb25maWd1cmUoc3RydWN0 IGZzbF9zYW1zdW5nX2hkbWlfcGh5ICpwaHksCj4gIAkJCQkJICBjb25zdCBzdHJ1Y3QgcGh5X2Nv bmZpZyAqY2ZnKQo+ICB7Cj4gQEAgLTQxOSwxMyArNTA3LDEzIEBAIHN0YXRpYyBpbnQgZnNsX3Nh bXN1bmdfaGRtaV9waHlfY29uZmlndXJlKHN0cnVjdCBmc2xfc2Ftc3VuZ19oZG1pX3BoeSAqcGh5 LAo+ICAJZm9yIChpID0gMDsgaSA8IEFSUkFZX1NJWkUoY29tbW9uX3BoeV9jZmcpOyBpKyspCj4g IAkJd3JpdGViKGNvbW1vbl9waHlfY2ZnW2ldLnZhbCwgcGh5LT5yZWdzICsgY29tbW9uX3BoeV9j ZmdbaV0ucmVnKTsKPiAgCj4gLQkvKiBzZXQgaW5kaXZpZHVhbCBQTEwgcmVnaXN0ZXJzIFBIWV9S RUcyIC4uLiBQSFlfUkVHNyAqLwo+ICsJLyogc2V0IGluZGl2aWR1YWwgUExMIHJlZ2lzdGVycyBQ SFlfUkVHMSAuLi4gUEhZX1JFRzcgKi8KPiAgCWZvciAoaSA9IDA7IGkgPCBQSFlfUExMX0RJVl9S RUdTX05VTTsgaSsrKQo+IC0JCXdyaXRlYihjZmctPnBsbF9kaXZfcmVnc1tpXSwgcGh5LT5yZWdz ICsgUEhZX1JFRygyKSArIGkgKiA0KTsKPiArCQl3cml0ZWIoY2ZnLT5wbGxfZGl2X3JlZ3NbaV0s IHBoeS0+cmVncyArIFBIWV9SRUcoMSkgKyBpICogNCk7Cj4gIAo+IC0JLyogSGlnaCBuaWJibGUg b2YgcGxsX2Rpdl9yZWdzWzFdIGNvbnRhaW5zIFMgd2hpY2ggYWxzbyBnZXRzIHdyaXR0ZW4gdG8g UkVHMjEgKi8KPiArCS8qIEhpZ2ggbmliYmxlIG9mIFBIWV9SRUczIGFuZCBsb3cgbmliYmxlIG9m IFBIWV9SRUcyMSBib3RoIGNvbnRhaW4gJ1MnICovCj4gIAl3cml0ZWIoUkVHMjFfU0VMX1RYX0NL X0lOViB8IEZJRUxEX1BSRVAoUkVHMjFfUE1TX1NfTUFTSywKPiAtCSAgICAgICBjZmctPnBsbF9k aXZfcmVnc1sxXSA+PiA0KSwgcGh5LT5yZWdzICsgUEhZX1JFRygyMSkpOwo+ICsJICAgICAgIGNm Zy0+cGxsX2Rpdl9yZWdzWzJdID4+IDQpLCBwaHktPnJlZ3MgKyBQSFlfUkVHKDIxKSk7Cj4gIAo+ ICAJZnNsX3NhbXN1bmdfaGRtaV9waHlfY29uZmlndXJlX3BsbF9sb2NrX2RldChwaHksIGNmZyk7 Cj4gIAo+IEBAIC00NTMsMjkgKzU0MSw3MCBAQCBzdGF0aWMgdW5zaWduZWQgbG9uZyBwaHlfY2xr X3JlY2FsY19yYXRlKHN0cnVjdCBjbGtfaHcgKmh3LAo+ICBzdGF0aWMgbG9uZyBwaHlfY2xrX3Jv dW5kX3JhdGUoc3RydWN0IGNsa19odyAqaHcsCj4gIAkJCSAgICAgICB1bnNpZ25lZCBsb25nIHJh dGUsIHVuc2lnbmVkIGxvbmcgKnBhcmVudF9yYXRlKQo+ICB7Cj4gKwl1MzIgaW50X2Rpdl9jbGs7 Cj4gIAlpbnQgaTsKPiArCXUxNiBtOwo+ICsJdTggcCwgczsKPiArCj4gKwkvKiBJZiB0aGUgY2xv Y2sgaXMgb3V0IG9mIHJhbmdlIHJldHVybiBlcnJvciBpbnN0ZWFkIG9mIHNlYXJjaGluZyAqLwo+ ICsJaWYgKHJhdGUgPiAyOTcwMDAwMDAgfHwgcmF0ZSA8IDIyMjUwMDAwKQo+ICsJCXJldHVybiAt RUlOVkFMOwo+ICAKPiArCS8qIENoZWNrIHRoZSBsb29rLXVwIHRhYmxlICovCj4gIAlmb3IgKGkg PSBBUlJBWV9TSVpFKHBoeV9wbGxfY2ZnKSAtIDE7IGkgPj0gMDsgaS0tKQo+ICAJCWlmIChwaHlf cGxsX2NmZ1tpXS5waXhjbGsgPD0gcmF0ZSkKPiAtCQkJcmV0dXJuIHBoeV9wbGxfY2ZnW2ldLnBp eGNsazsKPiArCQkJYnJlYWs7Cj4gKwkvKiBJZiB0aGUgcmF0ZSBpcyBhbiBleGFjdCBtYXRjaCwg cmV0dXJuIGl0IG5vdyAqLwo+ICsJaWYgKHJhdGUgPT0gcGh5X3BsbF9jZmdbaV0ucGl4Y2xrKQo+ ICsJCXJldHVybiBwaHlfcGxsX2NmZ1tpXS5waXhjbGs7Cj4gKwo+ICsJLyoKPiArCSAqIFRoZSBt YXRoIG9uIHRoZSBsb29rdXAgdGFibGUgc2hvd3MgdGhlIFBNUyBtYXRoIHlpZWxkcyBhCj4gKwkg KiBmcmVxdWVuY3kgNSB4IHBpeGNsay4KPiArCSAqIFdoZW4gd2UgY2hlY2sgdGhlIGludGVnZXIg ZGl2aWRlciBhZ2FpbnN0IHRoZSBkZXNpcmVkIHJhdGUsCj4gKwkgKiBtdWx0aXBseSB0aGUgcmF0 ZSB4IDUgYW5kIHRoZW4gZGl2aWRlIHRoZSBvdXRjb21lIGJ5IDUuCj4gKwkgKi8KPiArCWludF9k aXZfY2xrID0gZnNsX3NhbXN1bmdfaGRtaV9waHlfZmluZF9wbXMocmF0ZSAqIDUsICZwLCAmbSwg JnMpIC8gNTsKCkknZCBtb3ZlIHRoYXQgY29tbWVudCBhbmQgYm90aCBtdWx0aXBsaWNhdGlvbiBh bmQgZGl2aXNpb24gaW5zaWRlCmZzbF9zYW1zdW5nX2hkbWlfcGh5X2ZpbmRfcG1zLCBzaW5jZSBp dCdzIGEgcHJvcGVydHkgb2YgdGhlIGNvbXB1dGF0aW9uCihub3QgaGF2aW5nIHRoZSBjb21tZW50 IG1hZGUgbWUgYXNrIGxhc3QgdGltZSwgd2l0aCB0aGUgY29tbWVudCBpdCdzCmZpbmUgLS0gdGhh bmtzIGZvciBhZGRpbmcgdGhlc2UgY29tbWVudHMsIHZlcnkgaGVscGZ1bC4pCgotLSAKRG9taW5p cXVlCgoKCi0tIApsaW51eC1waHkgbWFpbGluZyBsaXN0CmxpbnV4LXBoeUBsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LXBoeQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gw2.atmark-techno.com (gw2.atmark-techno.com [35.74.137.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9DA11531F9 for ; Fri, 30 Aug 2024 05:56:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=35.74.137.57 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724997405; cv=none; b=fx5aX4kdL4eWxYL+9uZ6hjtZrQoJmGEmcdzsv4+4C/4oZOvYhtmlzXpCEfMkDxWHgFzP4ssRWtjPnFfhS54xoHAxZpJTgNGqL9ChGXspM8nHEucGGLlqGtR4kMWTE5spM3HmFIuqS/e17ZRP1sOqqagv1Ne+4vGjpihSQtUbQeo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724997405; c=relaxed/simple; bh=x9yjOjFAohZtscac1sFvxpeu7yLK+GwtoV5bfW1JrOk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PztpyA/az8N6c+zaL8eQPD9EaL1ccQRcl2LNwdhmrakqtpSm6cRlttxPb7fECM061a6+GSC1L74KCCmqQQ6NpRkbWWygF9V8r+CrpCMvu8ekmS88fk5joV3Dy2Itqv4JVs4roN0yPxPGe2NT5iZFzozVy1IGcaxf/H1gbxxXTSk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=atmark-techno.com; spf=pass smtp.mailfrom=atmark-techno.com; dkim=pass (2048-bit key) header.d=atmark-techno.com header.i=@atmark-techno.com header.b=wXcaaVJU; dkim=pass (2048-bit key) header.d=atmark-techno.com header.i=@atmark-techno.com header.b=ETEKpY8Z; arc=none smtp.client-ip=35.74.137.57 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=atmark-techno.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=atmark-techno.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=atmark-techno.com header.i=@atmark-techno.com header.b="wXcaaVJU"; dkim=pass (2048-bit key) header.d=atmark-techno.com header.i=@atmark-techno.com header.b="ETEKpY8Z" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=atmark-techno.com; s=gw2_bookworm; t=1724997397; bh=x9yjOjFAohZtscac1sFvxpeu7yLK+GwtoV5bfW1JrOk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wXcaaVJUCXBWpGxgdT3ZXp3PUtR1mfC92445ncE9J5Hhp60v4Nm+H29gfkbQODNSr 8OdCMlo/ZuLmlYmX9XhILyiP4BCsn94ymbuFdM/wga9/Y10z0StkqDYWvUBN7U7ZMg 2zauCYVfGANlzVyieFXKONS4h6jJPMZ61dlM0Z5v5c+Y5gAegH6T5frUJLy5okLMv/ F/eLMfhT4rMRC9opHOF6i83BsX3xTtmwSlxKtcoFh0yco1zH61yTSflcpxWBN81Hnj wapTx9r43kX/21f+XiK4izKaOHTH8gi4R4Ns/sP0tm4kcno/pmsbkP2kyTtZbyTXHc rhP5mz3FK/INg== Received: from gw2.atmark-techno.com (localhost [127.0.0.1]) by gw2.atmark-techno.com (Postfix) with ESMTP id 5411D7B4 for ; Fri, 30 Aug 2024 14:56:37 +0900 (JST) Authentication-Results: gw2.atmark-techno.com; dkim=pass (2048-bit key; unprotected) header.d=atmark-techno.com header.i=@atmark-techno.com header.a=rsa-sha256 header.s=google header.b=ETEKpY8Z; dkim-atps=neutral Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by gw2.atmark-techno.com (Postfix) with ESMTPS id D0AE275B for ; Fri, 30 Aug 2024 14:56:35 +0900 (JST) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-7143d66b510so1738639b3a.3 for ; Thu, 29 Aug 2024 22:56:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atmark-techno.com; s=google; t=1724997395; x=1725602195; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=mkYZPDGmaBN190bl0HbQlkXjB4c4DMUzWPODIPceod0=; b=ETEKpY8ZjGtoYchD21JPEWfhwq48fGYDBhi4s8DTbn4Dirw81tPytuPFkM0zB5058M tCAzybDa9R3WQiZnE6OVIRrlpsPFILy/YyvJJcjvr99YgwIaoQ2bgKZq6cc8k/km6B68 yQkVI6NYdNuEFXhGM8/vVu+L729ta859jTqI4usCfZh5ARG6jnS+S51dUo8LmL7l17L6 utacPd2PRnEj88EqrqLzbH3UmdoBs0drG7i/Gg7txkEF0PeW1NZcwDD3CcFub/uypQK5 PffR6AvJmLuGDlqql7LEXHo1grLLeOTEC6SE54cVbYLO9pKfUCyuWagDLY8GJDc486f1 P+UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724997395; x=1725602195; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mkYZPDGmaBN190bl0HbQlkXjB4c4DMUzWPODIPceod0=; b=Hs+uz4VLc52yuJOKUCeUaKgavctdHhizAZrv6FE8ixofEAzae02AcNVpxTeELDzCKX tUPxNV9JmIR53RljWFmdFZA5vZpBCBBQDWfpBlO2pJib8QEvuLnwfVefbCUGfhdg747O Uw6GZj+8wFnC0mmTZgJ51VunMoRxORHdwFtdSddftGhG43gORQwx5jX9eynBBg5kC4pM 1QkdRcaGycbW6qajKr6E2bUlCfQdRbxxYaKAx46H4pVQzGkKYtmmrLInpeut9SqCMqci SKmhgE+lj/VVNmn6VU4p8ve1kOF+Y0JSyy/39bqEU30W30vMAbx5roFi0YY8EPYXAdq2 QByQ== X-Forwarded-Encrypted: i=1; AJvYcCXCq9HZK5+1bEn6CirugJ/uKmJkmsYQWgT57BhspE8soBbb6RuF5Q21dmEPnUKVS77xB3RB+FNxpE2SEFw=@vger.kernel.org X-Gm-Message-State: AOJu0Yzf9/vZGjJoS55aHqnf2ouaxzKvzUXASQx6OLREX6BYG+eQ56h5 M0GLHmN7mhjNvbX2z8eBnEsDVvwiKDLdqr1Xm6GpIzYlMnhFmFRoHnWicjsXDny44CHYNfS+BlC Jz6W2Y1i5beorvJ4xevhk2eugOUrKuPi9NzpfVsqBLTQFYr+PUZR0JzbDNP5G9oU= X-Received: by 2002:a05:6a00:234a:b0:714:1fc3:79f7 with SMTP id d2e1a72fcca58-715dfc506a0mr7113315b3a.17.1724997394663; Thu, 29 Aug 2024 22:56:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEospLhuiiaJ+JXW7SbcBkbVDDo2i03cNpb6xUMWtOllEbOfcXeI36XV92dVw14GmctIFDlqw== X-Received: by 2002:a05:6a00:234a:b0:714:1fc3:79f7 with SMTP id d2e1a72fcca58-715dfc506a0mr7113295b3a.17.1724997394145; Thu, 29 Aug 2024 22:56:34 -0700 (PDT) Received: from pc-0182.atmarktech (117.209.187.35.bc.googleusercontent.com. [35.187.209.117]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-715e55a44e4sm2019480b3a.56.2024.08.29.22.56.33 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Aug 2024 22:56:33 -0700 (PDT) Received: from martinet by pc-0182.atmarktech with local (Exim 4.96) (envelope-from ) id 1sjuca-00E9Fv-0o; Fri, 30 Aug 2024 14:56:32 +0900 Date: Fri, 30 Aug 2024 14:56:22 +0900 From: Dominique Martinet To: Adam Ford Cc: linux-phy@lists.infradead.org, linux-imx@nxp.com, festevam@gmail.com, frieder.schrempf@kontron.de, aford@beaconembedded.com, Vinod Koul , Kishon Vijay Abraham I , Marco Felsch , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Lucas Stach , linux-kernel@vger.kernel.org, Makoto Sato Subject: Re: [RFC V3 3/3] phy: freescale: fsl-samsung-hdmi: Support dynamic integer Message-ID: References: <20240830032442.226031-1-aford173@gmail.com> <20240830032442.226031-3-aford173@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240830032442.226031-3-aford173@gmail.com> Adam Ford wrote on Thu, Aug 29, 2024 at 10:24:27PM -0500: > There is currently a look-up table for a variety of resolutions. > Since the phy has the ability to dynamically calculate the values > necessary to use the intger divider which should allow more > resolutions without having to update the look-up-table. > > If the lookup table cannot find an exact match, fall back to the > dynamic calculator of the integer divider. > > Previously, the value of P was hard-coded to 1, this required an > update to the phy_pll_cfg table to add in the extra value into the > table, so if the value of P is calculated to be something else > by the PMS calculator, the calculated_phy_pll_cfg structure > can be used instead without having to keep track of which method > was used. Thank you! I've updated to v3 and we must have missed something fiddling with v1 but our 31.5MHz-only screen turns on with this! Unfortunately among the other odd devices we support, there's one whose native resolution only supports 83.5MHz, and that doesn't come out right with the integer divider (that function returns 83.2MHz, which is 0.4%off) If we force the round/set rate functions to prefer the calculated value and allow that in imx8mp_hdmi_check_clk_rate (dw_hdmi-imx.c) then it also works, so I don't think we actually need to affine the model... Coming back to what Lucas replied to my initial mail HDMI would also a rate mismatch of ±0.5%, so the integer calculator works for all the frequencies we've currently added manually if we fix the check to allow that as well: 32000000: found 32000000 (100.0% match): p 1 / m 80 / s 12 51200000: found 51200000 (100.0% match): p 1 / m 64 / s 6 65000000: found 64800000 (99.6% match): p 1 / m 54 / s 4 71000000: found 70800000 (99.7% match): p 1 / m 59 / s 4 83500000: found 83200000 (99.6% match): p 1 / m 104 / s 6 (only actually tested 51.2 and 83.5 here, we don't have all the hardware available; I'll try to play with normal monitors that support more modes once the patch gets further finalized) So, as far as I'm concerned I'd be happy to move forward with that and will backport this to our tree/remove our kludged values, would "just" need to properly pick the closest value if no exact match instead of always falling back to the table (or just remove the table altogether if we can test a few monitors?) A couple of style nitpicks below > diff --git a/drivers/phy/freescale/phy-fsl-samsung-hdmi.c b/drivers/phy/freescale/phy-fsl-samsung-hdmi.c > index a700a300dc6f..3fab40cde40d 100644 > --- a/drivers/phy/freescale/phy-fsl-samsung-hdmi.c > +++ b/drivers/phy/freescale/phy-fsl-samsung-hdmi.c > @@ -16,6 +16,8 @@ > > #define PHY_REG(reg) (reg * 4) > > +#define REG01_PMS_P_MASK GENMASK(3, 0) > +#define REG03_PMS_S_MASK GENMASK(7, 4) > #define REG12_CK_DIV_MASK GENMASK(5, 4) > #define REG13_TG_CODE_LOW_MASK GENMASK(7, 0) > #define REG14_TOL_MASK GENMASK(7, 4) > @@ -29,281 +31,296 @@ > #define REG34_PLL_LOCK BIT(6) > #define REG34_PHY_CLK_READY BIT(5) > > -#define PHY_PLL_DIV_REGS_NUM 6 > +#ifndef MHZ > +#define MHZ (1000UL * 1000UL) > +#endif > + > +#define PHY_PLL_DIV_REGS_NUM 7 > > struct phy_config { > u32 pixclk; > u8 pll_div_regs[PHY_PLL_DIV_REGS_NUM]; > }; > > +/* > + * The calculated_phy_pll_cfg only handles integer divider for PMS only, > + * meaning the last four entries will be fixed, but the first three will > + * be calculated by the PMS calculator > + */ > +static struct phy_config calculated_phy_pll_cfg = { I'd change cur_cfg from pointer to the struct itself like this (partial patch that probably won't even apply on your branch:) ---- diff --git a/drivers/phy/freescale/phy-fsl-samsung-hdmi.c b/drivers/phy/freescale/phy-fsl-samsung-hdmi.c index 9048cdc760c2..d7124604819c 100644 --- a/drivers/phy/freescale/phy-fsl-samsung-hdmi.c +++ b/drivers/phy/freescale/phy-fsl-samsung-hdmi.c @@ -402,7 +402,7 @@ struct fsl_samsung_hdmi_phy { /* clk provider */ struct clk_hw hw; - const struct phy_config *cur_cfg; + struct phy_config cur_cfg; }; static inline struct fsl_samsung_hdmi_phy * @@ -562,9 +562,9 @@ static int phy_clk_set_rate(struct clk_hw *hw, if (i < 0) return -EINVAL; - phy->cur_cfg = &phy_pll_cfg[i]; + phy->cur_cfg = phy_pll_cfg[i]; - return fsl_samsung_hdmi_phy_configure(phy, phy->cur_cfg); + return fsl_samsung_hdmi_phy_configure(phy, &phy->cur_cfg); } static const struct clk_ops phy_clk_ops = { ---- Then you can just set it directly for calculated values. But conceptually it's the same, just one less indirection. > @@ -406,6 +424,76 @@ fsl_samsung_hdmi_phy_configure_pll_lock_det(struct fsl_samsung_hdmi_phy *phy, > phy->regs + PHY_REG(14)); > } > > +static unsigned long fsl_samsung_hdmi_phy_find_pms(unsigned long fout, u8 *p, u16 *m, u8 *s) > +{ > + unsigned long best_freq = 0; > + u32 min_delta = 0xffffffff; > + u8 _p, best_p; > + u16 _m, best_m; > + u8 _s, best_s; > + > + /* The ref manual states the values of 'P' rannge from 1 to 11 */ typo: range > + for (_p = 1; _p <= 11; ++_p) { > + for (_s = 1; _s <= 16; ++_s) { > + u64 tmp; > + u32 delta; > + > + /* s must be one or even */ > + if (_s > 1 && (_s & 0x01) == 1) > + _s++; > + > + /* _s cannot be 14 per the TRM */ > + if (_s == 14) > + continue; > + > + /* > + * TODO: Ref Manual doesn't state the range of _m > + * so this should be further refined if possible. > + * This range was set based on the original values > + * in the look-up table > + */ > + tmp = (u64)fout * (_p * _s); > + do_div(tmp, 24 * MHZ); > + _m = tmp; > + if (_m < 0x30 || _m > 0x7b) > + continue; > + > + /* > + * Rev 2 of the Ref Manual states the > + * VCO can range between 750MHz and > + * 3GHz. The VCO is assumed to be _m x > + * the reference frequency of 24MHz divided > + * by the prescaler, _p > + */ > + tmp = (u64)_m * 24 * MHZ; > + do_div(tmp, _p); > + if (tmp < 750 * MHZ || > + tmp > 3000 * MHZ) > + continue; > + > + tmp = (u64)_m * 24 * MHZ; > + do_div(tmp, _p * _s); > + > + delta = abs(fout - tmp); > + if (delta < min_delta) { > + best_p = _p; > + best_s = _s; > + best_m = _m; > + min_delta = delta; > + best_freq = tmp; > + } > + } > + } > + > + if (best_freq) { > + *p = best_p; > + *m = best_m; > + *s = best_s; > + } > + > + return best_freq; > +} > + > static int fsl_samsung_hdmi_phy_configure(struct fsl_samsung_hdmi_phy *phy, > const struct phy_config *cfg) > { > @@ -419,13 +507,13 @@ static int fsl_samsung_hdmi_phy_configure(struct fsl_samsung_hdmi_phy *phy, > for (i = 0; i < ARRAY_SIZE(common_phy_cfg); i++) > writeb(common_phy_cfg[i].val, phy->regs + common_phy_cfg[i].reg); > > - /* set individual PLL registers PHY_REG2 ... PHY_REG7 */ > + /* set individual PLL registers PHY_REG1 ... PHY_REG7 */ > for (i = 0; i < PHY_PLL_DIV_REGS_NUM; i++) > - writeb(cfg->pll_div_regs[i], phy->regs + PHY_REG(2) + i * 4); > + writeb(cfg->pll_div_regs[i], phy->regs + PHY_REG(1) + i * 4); > > - /* High nibble of pll_div_regs[1] contains S which also gets written to REG21 */ > + /* High nibble of PHY_REG3 and low nibble of PHY_REG21 both contain 'S' */ > writeb(REG21_SEL_TX_CK_INV | FIELD_PREP(REG21_PMS_S_MASK, > - cfg->pll_div_regs[1] >> 4), phy->regs + PHY_REG(21)); > + cfg->pll_div_regs[2] >> 4), phy->regs + PHY_REG(21)); > > fsl_samsung_hdmi_phy_configure_pll_lock_det(phy, cfg); > > @@ -453,29 +541,70 @@ static unsigned long phy_clk_recalc_rate(struct clk_hw *hw, > static long phy_clk_round_rate(struct clk_hw *hw, > unsigned long rate, unsigned long *parent_rate) > { > + u32 int_div_clk; > int i; > + u16 m; > + u8 p, s; > + > + /* If the clock is out of range return error instead of searching */ > + if (rate > 297000000 || rate < 22250000) > + return -EINVAL; > > + /* Check the look-up table */ > for (i = ARRAY_SIZE(phy_pll_cfg) - 1; i >= 0; i--) > if (phy_pll_cfg[i].pixclk <= rate) > - return phy_pll_cfg[i].pixclk; > + break; > + /* If the rate is an exact match, return it now */ > + if (rate == phy_pll_cfg[i].pixclk) > + return phy_pll_cfg[i].pixclk; > + > + /* > + * The math on the lookup table shows the PMS math yields a > + * frequency 5 x pixclk. > + * When we check the integer divider against the desired rate, > + * multiply the rate x 5 and then divide the outcome by 5. > + */ > + int_div_clk = fsl_samsung_hdmi_phy_find_pms(rate * 5, &p, &m, &s) / 5; I'd move that comment and both multiplication and division inside fsl_samsung_hdmi_phy_find_pms, since it's a property of the computation (not having the comment made me ask last time, with the comment it's fine -- thanks for adding these comments, very helpful.) -- Dominique