Re: [PATCH nft 1/5] cache: assert filter when calling nft_cache_evaluate()

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Thu, Aug 29, 2024 at 10:35:30AM -0400, Eric Garver wrote:
> On Thu, Aug 29, 2024 at 01:31:49PM +0200, Pablo Neira Ayuso wrote:
> > nft_cache_evaluate() always takes a non-null filter, remove superfluous
> > checks when calculating cache requirements via flags.
> > 
> > Note that filter is still option from netlink dump path, since this can
> > be called from error path to provide hints.
> > 
> > Fixes: 08725a9dc14c ("cache: filter out rules by chain")
> > Fixes: b3ed8fd8c9f3 ("cache: missing family in cache filtering")
> > Fixes: 635ee1cad8aa ("cache: filter out sets and maps that are not requested")
> > Fixes: 3f1d3912c3a6 ("cache: filter out tables that are not requested")
> > Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> > ---
> >  src/cache.c | 16 +++++++---------
> >  1 file changed, 7 insertions(+), 9 deletions(-)
> 
> Thanks Pablo.
> 
> For the series:
> 
> Tested-by: Eric Garver <eric@garver.life>

Pushed out, thanks