From: Remi Pommarel <repk@triplefau.lt>
To: Nicolas Escande <nico.escande@gmail.com>
Cc: ath12k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wifi: ath12k: move txbaddr/rxbaddr into struct ath12k_dp
Date: Fri, 30 Aug 2024 18:21:50 +0200 [thread overview]
Message-ID: <ZtHxnk0weaxYUIwZ@pilgrim> (raw)
In-Reply-To: <20240830081942.3623380-1-nico.escande@gmail.com>
Hi Nicolas,
On Fri, Aug 30, 2024 at 10:19:42AM +0200, Nicolas Escande wrote:
> Those two fields are used to store the per SPT page of tx/rx descriptors send to
> the firmware for cookie conversion. Right now they are in struct ath12k_spt_info
> which means they are duplicated PPT page times while we only need one instance
> of them. This works for now as we always use the first spt_info as a global
> storage for all PPT pages.
>
> Let's move them into struct ath12k_dp where they belong, alongside of the
> spt_info array they are tied to, to avoid waisting a good bit of memory.
>
> Tested-on: QCN9274 hw2.0 PCI CI_WLAN.WBE.1.3-03283.1-QCAHKSWPL_SILICONZ-2
>
> Signed-off-by: Nicolas Escande <nico.escande@gmail.com>
Looks good to me. For what it worth:
Reviewed-by: Remi Pommarel <repk@triplefau.lt>
--
Remi
next prev parent reply other threads:[~2024-08-30 16:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 8:19 [PATCH] wifi: ath12k: move txbaddr/rxbaddr into struct ath12k_dp Nicolas Escande
2024-08-30 16:21 ` Remi Pommarel [this message]
2024-08-30 17:01 ` Jeff Johnson
2024-09-28 9:19 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZtHxnk0weaxYUIwZ@pilgrim \
--to=repk@triplefau.lt \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nico.escande@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.