Re: [Buildroot] [PATCH 2/2] board/raspberrypi: Enable nullglob for DTBs

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Fiona, All,

On 2024-06-18 21:40 +0200, Fiona Klute via buildroot spake thusly:
> With "nullglob" the post image script does not fail if there's no DTB
> directly in BINARIES_DIR. This is required when using DTBs from the
> rpi-firmware package (BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS=y),
> because in that case the kernel build doesn't provide one.
> 
> Using pre-compiled DTBs is discouraged, but useful for using mainline
> kernels until suitable DTS can be merged.
> 
> Signed-off-by: Fiona Klute <fiona.klute+wiwa@gmx.de>
> ---
>  board/raspberrypi/post-image.sh | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/board/raspberrypi/post-image.sh b/board/raspberrypi/post-image.sh
> index e4611d05dd..b7ccf5d0b3 100755
> --- a/board/raspberrypi/post-image.sh
> +++ b/board/raspberrypi/post-image.sh
> @@ -1,6 +1,7 @@
>  #!/bin/bash
> 
>  set -e
> +shopt -s nullglob

I'm not too fond of this. Indeed, when reading the glob itself, it is
not obvious what happens when there's no file, as the usual behaviour is
to expand with a single word where the glob character is not replaced.

Instead, I'd use the following:

    for i in "${BINARIES_DIR}"/*.dtb "${BINARIES_DIR}"/rpi-firmware/*; do
        [ -e "${i}" ] || continue
        FILES+=( "${i#${BINARIES_DIR}/}" )
    done

Regards,
Yann E. MORIN.

>  BOARD_DIR="$(dirname $0)"
>  BOARD_NAME="$(basename ${BOARD_DIR})"
> --
> 2.45.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot