From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v1 0/5] pinctrl: intel: High impedance impl. and cleanups
Date: Fri, 30 Aug 2024 21:51:45 +0300 [thread overview]
Message-ID: <ZtIUwWavMQRXDOGN@smile.fi.intel.com> (raw)
In-Reply-To: <974bbb25-3b27-4f53-be35-4bfda17b8c7e@gmail.com>
On Fri, Aug 30, 2024 at 07:56:11AM +0200, Heiner Kallweit wrote:
> On 28.08.2024 22:00, Andy Shevchenko wrote:
> > On Wed, Aug 28, 2024 at 09:38:33PM +0300, Andy Shevchenko wrote:
> >> We would need a high impedance implementation for a quirk, so here it
> >> is. While doing this series I also noticed a couple of opportunities
> >> to clean up, hence two more patches (1st and 5th).
> >
> > Sorry it took a while to actually start implementing the quirk for your case.
> > Here I'm asking for the following things:
> >
> > 1) what is the marketing name of the device you have problems with?
> > (I believe it's available on the free market, correct?);
>
> Device is a dirt-cheap mini pc, marketed as Chatreey T9. It's available
> on the free market, right. Dmesg says:
> DMI: Default string Default string/Default string, BIOS ADLN.M6.SODIMM.ZB.CY.015 08/08/2023
>
> > 2) does it have any BIOS updates and, if it has, does it fix the issue?
> >
> No BIOS updates.
>
> > 3) can you apply patches 2,3,4,5 from this series (the first one is buggy and
> > not needed for you) and replace the hack I mentioned earlier with
> >
> > ret = intel_gpio_set_high_impedance(pctrl, 3);
> > if (ret)
> > return ret;
> >
> > somewhere at the end of intel_pinctrl_probe()?
> >
> > Does it still work as expected?
> >
> I will check.
There is a v2 to test, you can take entire series, or for-next branch of Intel
pin control tree
https://git.kernel.org/pub/scm/linux/kernel/git/pinctrl/intel.git/log/?h=for-next
Thanks!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-08-30 18:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 18:38 [PATCH v1 0/5] pinctrl: intel: High impedance impl. and cleanups Andy Shevchenko
2024-08-28 18:38 ` [PATCH v1 1/5] pinctrl: intel: Move debounce validation out of the lock Andy Shevchenko
2024-08-28 19:21 ` Andy Shevchenko
2024-08-28 18:38 ` [PATCH v1 2/5] pinctrl: intel: Refactor __intel_gpio_set_direction() to be more useful Andy Shevchenko
2024-08-28 18:38 ` [PATCH v1 3/5] pinctrl: intel: Add __intel_gpio_get_direction() helper Andy Shevchenko
2024-08-29 4:46 ` Mika Westerberg
2024-08-29 10:49 ` Andy Shevchenko
2024-08-29 10:50 ` Andy Shevchenko
2024-08-28 18:38 ` [PATCH v1 4/5] pinctrl: intel: Implement high impedance support Andy Shevchenko
2024-08-29 4:48 ` Mika Westerberg
2024-08-29 10:53 ` Andy Shevchenko
2024-08-28 18:38 ` [PATCH v1 5/5] pinctrl: intel: Introduce for_each_intel_gpio_group() helper Andy Shevchenko
2024-08-29 4:53 ` Mika Westerberg
2024-08-29 5:34 ` Andy Shevchenko
2024-08-28 20:00 ` [PATCH v1 0/5] pinctrl: intel: High impedance impl. and cleanups Andy Shevchenko
2024-08-30 5:56 ` Heiner Kallweit
2024-08-30 18:51 ` Andy Shevchenko [this message]
2024-08-30 21:24 ` Heiner Kallweit
2024-09-02 10:46 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZtIUwWavMQRXDOGN@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hkallweit1@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.