From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DB861BD00B for ; Fri, 30 Aug 2024 22:33:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725057197; cv=none; b=ALpVM6SQkDDu2TFO5KKIEK934LXgAU4H5jwm8Bm0MWl9JCAsRLz9DrzyTzxUv7RxQsVQ88lK8cKz75Sv08Bf9jiy6nbuZRSW8oO+/ZVwRHZfroRA7FeVY2e/phe3o3m5999/dPMbgCAwNGFj9gbK8GOX6vy8wRchOCxMGlYE7cA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725057197; c=relaxed/simple; bh=DqAVqqLfjpgjASo+CIfe1feDonNcG4Odo1DBuX7wdR4=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JtNioYAIq93MLfbJdVjID2gaoUwLa98lcCsOm8a9PrVc+1Av2jGPp5rZSskkSVEQZkyK0/A3iCAK45W/m1iTYM515DnrmavX61PA/qekZ678//s/dE5kmF5v5yR3cnuuBYSgA/jXjFUZulPBGkUaHPCXWBZmKdv+gQvaE5sYHeg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Dp1v7+aW; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Dp1v7+aW" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a8682bb5e79so289270566b.2 for ; Fri, 30 Aug 2024 15:33:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1725057194; x=1725661994; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=oK95C0BSC1jzK2D55nrE90clLVhwEM+Y9bSdjRWpEd8=; b=Dp1v7+aWJz+A4cKaT17oli44/yP7f2EW22bHOILyblolzuTJO8ufFE9h6WAZImPwqB FvIP6MkS4VBTdglAlZrkkemaTnAP17V9CI7Akrcz6QU3vjSzMSyKleqKcmbnO9iwcdxH Qn/8Z6lagO/ez613Qk6hVmWoA3v/ETIgM4LbGNi9D4AGRabXoIsWYqWAV+onnKHYgcp1 I55prglG9jD1jTFlh0ezT84sinyOk6ck64uOBbuXon4UejFLuYgRWMu7IAYy7EnTlKMF 7BMHrMYhVM4xX+7bC3jEsBzlLskQRblwFvT0haTOTx2nwEi6YuL7AmptvwKLlBeKkwiA P+Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725057194; x=1725661994; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oK95C0BSC1jzK2D55nrE90clLVhwEM+Y9bSdjRWpEd8=; b=tXcRb8ydhvMZ8CV3IuLdnu4KC5ygPefX3xNsnDMY7P7XaGEr8ZGHHP8Sf2NwVlf/zi 9+OLZDisrWpyEACztqu2rb3o07iCZt8Rl76jx2PuGRbd8VbMP0y0edkS2gmNm6bVl9vl avqQrG9BtHa7kNdQwwGXlMc6/QbB7Um7nfprQtcb0ww91xHVKkPxwIhdt2Kq7bnVoPTl mKfQe4ZE9iinb1EysKKMOfhO+P/QYXMB7pTB+uXekM8lQtIVOfY4Nu39PfQTgJGr88/a zFblySEvWcT8XzWrcAukMq8mJlpFfTIgOoNi5rVx66hfmNHQH+Wc6YLbsZBpfa20pOyW Bk8w== X-Forwarded-Encrypted: i=1; AJvYcCU4KIGs4L45K+nX3tJd9tbW1kJBqIPxbrOnmHrI2g1zxLJqnVj0RzvgD9jGv2oAMuCONPH2sZsEURz9@vger.kernel.org X-Gm-Message-State: AOJu0YyaWMUNQbK6XHCcpze/N6+QlM7zP0ymFiQSoBf4p9PGXn9ukaNv MnsX6rhlmxN3fLct3jNqkZhbUJxTshU1NrXWHNerazVEk67pSsPAifTX+Znq3C0= X-Google-Smtp-Source: AGHT+IHqkz6MDPFM4AoearcdXDKhXOMUBNtVV9Zz1IeP9NcojNkgXiXqwILRRdgqIEEC3J1YsUnnqQ== X-Received: by 2002:a17:907:2da2:b0:a7a:a5ae:11b7 with SMTP id a640c23a62f3a-a897fa63905mr698523966b.49.1725057193226; Fri, 30 Aug 2024 15:33:13 -0700 (PDT) Received: from localhost (host-80-182-198-72.pool80182.interbusiness.it. [80.182.198.72]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8989195e8csm260291966b.105.2024.08.30.15.33.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Aug 2024 15:33:12 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Sat, 31 Aug 2024 00:33:19 +0200 To: Krzysztof Kozlowski Cc: Andrea della Porta , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Linus Walleij , Catalin Marinas , Will Deacon , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Nicolas Ferre , Claudiu Beznea , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Saravana Kannan , Bjorn Helgaas , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-arch@vger.kernel.org, Lee Jones , Andrew Lunn , Stefan Wahren Subject: Re: [PATCH 11/11] arm64: dts: rp1: Add support for MACB contained in RP1 Message-ID: References: Precedence: bulk X-Mailing-List: linux-arch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Krzysztof, On 10:43 Wed 21 Aug , Krzysztof Kozlowski wrote: > On Tue, Aug 20, 2024 at 04:36:13PM +0200, Andrea della Porta wrote: > > RaspberryPi RP1 is multi function PCI endpoint device that > > exposes several subperipherals via PCI BAR. > > Add an ethernet node for Cadence MACB to the RP1 dtso > > > > Signed-off-by: Andrea della Porta > > --- > > arch/arm64/boot/dts/broadcom/rp1.dtso | 23 +++++++++++++++++++++++ > > 1 file changed, 23 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/broadcom/rp1.dtso b/arch/arm64/boot/dts/broadcom/rp1.dtso > > index d80178a278ee..b40e203c28d5 100644 > > --- a/arch/arm64/boot/dts/broadcom/rp1.dtso > > +++ b/arch/arm64/boot/dts/broadcom/rp1.dtso > > @@ -78,6 +78,29 @@ rp1_clocks: clocks@c040018000 { > > <50000000>; // RP1_CLK_ETH_TSU > > }; > > > > + rp1_eth: ethernet@c040100000 { > > + reg = <0xc0 0x40100000 0x0 0x4000>; > > + compatible = "cdns,macb"; > > Please start using DTS coding style... Ack. Regards, Andrea > > Best regards, > Krzysztof > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0C1FCA101B for ; Fri, 30 Aug 2024 22:40:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:Date:From:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oK95C0BSC1jzK2D55nrE90clLVhwEM+Y9bSdjRWpEd8=; b=34WkFjyEHCeXZ3qzuwysyDZ/Y5 Iao2RwqCKTTsgl743a1AnhUGejifHfGdDLXvQMtUrPwAu+S3Et/ZcUq6MpKnYsv1n35pL3O3LioO1 EOp9GbpmZX50IBOkKYO874IWEk0SDdX+vuMEOfeCCS9mXe2Y6HK+1zyBBISZU7NhvqSzyIiXanVHw A4CnY2m+e2cWGjg4/m6RfftJkm1fgr0oK2m0eeroS3woVuB2HahyUZ9Y3drCLr6ywLlD0GxOHGSvF KIoCmNf9kYd3ByPbpPHyNDYFutK+/WUlvWt4fwjwYKCNvIy0WhjfZ2rkLnkLAjFysTjXpGHzyqdlG 696N7C6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1skAHn-00000007vnk-1nRu; Fri, 30 Aug 2024 22:40:07 +0000 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1skAB9-00000007uDa-2d8c for linux-arm-kernel@lists.infradead.org; Fri, 30 Aug 2024 22:33:17 +0000 Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-a8682bb5e79so289270666b.2 for ; Fri, 30 Aug 2024 15:33:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1725057194; x=1725661994; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=oK95C0BSC1jzK2D55nrE90clLVhwEM+Y9bSdjRWpEd8=; b=S0tJxzKxjIMufVrnpAiudJA50UGFePAtNVonYtTZ8yyDnwWTJRZvZ9L6cbYlhMXIq4 s39/DH/OjI+hySsJTY2aSpEeAXNcORTtPcLMYzD6kME78I4FUfx3TL5mkrdqpL6toHmJ Jcz2bGqA8jS9iVYnltkMK/8ZsWsX+YHmxn6lOW+AR5TWMUhjFntiLu4Ls40Hw9LEgdHG sc7gt3awiWLuByZ5ayoqYvBovCEhXnHTYgFY9CV7jY9qjy1uu+xSuvPKb2lvtxaz6zG3 ky9LdWfxZ9m6J5q5vPsj28ma3odPPQ95PzVcDthAvcSnmA5yYfv+xyf3OO4nna/UtQJ7 8+xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725057194; x=1725661994; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oK95C0BSC1jzK2D55nrE90clLVhwEM+Y9bSdjRWpEd8=; b=vKjINS1KFlzhLX+q3RffPb7frn21ovJ5Pf+jil1cODrnSUkFnUthalm/0wt0yanj8b fvdxRm+/v4Mie1dBbONYChFzfr8nj5uzvKTlCvEuv30vbHj47MPBIK5vG1E/C3ELNNg6 7txwSf0WORZ9MEY5w3NYF0trlaF1kuVrn0yUnORiPUFNKTdyiOH+iCThsWfi1MVG66dn 2IfPjqv63aETLiMO1DsGwdHhNN7E6pK2sq+aIrZKYhf8uNRhJ2gFvEV9uYSZZ1g81V+s BjDF7rWXXC1IQuZoy4V8jLrZZ+Pefts3HvMpmWOWSTcU2fSyX2cVpsgTMvwicFpF/tBv inIQ== X-Forwarded-Encrypted: i=1; AJvYcCUIuK7U+7Lt9kZEpFmJIyBZ7Y7n7bRMy8XDfxaIYAUQIY7ZciV3haeE8zp6OqOLSuKfJdZG7vN3hKWQsyDhW+VI@lists.infradead.org X-Gm-Message-State: AOJu0YwBc/TqcR4kLjxDZcyWHIvAHzcx7wedN58smnyZ9SVyOsAdnKw0 ftDd/6H3gU5p12646Q5Lc6XFoMNaQeImVkkMLB/+E70/aanxkNXBCLIRicCHksc= X-Google-Smtp-Source: AGHT+IHqkz6MDPFM4AoearcdXDKhXOMUBNtVV9Zz1IeP9NcojNkgXiXqwILRRdgqIEEC3J1YsUnnqQ== X-Received: by 2002:a17:907:2da2:b0:a7a:a5ae:11b7 with SMTP id a640c23a62f3a-a897fa63905mr698523966b.49.1725057193226; Fri, 30 Aug 2024 15:33:13 -0700 (PDT) Received: from localhost (host-80-182-198-72.pool80182.interbusiness.it. [80.182.198.72]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8989195e8csm260291966b.105.2024.08.30.15.33.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Aug 2024 15:33:12 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Sat, 31 Aug 2024 00:33:19 +0200 To: Krzysztof Kozlowski Subject: Re: [PATCH 11/11] arm64: dts: rp1: Add support for MACB contained in RP1 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240830_153315_691965_FE899BA0 X-CRM114-Status: GOOD ( 18.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Catalin Marinas , Michael Turquette , Claudiu Beznea , Eric Dumazet , Dragan Cvetic , Will Deacon , linux-clk@vger.kernel.org, linux-arch@vger.kernel.org, Rob Herring , Florian Fainelli , Lee Jones , Saravana Kannan , Broadcom internal kernel review list , linux-pci@vger.kernel.org, Jakub Kicinski , Paolo Abeni , Linus Walleij , devicetree@vger.kernel.org, Conor Dooley , Arnd Bergmann , linux-gpio@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Bjorn Helgaas , Andrea della Porta , linux-arm-kernel@lists.infradead.org, Derek Kiernan , Stephen Boyd , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Stefan Wahren , netdev@vger.kernel.org, Krzysztof Kozlowski , "David S. Miller" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, On 10:43 Wed 21 Aug , Krzysztof Kozlowski wrote: > On Tue, Aug 20, 2024 at 04:36:13PM +0200, Andrea della Porta wrote: > > RaspberryPi RP1 is multi function PCI endpoint device that > > exposes several subperipherals via PCI BAR. > > Add an ethernet node for Cadence MACB to the RP1 dtso > > > > Signed-off-by: Andrea della Porta > > --- > > arch/arm64/boot/dts/broadcom/rp1.dtso | 23 +++++++++++++++++++++++ > > 1 file changed, 23 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/broadcom/rp1.dtso b/arch/arm64/boot/dts/broadcom/rp1.dtso > > index d80178a278ee..b40e203c28d5 100644 > > --- a/arch/arm64/boot/dts/broadcom/rp1.dtso > > +++ b/arch/arm64/boot/dts/broadcom/rp1.dtso > > @@ -78,6 +78,29 @@ rp1_clocks: clocks@c040018000 { > > <50000000>; // RP1_CLK_ETH_TSU > > }; > > > > + rp1_eth: ethernet@c040100000 { > > + reg = <0xc0 0x40100000 0x0 0x4000>; > > + compatible = "cdns,macb"; > > Please start using DTS coding style... Ack. Regards, Andrea > > Best regards, > Krzysztof >