Re: [LTP] [PATCH v2 1/1] isofs.sh: Use nobody user

[Wei Gao via ltp <ltp@lists.linux.it>]

On Mon, Sep 02, 2024 at 09:16:15AM +0200, Petr Vorel wrote:
> Hi Wei,
> 
> > > +TEST_USER='nobody'
> > > +
> > > +setup()
> > > +{
> > > +	TEST_GROUP="$(id -g -n $TEST_USER)"
> > > +	[ "$TEST_GROUP" ] || TEST_GROUP="$TEST_USER"
> > If $TEST_GROUP can not be found then this case will failed unless we create new group.
> > My suggestion is remove above line totally or we start create group for nobody user.
> 
> That check is a fallback if 'id' is not installed but there is requested
> nobody:nobody or nobody/nogroup group set by IDcheck.sh or manually.
Thanks for your explaination. Then no question from my side.

Acked-by: Wei Gao <wegao@suse.com>

> 
> But sure, I can delete it if we expect id to be installed. I just did not want
> to require 'id' for this test when there can be a workaround.
> 
> Kind regards,
> Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp