From: Andy Shevchenko <andy@kernel.org>
To: "Marek Behún" <kabel@kernel.org>
Cc: "Lee Jones" <lee@kernel.org>, "Pavel Machek" <pavel@ucw.cz>,
linux-leds@vger.kernel.org, "Arnd Bergmann" <arnd@arndb.de>,
soc@kernel.org, "Gregory CLEMENT" <gregory.clement@bootlin.com>,
arm@kernel.org, "Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH leds 1/8] turris-omnia-mcu-interface.h: Move command execution function to global header
Date: Mon, 2 Sep 2024 15:55:30 +0300 [thread overview]
Message-ID: <ZtW1wuUCvQQSPBH2@smile.fi.intel.com> (raw)
In-Reply-To: <20240902124104.14297-2-kabel@kernel.org>
On Mon, Sep 02, 2024 at 02:40:57PM +0200, Marek Behún wrote:
> Move the command execution functions from the turris-omnia-mcu platform
> driver private header to the global turris-omnia-mcu-interface.h header,
> so that they can be used by the LED driver.
...
> #include <linux/bitfield.h>
> +#include <linux/bitops.h>
> #include <linux/bits.h>
You may drop this one now, as guaranteed by bitops.h.
> +#include <linux/types.h>
> +#include <asm/byteorder.h>
> +#include <asm/unaligned.h>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-09-02 12:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 12:40 [PATCH leds 0/8] Turris Omnia LED driver changes Marek Behún
2024-09-02 12:40 ` [PATCH leds 1/8] turris-omnia-mcu-interface.h: Move command execution function to global header Marek Behún
2024-09-02 12:55 ` Andy Shevchenko [this message]
2024-09-02 12:59 ` Marek Behún
2024-09-02 13:23 ` Andy Shevchenko
2024-09-02 12:40 ` [PATCH leds 2/8] leds: turris-omnia: Use command execution functions from the MCU driver Marek Behún
2024-09-02 12:40 ` [PATCH leds 3/8] turris-omnia-mcu-interface.h: Add LED commands related definitions to global header Marek Behún
2024-09-02 12:41 ` [PATCH leds 4/8] leds: turris-omnia: Use global header for MCU command definitions Marek Behún
2024-09-02 12:41 ` [PATCH leds 5/8] leds: turris-omnia: Notify sysfs on MCU global LEDs brightness change Marek Behún
2024-09-02 13:17 ` Andy Shevchenko
2024-09-02 14:36 ` Marek Behún
2024-09-02 12:41 ` [PATCH leds 6/8] platform: cznic: turris-omnia-mcu: Inform about missing LED panel brightness change interrupt feature Marek Behún
2024-09-02 12:41 ` [PATCH leds 7/8] leds: turris-omnia: Inform about missing LED gamma correction feature in the MCU driver Marek Behún
2024-09-02 12:41 ` [PATCH leds 8/8] ARM: dts: turris-omnia: Add global LED brightness change interrupt Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZtW1wuUCvQQSPBH2@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=andrew@lunn.ch \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=gregory.clement@bootlin.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kabel@kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=sebastian.hesselbarth@gmail.com \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.