From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:504:3a8f:b0:1be9:327d:8ee3 with SMTP id g15csp1076259njf; Mon, 2 Sep 2024 05:08:13 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCV21xMprg4Rb3oE9dG5wrle/Mxo+jS0wcVB1Z1XlFdFZV1ORWRUpV5Jj0ifmFycGQf1JGV0VEO//AafkQ==@linaro.org X-Google-Smtp-Source: AGHT+IEGFuS82O+Jwv20jyWkAuZBg6+8blhVSzgUjhCBNpz2BtENiQKivL2h+yIPDVOKZpee2a7o X-Received: by 2002:a05:6830:6f04:b0:704:46da:5fa0 with SMTP id 46e09a7af769-70f710104dfmr8544721a34.10.1725278893009; Mon, 02 Sep 2024 05:08:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1725278892; cv=none; d=google.com; s=arc-20160816; b=o52d6lqSp/u6aBkzfzxgHErRNjcSeU353QgR+cjLpPrODu+WAtPaAKENUVes8FPLiG QGRkCuRZaBHH/Rji2pKjuev67NME8GXKDhqI1ip8W+5qjkUOWjWLACqKm3jtv97M4ifj 6GUtzj3/PMTKMgrc1urUzR7uWn9ubpXD314sWobDulSJ+VYKtt+ppcC595Ex7lHPbY/0 tPTCv2WKxBMIBj1xq7dGTffOXOM/Mtv4F4hnNgNvvVBIxewGdmm/q7GHkmVlQH03JF61 CQ3ThGYJSuFDF0+DnvoC/rUF15qzQThLPISB0rRJrAiTrZOhUF3K2uZ/6nsyKBkNUKzv ImmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=dkQxYeFZK8yzOwfSeCZ18iVu4+ksZbGRP7U47oaewW0=; fh=lu+wOHEYZO1oZq4R0p5rj+pV6gbzqyjP6WYQYAObjOk=; b=XwbQLj2tTUYN2O53GOfiC4VDnyIK2pcuXIygSbaG8tfdW/pX6Wr9W3CHP4zHQEZt/g NWvBlBrru/BCH56sLdxnV9C8ZOlrnlrpEhY5QKYOwIkb7e8YwbYs1q1q1ZuUk7PNZSVv RV1ddK8KvfWOyIRl9xXc3251fJLXXhL6Fm/J9U1d8SoXcCivEv7/F+KhuDFOSc3TlDvx tfPan2TYOTrgK4cqnAkhgzsmXAhDFQAWMPZq4vnSrsizhPADpGMQ3iLY1TXx+b7L7Iem TASQMLEfqIMlHmrb9lrMbVi9HMnZYb7slCeKrvE7S4XdW17wbUyE2DZtLpKiRHaCxiNw iMiQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=hENLyiwl; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 71dfb90a1353d-5007163e9b4si1944255e0c.175.2024.09.02.05.08.12 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 02 Sep 2024 05:08:12 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=hENLyiwl; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sl5qg-0003VP-ED; Mon, 02 Sep 2024 08:07:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sl5qe-0003UQ-NG; Mon, 02 Sep 2024 08:07:56 -0400 Received: from mgamail.intel.com ([198.175.65.10]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sl5qc-0005Lc-As; Mon, 02 Sep 2024 08:07:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725278874; x=1756814874; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=qgr1sU7wkJHclCHETFO8vyp0MlBwWnW+iyMOkHg9Fkk=; b=hENLyiwlK904calFsce5LwbM7Ubc8iepw7GriLluG3Wzd4OYxv6USiBr zU8pCew5pINv0c08AjkXxl+AaG/VMe7OEadNXfRhZucaTCgupMS/573Fd XPVLxz6q4HS7GDrzulbTsodGYc7vgBvNJk4NQ9Zgmy4TofdFcUIX8wQrx vJ0P7n+lKl024OAH0iaqrblJPlYjZ3cj+7D9ZlbtJtNDAGuph9SkP8o15 HTGYMub/6SB0bLefi6LvCqpgZuMnoNNaMUrSWzXrFTQvaeKeYJX/9DrcX zQKQx9KWy34RfTuJbQTMC9rGoDk8mqN6Bz0id/nMgIb9l1WyzK7+9PWLC Q==; X-CSE-ConnectionGUID: 07UTZtAOTzeFJ7hroD6INA== X-CSE-MsgGUID: h/cuJ6LbRsWbYAjJBdfAGA== X-IronPort-AV: E=McAfee;i="6700,10204,11182"; a="41333119" X-IronPort-AV: E=Sophos;i="6.10,195,1719903600"; d="scan'208";a="41333119" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2024 05:07:49 -0700 X-CSE-ConnectionGUID: XhA4ac0RSvugfTevNzWVkQ== X-CSE-MsgGUID: O8z3vyWmQb2M+INS6gcYvA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,195,1719903600"; d="scan'208";a="95405433" Received: from liuzhao-optiplex-7080.sh.intel.com (HELO localhost) ([10.239.160.36]) by fmviesa001.fm.intel.com with ESMTP; 02 Sep 2024 05:07:44 -0700 Date: Mon, 2 Sep 2024 20:23:43 +0800 From: Zhao Liu To: Alireza Sanaee Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, zhenyu.z.wang@intel.com, dapeng1.mi@linux.intel.com, yongwei.ma@intel.com, armbru@redhat.com, farman@linux.ibm.com, peter.maydell@linaro.org, mst@redhat.com, anisinha@redhat.com, shannon.zhaosl@gmail.com, imammedo@redhat.com, mtosatti@redhat.com, berrange@redhat.com, richard.henderson@linaro.org, linuxarm@huwei.com, shameerali.kolothum.thodi@huawei.com, Jonathan.Cameron@huawei.com, jiangkunkun@huawei.com, zhao1.liu@intel.com Subject: Re: [RFC PATCH 0/2] Specifying cache topology on ARM Message-ID: References: <20240823125446.721-1-alireza.sanaee@huawei.com> <20240902112519.00005b67@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240902112519.00005b67@huawei.com> Received-SPF: pass client-ip=198.175.65.10; envelope-from=zhao1.liu@intel.com; helo=mgamail.intel.com X-Spam_score_int: -44 X-Spam_score: -4.5 X-Spam_bar: ---- X-Spam_report: (-4.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.142, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: TRwbAfOcsiEy On Mon, Sep 02, 2024 at 11:25:19AM +0100, Alireza Sanaee wrote: > > Hi Zhao, > > Yes, please keep me CCed. > > One thing that I noticed, sometimes, since you were going down the > Intel path, some variables couldn't be NULL. But when I was gonna go > down to ARM path, I faced some scenarios where I ended up with > some uninit vars which is still OK but could have been avoided. Ah I didn't get your point very clearly. Could you please figure out those places on my patches? Then I can fix them in my next version. :) Thanks, Zhao > Looking forward to the next revision. > > Alireza