Re: [PATCH v2 00/11] perftool-testsuite 2nd batch

[Arnaldo Carvalho de Melo <acme@kernel.org>]

On Mon, Sep 02, 2024 at 11:31:36AM -0300, Arnaldo Carvalho de Melo wrote:
> On Mon, Sep 02, 2024 at 04:05:04PM +0200, Veronika Molnarova wrote:
> > On 8/30/24 17:27, Arnaldo Carvalho de Melo wrote:
> > > On Wed, Aug 28, 2024 at 05:39:48PM -0300, Arnaldo Carvalho de Melo wrote:
> > >> On Wed, Aug 28, 2024 at 04:10:55PM +0200, Veronika Molnarova wrote:
> > > So, is there some other knob to get further output from that FAIL case?
> > > Like the command that is failing? I'll try to take a look at the
> > > sources, but are you seeing this problem with what is in
> > > perf-tools-next/perf-tools-next?

> > Couldn't reproduce the issue on multiple systems. There is no further way
> > of getting more logs from the test case. The output of the failure is from
> > the regex checking when a line wasn't matched to any possible regex.
> > Looking at the test case "adding blacklisted function warn_thunk_thunk",
> > the failure is caused by command 'perf probe warn_thunk_thunk', which is
> > a blacklisted function taken from "/sys/kernel/debug/kprobes/blacklist".

root@x1:~# grep thunk_thunk /sys/kernel/debug/kprobes/blacklist
0xffffffff97004af0-0xffffffff97004b20	warn_thunk_thunk
root@x1:~#

<SNIP>

> /tmp/perftool-testsuite_probe.RJh/perf_probe/logs/adding_blacklisted.err:A function DIE doesn't have decl_line. Maybe broken DWARF?
> root@x1:~# cat /tmp/perftool-testsuite_probe.RJh/perf_probe/logs/adding_blacklisted.err
> A function DIE doesn't have decl_line. Maybe broken DWARF?
> A function DIE doesn't have decl_line. Maybe broken DWARF?
> Probe point 'warn_thunk_thunk' not found.
>   Error: Failed to add events.
> root@x1:~#
> root@x1:~# cat /tmp/perftool-testsuite_probe.RJh/perf_probe/logs/adding_blacklisted_list.log 
> root@x1:~# cat /tmp/perftool-testsuite_probe.RJh/perf_probe/logs/adding_blacklisted.log 
> root@x1:~#
> 
> So is it just a matter of adding this output to the expected outputs?
> In test_adding_blacklisted.sh?

Did the patch below, now it passes, Ack?

root@x1:~# export PERFTEST_KEEP_LOGS=y
root@x1:~# perf test 88
 88: perftool-testsuite_probe                                        : Ok
root@x1:~#

Or am I missing the point? :-)

- Arnaldo

diff --git a/tools/perf/tests/shell/base_probe/test_adding_blacklisted.sh b/tools/perf/tests/shell/base_probe/test_adding_blacklisted.sh
index b5dc10b2a73810b3..14290d08a4a96eaf 100755
--- a/tools/perf/tests/shell/base_probe/test_adding_blacklisted.sh
+++ b/tools/perf/tests/shell/base_probe/test_adding_blacklisted.sh
@@ -42,7 +42,8 @@ REGEX_ERROR_MESSAGE="Error: Failed to add events."
 REGEX_INVALID_ARGUMENT="Failed to write event: Invalid argument"
 REGEX_SYMBOL_FAIL="Failed to find symbol at $RE_ADDRESS"
 REGEX_OUT_SECTION="$BLACKFUNC is out of \.\w+, skip it"
-../common/check_all_lines_matched.pl "$REGEX_SKIP_MESSAGE" "$REGEX_NOT_FOUND_MESSAGE" "$REGEX_ERROR_MESSAGE" "$REGEX_SCOPE_FAIL" "$REGEX_INVALID_ARGUMENT" "$REGEX_SYMBOL_FAIL" "$REGEX_OUT_SECTION" < $LOGS_DIR/adding_blacklisted.err
+REGEX_MISSING_DECL_LINE="A function DIE doesn't have decl_line. Maybe broken DWARF?"
+../common/check_all_lines_matched.pl "$REGEX_SKIP_MESSAGE" "$REGEX_NOT_FOUND_MESSAGE" "$REGEX_ERROR_MESSAGE" "$REGEX_SCOPE_FAIL" "$REGEX_INVALID_ARGUMENT" "$REGEX_SYMBOL_FAIL" "$REGEX_OUT_SECTION" "$REGEX_MISSING_DECL_LINE" < $LOGS_DIR/adding_blacklisted.err
 CHECK_EXIT_CODE=$?
 
 print_results $PERF_EXIT_CODE $CHECK_EXIT_CODE "adding blacklisted function $BLACKFUNC"