From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CA351A3A80; Mon, 2 Sep 2024 18:56:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725303400; cv=none; b=hlAyLpgUmpGj8aOHX5TsbMRFOLQF30E67bzT51UzRWIgXXaSVnV3xb3AhRBs02+EEDR1kFQHl6TDJOqmmNKFnR3xSpfE05rDJQhR4wOVcUDx2PNwFvrFNst3ddE1rigfG7IaOvTflV6x6MRXmjjtw/6h0SFF06x1TdfXO8IXx9M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725303400; c=relaxed/simple; bh=NRDn5F0DYc0xh9o5b7nz1eHKTPrCCQwBGTOb9SaDzDM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Cuyt1VQ12SaT0v0/gh/F/h+Q3s6XNiuUl/j8k8TT/rRKhg+RvSrpzu9JsB0IJjvmObSkMFEjSoMy8i0ARXZp1jpCiQ4DyBrFnPartLm03JGDT9KwHj8BOzZ2OyXl5RFKQSXZdUQVmOPXW6XdI9EQv5RlWfdToRSX+l1OVUsMHzA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63A22C4CECB; Mon, 2 Sep 2024 18:56:34 +0000 (UTC) Date: Mon, 2 Sep 2024 19:56:32 +0100 From: Catalin Marinas To: Mark Brown Cc: Will Deacon , Jonathan Corbet , Andrew Morton , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Arnd Bergmann , Oleg Nesterov , Eric Biederman , Shuah Khan , "Rick P. Edgecombe" , Deepak Gupta , Ard Biesheuvel , Szabolcs Nagy , Kees Cook , "H.J. Lu" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Florian Weimer , Christian Brauner , Thiago Jung Bauermann , Ross Burton , Yury Khrustalev , Wilco Dijkstra , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v12 26/39] arm64/ptrace: Expose GCS via ptrace and core files Message-ID: References: <20240829-arm64-gcs-v12-0-42fec947436a@kernel.org> <20240829-arm64-gcs-v12-26-42fec947436a@kernel.org> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240829-arm64-gcs-v12-26-42fec947436a@kernel.org> On Thu, Aug 29, 2024 at 12:27:42AM +0100, Mark Brown wrote: > +static int gcs_get(struct task_struct *target, > + const struct user_regset *regset, > + struct membuf to) > +{ > + struct user_gcs user_gcs; > + > + if (target == current) > + gcs_preserve_current_state(); What's the use-case where target == current and do we need something similar for gcs_set()? -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1B169CD13CF for ; Mon, 2 Sep 2024 18:57:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1aDQwzLNbjbiliLgkHpLUxMPN/aNhxxAzhOthIZi30Q=; b=pASupuTbcMpF+A Nxhg1oEmywZ7J4OTWcCdSLhUAS48YrV93fB388JnAAlF/xoFWuQy7a+Nant4u8lwLPy/yuvXHgFS9 W+YhVG+YiMnjBr7z7U3OE4zjtE9bBZ4mMpV8lQrBd5GlFIhBr6TecwlTsRxBd1B3hHv3qkERgIE1O geFw5DUvSkCkf6lB46PSKnGCarVd6FS0f41QeP9z9CDshjwtbQFaGLSl0+LA3Z+B2ddaEDU2ilT/2 MFwkxKkFMTDG4RNAchMabp9bMbEjXgbGcjZjk+7ltj7HKefaTa8YdW/EMrYktjSKwYOVhO7ehB42j jtfwGZK6hWd+Zn2zylLQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1slCF9-0000000FKs4-14HN; Mon, 02 Sep 2024 18:57:39 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1slCED-0000000FKdm-21UY; Mon, 02 Sep 2024 18:56:42 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 70878A431B5; Mon, 2 Sep 2024 18:56:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63A22C4CECB; Mon, 2 Sep 2024 18:56:34 +0000 (UTC) Date: Mon, 2 Sep 2024 19:56:32 +0100 From: Catalin Marinas To: Mark Brown Cc: Will Deacon , Jonathan Corbet , Andrew Morton , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Arnd Bergmann , Oleg Nesterov , Eric Biederman , Shuah Khan , "Rick P. Edgecombe" , Deepak Gupta , Ard Biesheuvel , Szabolcs Nagy , Kees Cook , "H.J. Lu" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Florian Weimer , Christian Brauner , Thiago Jung Bauermann , Ross Burton , Yury Khrustalev , Wilco Dijkstra , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v12 26/39] arm64/ptrace: Expose GCS via ptrace and core files Message-ID: References: <20240829-arm64-gcs-v12-0-42fec947436a@kernel.org> <20240829-arm64-gcs-v12-26-42fec947436a@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240829-arm64-gcs-v12-26-42fec947436a@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240902_115641_601480_A0A17BCA X-CRM114-Status: UNSURE ( 9.63 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, Aug 29, 2024 at 12:27:42AM +0100, Mark Brown wrote: > +static int gcs_get(struct task_struct *target, > + const struct user_regset *regset, > + struct membuf to) > +{ > + struct user_gcs user_gcs; > + > + if (target == current) > + gcs_preserve_current_state(); What's the use-case where target == current and do we need something similar for gcs_set()? -- Catalin _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv