From: Anthony PERARD <anthony.perard@vates.tech>
To: Jan Beulich <jbeulich@suse.com>
Cc: Oleksii Kurochko <oleksii.kurochko@gmail.com>,
Community Manager <community.manager@xenproject.org>,
xen-devel@lists.xenproject.org
Subject: Re: [XEN PATCH] CHANGELOG: Update after fixing dm_restrict
Date: Tue, 03 Sep 2024 10:04:07 +0000 [thread overview]
Message-ID: <ZtbfFlXZVfiMA8Zg@l14> (raw)
In-Reply-To: <d4ed5e07-c938-4d38-a49c-5c451c0c3a89@suse.com>
On Tue, Sep 03, 2024 at 11:20:37AM +0200, Jan Beulich wrote:
> On 03.09.2024 10:54, Anthony PERARD wrote:
> > --- a/CHANGELOG.md
> > +++ b/CHANGELOG.md
> > @@ -16,6 +16,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
> > - On x86:
> > - Support for running on Xeon Phi processors.
> >
> > +### Fixed
> > + - Fixed xl/libxl dm\_restrict feature with QEMU 9.0.
> > +
> > +
> > ## [4.19.0](https://xenbits.xenproject.org/gitweb/?p=xen.git;a=shortlog;h=RELEASE-4.19.0) - 2024-07-29
> >
> > ### Changed
>
> We had no "### Fixed" so far, and I think we also shouldn't gain any. Imo
> this wants expressing in term of "### Changed", also wording the text
> accordingly (needing to adapt to qemu changes isn't a bug fix, strictly
> speaking, but more an enhancement in my view).
From our CHANGELOG.md:
> The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
following the link, there is:
> Types of changes
>
> - `Added` for new features.
> - `Changed` for changes in existing functionality.
> - `Deprecated` for soon-to-be removed features.
> - `Removed` for now removed features.
> - `Fixed` for any bug fixes.
> - `Security` in case of vulnerabilities.
So, are we not following keepachangelog.com format? Is there another
document/email/discussion describing which category are allowed?
Been compatible with newer version of dependencies doesn't feels like an
existing functionality have changed. It feels more like a fix to the bug
"can't start guest with newer QEMU".
Thanks,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
next prev parent reply other threads:[~2024-09-03 10:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 8:54 [XEN PATCH] CHANGELOG: Update after fixing dm_restrict Anthony PERARD
2024-09-03 9:20 ` Jan Beulich
2024-09-03 10:04 ` Anthony PERARD [this message]
2024-09-03 14:03 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZtbfFlXZVfiMA8Zg@l14 \
--to=anthony.perard@vates.tech \
--cc=community.manager@xenproject.org \
--cc=jbeulich@suse.com \
--cc=oleksii.kurochko@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.