From: Guillaume Nault <gnault@redhat.com>
To: Ido Schimmel <idosch@nvidia.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
edumazet@google.com, pabeni@redhat.com, dsahern@kernel.org
Subject: Re: [PATCH net-next 1/4] ipv4: Unmask upper DSCP bits in __ip_queue_xmit()
Date: Tue, 3 Sep 2024 17:52:47 +0200 [thread overview]
Message-ID: <Ztcwz14WPh4Q9hpZ@debian> (raw)
In-Reply-To: <20240903135327.2810535-2-idosch@nvidia.com>
On Tue, Sep 03, 2024 at 04:53:24PM +0300, Ido Schimmel wrote:
> The function is passed the full DS field in its 'tos' argument by its
> two callers. It then masks the upper DSCP bits using RT_TOS() when
> passing it to ip_route_output_ports().
>
> Unmask the upper DSCP bits when passing 'tos' to ip_route_output_ports()
> so that in the future it could perform the FIB lookup according to the
> full DSCP value.
Reviewed-by: Guillaume Nault <gnault@redhat.com>
next prev parent reply other threads:[~2024-09-03 15:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 13:53 [PATCH net-next 0/4] Unmask upper DSCP bits - part 3 Ido Schimmel
2024-09-03 13:53 ` [PATCH net-next 1/4] ipv4: Unmask upper DSCP bits in __ip_queue_xmit() Ido Schimmel
2024-09-03 15:52 ` Guillaume Nault [this message]
2024-09-03 13:53 ` [PATCH net-next 2/4] ipv4: ipmr: Unmask upper DSCP bits in ipmr_queue_xmit() Ido Schimmel
2024-09-03 15:54 ` Guillaume Nault
2024-09-03 13:53 ` [PATCH net-next 3/4] ip6_tunnel: Unmask upper DSCP bits in ip4ip6_err() Ido Schimmel
2024-09-03 15:59 ` Guillaume Nault
2024-09-03 13:53 ` [PATCH net-next 4/4] ipv6: sit: Unmask upper DSCP bits in ipip6_tunnel_bind_dev() Ido Schimmel
2024-09-03 16:02 ` Guillaume Nault
2024-09-03 14:45 ` [PATCH net-next 0/4] Unmask upper DSCP bits - part 3 David Ahern
2024-09-05 0:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ztcwz14WPh4Q9hpZ@debian \
--to=gnault@redhat.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.