All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: "J. Neuschäfer" <j.neuschaefer@gmx.net>
Cc: James Hilliard <james.hilliard1@gmail.com>,
	Grzegorz Blach <grzegorz@blach.pl>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Asaf Kahlon <asafka7@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 2/3] package/python-rgbmatrix: new package
Date: Tue, 3 Sep 2024 23:44:49 +0200	[thread overview]
Message-ID: <ZteDUZoQYrmvwS8A@landeda> (raw)
In-Reply-To: <20240901-rgbmatrix-v2-2-3a10c3c367e4@gmx.net>

J., All,

On 2024-09-01 16:29 +0200, J. Neuschäfer via buildroot spake thusly:
> The "rgbmatrix" python module is the Python binding for
> rpi-rgb-led-matrix, built from the same source repository.
> 
> Signed-off-by: J. Neuschäfer <j.neuschaefer@gmx.net>

I did a few changes:

  - add comment for propagated dependencies
  - add comment on missing dependencies
  - drop comment at end of _VERSION line

Applied to next, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/Config.in                                |  1 +
>  package/python-rgbmatrix/Config.in               |  8 ++++++++
>  package/python-rgbmatrix/python-rgbmatrix.hash   |  3 +++
>  package/python-rgbmatrix/python-rgbmatrix.mk     | 24 ++++++++++++++++++++++++
>  package/rpi-rgb-led-matrix/rpi-rgb-led-matrix.mk |  1 +
>  5 files changed, 37 insertions(+)
> 
> diff --git a/package/Config.in b/package/Config.in
> index 07bd1499d8..b3665a7569 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1343,6 +1343,7 @@ menu "External python modules"
>  	source "package/python-requests-oauthlib/Config.in"
>  	source "package/python-requests-toolbelt/Config.in"
>  	source "package/python-rfc3987/Config.in"
> +	source "package/python-rgbmatrix/Config.in"
>  	source "package/python-rpds-py/Config.in"
>  	source "package/python-rpi-gpio/Config.in"
>  	source "package/python-rpi-ws281x/Config.in"
> diff --git a/package/python-rgbmatrix/Config.in b/package/python-rgbmatrix/Config.in
> new file mode 100644
> index 0000000000..3b39bd500c
> --- /dev/null
> +++ b/package/python-rgbmatrix/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_PYTHON_RGBMATRIX
> +	bool "python-rgbmatrix"
> +	depends on BR2_aarch64 || BR2_arm
> +	depends on BR2_INSTALL_LIBSTDCPP
> +	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	depends on !BR2_STATIC_LIBS
> +	select BR2_PACKAGE_HOST_PYTHON_CYTHON
> +	select BR2_PACKAGE_RPI_RGB_LED_MATRIX
> diff --git a/package/python-rgbmatrix/python-rgbmatrix.hash b/package/python-rgbmatrix/python-rgbmatrix.hash
> new file mode 100644
> index 0000000000..175081eb5d
> --- /dev/null
> +++ b/package/python-rgbmatrix/python-rgbmatrix.hash
> @@ -0,0 +1,3 @@
> +# Locally computed
> +sha256  9a6da5b0ad730883a5fa18afc59b1297b4b05eb581c2c14ae50a3583296a4bed  python-rgbmatrix-f55736f7595bc028451658996eedea9742688bbc.tar.gz
> +sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
> diff --git a/package/python-rgbmatrix/python-rgbmatrix.mk b/package/python-rgbmatrix/python-rgbmatrix.mk
> new file mode 100644
> index 0000000000..2bd5bc97b7
> --- /dev/null
> +++ b/package/python-rgbmatrix/python-rgbmatrix.mk
> @@ -0,0 +1,24 @@
> +################################################################################
> +#
> +# python-rgbmatrix
> +#
> +################################################################################
> +
> +# When updating the version, please also update rpi-rgb-led-matrix
> +PYTHON_RGBMATRIX_VERSION = f55736f7595bc028451658996eedea9742688bbc  # 2024-08-18
> +PYTHON_RGBMATRIX_SITE = $(call github,hzeller,rpi-rgb-led-matrix,$(PYTHON_RGBMATRIX_VERSION))
> +PYTHON_RGBMATRIX_LICENSE = GPL-2.0
> +PYTHON_RGBMATRIX_LICENSE_FILES = COPYING
> +PYTHON_RGBMATRIX_INSTALL_STAGING = YES
> +PYTHON_RGBMATRIX_SETUP_TYPE = setuptools
> +PYTHON_RGBMATRIX_SUBDIR = bindings/python
> +PYTHON_RGBMATRIX_DEPENDENCIES = host-python-cython rpi-rgb-led-matrix
> +
> +# Generate bindings with cython
> +define PYTHON_RGBMATRIX_CYTHON
> +	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D)/bindings/python/rgbmatrix \
> +		CYTHON=$(HOST_DIR)/bin/cython all
> +endef
> +PYTHON_RGBMATRIX_PRE_BUILD_HOOKS += PYTHON_RGBMATRIX_CYTHON
> +
> +$(eval $(python-package))
> diff --git a/package/rpi-rgb-led-matrix/rpi-rgb-led-matrix.mk b/package/rpi-rgb-led-matrix/rpi-rgb-led-matrix.mk
> index 53408996a3..235927fa1c 100644
> --- a/package/rpi-rgb-led-matrix/rpi-rgb-led-matrix.mk
> +++ b/package/rpi-rgb-led-matrix/rpi-rgb-led-matrix.mk
> @@ -4,6 +4,7 @@
>  #
>  ################################################################################
> 
> +# When updating the version, please also update python-rgbmatrix
>  RPI_RGB_LED_MATRIX_VERSION = f55736f7595bc028451658996eedea9742688bbc  # 2024-08-18
>  RPI_RGB_LED_MATRIX_SITE = $(call github,hzeller,rpi-rgb-led-matrix,$(RPI_RGB_LED_MATRIX_VERSION))
>  RPI_RGB_LED_MATRIX_LICENSE = GPL-2.0
> 
> --
> 2.45.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-09-03 21:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-01 14:29 [Buildroot] [PATCH v2 0/3] Version bump and python bindings for rpi-rgb-led-matrix J. Neuschäfer via buildroot
2024-09-01 14:29 ` [Buildroot] [PATCH v2 1/3] package/rpi-rgb-led-matrix: update to latest commit J. Neuschäfer via buildroot
2024-09-03 21:43   ` Yann E. MORIN
2024-09-01 14:29 ` [Buildroot] [PATCH v2 2/3] package/python-rgbmatrix: new package J. Neuschäfer via buildroot
2024-09-03 21:44   ` Yann E. MORIN [this message]
2024-09-04 12:04     ` J. Neuschäfer via buildroot
2024-09-01 14:29 ` [Buildroot] [PATCH v2 3/3] DEVELOPERS: add J. Neuschäfer for rpi-rgb-led-matrix/python-rgbmatrix J. Neuschäfer via buildroot
2024-09-03 21:45   ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZteDUZoQYrmvwS8A@landeda \
    --to=yann.morin.1998@free.fr \
    --cc=asafka7@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=grzegorz@blach.pl \
    --cc=j.neuschaefer@gmx.net \
    --cc=james.hilliard1@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.