From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 270EB4317B for ; Wed, 4 Sep 2024 02:57:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725418663; cv=none; b=EmM42wgv0V9ZBRzLZzqReMvi6qBFtYQXy4MfIxGd1DgbiBCBrWU6bZu4sO3aNy22jRNlcUo4/eH6pILXQ7ZHPrTIgkOCr5/LXGP6+IpkkUnojJyY+XzgXpP9FOLDKWEvDSiem0223gecqeAPSFlizDynr1Uwb/KaRVOi+q/nrCM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725418663; c=relaxed/simple; bh=foqF30mnXx1GcKY7zbYXFFy3NBR51yPMKQzsrC74LuE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZIwT//K8cVUdqfgL2F0orixjNXoqWZbB3UkP1E/N7WouMwIiUmk1rEroTVv/yA9WdlSRaxDzor/69/QwQxtHDFpyn0JfkKVrH8bMA//fExrRCO7hdS34K7WYKxa9+5F6Q94BeEIsCtkmLGk5DZeYo8IC5itvK4+XXgiA1fq1nag= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=E/CqsaLe; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="E/CqsaLe" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725418661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iZg1+Cu2DLlxPh/lu/2PGq1H6RdumTvMLcval/dS4I4=; b=E/CqsaLetxTDwswiPp44GE4edFIMjwz9QHontQuvaTCFB5gA+vGLr6UALyv765Inzk2jts 2yZFDwRgxUYR+gnlwfaA+jwrmrKiIE2Oszaed0tTKHIe59jHRe12vBHbLsvoouQl4YeW43 wKjDTIMopAPflZDCe4B9OSaQHRmzoQ4= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-574-PAA9kXFiOxaza9zn4QhoQg-1; Tue, 03 Sep 2024 22:57:38 -0400 X-MC-Unique: PAA9kXFiOxaza9zn4QhoQg-1 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D5D2E1955BEE; Wed, 4 Sep 2024 02:57:35 +0000 (UTC) Received: from fedora (unknown [10.72.116.130]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 147E330001A4; Wed, 4 Sep 2024 02:57:28 +0000 (UTC) Date: Wed, 4 Sep 2024 10:57:23 +0800 From: Ming Lei To: Mikulas Patocka Cc: Jens Axboe , Jinyoung Choi , Christoph Hellwig , "Martin K. Petersen" , Alasdair Kergon , Mike Snitzer , linux-block@vger.kernel.org, dm-devel@lists.linux.dev, ming.lei@redhat.com Subject: Re: [PATCH] bio-integrity: don't restrict the size of integrity metadata Message-ID: References: Precedence: bulk X-Mailing-List: dm-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 On Tue, Sep 03, 2024 at 09:47:59PM +0200, Mikulas Patocka wrote: > Hi Jens > > I added dm-integrity inline mode in the 6.11 merge window. I've found out > that it doesn't work with large bios - the reason is that the function > bio_integrity_add_page refuses to add more metadata than > queue_max_hw_sectors(q). This restriction is no longer needed, because > big bios are split automatically. I'd like to ask you if you could send > this commit to Linus before 6.11 comes out, so that the bug is fixed > before the final release. > > Mikulas > > > From: Mikulas Patocka > > bio_integrity_add_page restricts the size of the integrity metadata to > queue_max_hw_sectors(q). This restriction is not needed because oversized > bios are split automatically. This restriction causes problems with > dm-integrity 'inline' mode - if we send a large bio to dm-integrity and > the bio's metadata are larger than queue_max_hw_sectors(q), > bio_integrity_add_page fails and the bio is ended with BLK_STS_RESOURCE > error. > > An example that triggers it: > > # modprobe brd rd_size=1048576 > # dmsetup create in1 --table '0 1847320 integrity /dev/ram0 0 64 D 1 fix_padding' > # dmsetup create in2 --table '0 1847312 integrity /dev/mapper/in1 0 64 I 1 internal_hash:sha512' > # dd if=/dev/zero of=/dev/mapper/in2 bs=1M oflag=direct status=progress > dd: error writing '/dev/mapper/in2': Cannot allocate memory > 1+0 records in > 0+0 records out > 0 bytes copied, 0.00169291 s, 0.0 kB/s > > Signed-off-by: Mikulas Patocka > Fixes: fb0987682c62 ("dm-integrity: introduce the Inline mode") > Fixes: 0ece1d649b6d ("bio-integrity: create multi-page bvecs in bio_integrity_add_page()") Firstly meta size is always < bio size. Secondly the check isn't needed either bio_integrity_add_page() is called on to-be-splited bio(DM), or splited bio(blk-mq). Reviewed-by: Ming Lei Thanks, Ming