From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5DBD286A8 for ; Wed, 4 Sep 2024 15:38:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.32 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725464339; cv=fail; b=H33WH6REgDROWqkjjIKjGRTZNUxcIdqUSWWHOJym16vEKK6x47O0VZm6OCxucg/o1yOLc/g6JzSbbXhZjFSY2xmpbqbRl1Xb2oRcZMBL57MmG7GpozPN/DLJXJRziZ3JlO31yWhaFWk8RaY+9fZsB7tgqorBonuVePrpDuWG+Hc= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725464339; c=relaxed/simple; bh=sFLO0tgxr07zFh79P6g0qWWeNVPUZKQnuFKuA137F44=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=V6tCuVDg8eCDp4KuDJHZgfC8rDUEwFBlBaDwdvrkK9haXKwAZbjPv1rvgDxIj/eA+lr1pvEO6k4Fm7eB8nyOR+tP7rYo1NetoFOr7q0MuDYmYOtgzUnRUgZF/cKYiWUpRS2yniPZO2gedupNUBN0/Jz8nwzucOlsVsHgeSPzmZE= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=VsyQPJjc; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=Sul3EYU6; arc=fail smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="VsyQPJjc"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="Sul3EYU6" Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 484DXS2T013228; Wed, 4 Sep 2024 15:38:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= date:from:to:cc:subject:message-id:references:content-type :in-reply-to:mime-version; s=corp-2023-11-20; bh=GzTuI0uq+L4XSAw ADZlwoHST9yUyB5PlfHTjDodsk1A=; b=VsyQPJjcK9OH995irBNwIf6g6nZr1WH /0BUU4GCrQESxb6AD5AFV5YBhMqWeXxV/lLDhluCvS6QaC7WWnId0ERkN6t9Zqsv X9Ab6nr8WLneYPNPxoI+Uri48Ndde8H/03YhBnqUaVxvloQF+GhyMnZAFmW47edq YkdNf8PAC1mf6FVzd2aW+HyuM4G30HrjVPkLLSoCriSQlGpIuLzjVblnFICLkLap JoCg6k9Z5obpWm9O5dei2Z9M/RT4Ch5PmjM8FslDvYGrumN47InyK/QiBY5bKzN9 hds8OhlGNKQBzVxM2y5zgpSrabbHiXx13uAuwouuLm3fk2o8MgkV64w== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 41dwndkqwh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Sep 2024 15:38:56 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 484FJp8t018334; Wed, 4 Sep 2024 15:38:54 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2049.outbound.protection.outlook.com [104.47.66.49]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 41bsmg9v31-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Sep 2024 15:38:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mNlyxGQ71C5rq6M54T5qcLSy6BB5TbtHo29S1oNBU7GhNBpRxhqf1/9GIsKqRAYsaHWTr5FGCr1Mh9+GHTUhxbNpI1vE0IYM0gPVUR0xBuygOtXcoeEWOgfc8UQ7/9opoRgBIjdlnEvRdpnmK6+4Fu2kFA7tMGs7qSngspOv2sydB/U0HDcDe1yCvt0sqYZ3sCzzmYor8Gp6pIZjweWj3BH3alidfcRjs600JAMh4Htmcg07NBxskviFDIPEsbd2SkUdeu1HGRJQ/7+y3kjWfjL+SmcThmWgDLVWk5FTM1ytlnNm9DbQ8+6FxADk4IqeAp1jQtLoakDlBOaJNoyoZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GzTuI0uq+L4XSAwADZlwoHST9yUyB5PlfHTjDodsk1A=; b=u95ARudTIf6/QPnybir1zQaUNhtRA87U66QuSN7bpp6OIGHg2N+dnHmh4EWDVmW4KWOSGVtellxFEUjde5PipvNaDl8RiwdH+a1F9OHCRg6W4a8YYg3krGoxuregiKYBIPZKxRZs/4pn+TRGj614lIaqwTlD7frxwzD6mrLmn9RsJSewT9ptfcyPlpEB+heXhbX4jlyloE6R09ptQiLkd2Gv6aDeT3Oi9XmhcSLV3kdY3NaSNfrxVeWH8QBdpiywdpPzUx+wLrh0xdLzF8/qlpW9byixC3pLwyoh9wTEyx/crBq25tCI2EUWMNg+I25EjoKktcNsA7/ZiyTBk9xZBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GzTuI0uq+L4XSAwADZlwoHST9yUyB5PlfHTjDodsk1A=; b=Sul3EYU66EmKyDs80QV4RtFnweFnNeOOyeG/gIQFi62Lq+5F5chaeEHPK2D2jAfk3Mn2/qHByT6wTi/QDP3a3r3jBSbIYww5jz160y9riORF6KS7SGcgE1TZD9pXHGvrXvJUBTjY3k1GIZZFTfcb80x+h4drvwc0jEePMpJhTrA= Received: from BN0PR10MB5128.namprd10.prod.outlook.com (2603:10b6:408:117::24) by DM4PR10MB6014.namprd10.prod.outlook.com (2603:10b6:8:ad::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.24; Wed, 4 Sep 2024 15:38:50 +0000 Received: from BN0PR10MB5128.namprd10.prod.outlook.com ([fe80::743a:3154:40da:cf90]) by BN0PR10MB5128.namprd10.prod.outlook.com ([fe80::743a:3154:40da:cf90%6]) with mapi id 15.20.7939.010; Wed, 4 Sep 2024 15:38:48 +0000 Date: Wed, 4 Sep 2024 11:38:45 -0400 From: Chuck Lever To: Scott Mayhew Cc: kdevops@lists.linux.dev Subject: Re: [PATCH 2/2] gitr: Make gitr work on RHEL/CentOS Message-ID: References: <20240903144847.355326-1-smayhew@redhat.com> <20240903144847.355326-2-smayhew@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240903144847.355326-2-smayhew@redhat.com> X-ClientProxiedBy: CH2PR07CA0048.namprd07.prod.outlook.com (2603:10b6:610:5b::22) To BN0PR10MB5128.namprd10.prod.outlook.com (2603:10b6:408:117::24) Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN0PR10MB5128:EE_|DM4PR10MB6014:EE_ X-MS-Office365-Filtering-Correlation-Id: b5550f7b-cf12-47e1-26b3-08dcccf7ab91 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?nuNVTeFn8X5Efe4W8qHi+OqOoN7zwZd/oHMFKG9qND3muCXhStUAEWu8y1tD?= =?us-ascii?Q?Aqoj0sef82dF2Qnr8P0AYNMZiWQOlPrsBRErUWJ7dZkqTdBjkrx6t+FzT4+e?= =?us-ascii?Q?aUTDQndbTrFaw99ZLOTC7PwaPiDpuopyPti0mvG1+SnhrmvbZlVK0aGPfdUJ?= =?us-ascii?Q?nlOZAZwnngQEW31+G/KcZKKZ05JCGnFV6V++TLc7N/XN0x7EDURbv/8OH21o?= =?us-ascii?Q?/NFfxWDT2kFXLP4M0UUPpYUmrG20brvaf+PRNxgwKdUFW/rwoOWAQoYbt5p4?= =?us-ascii?Q?7sC9XoKzBKOO6I2XF0bSFTpmx3T/RZ+0sUrV5HPfEeYI0bdb8cxf/um9cL5p?= =?us-ascii?Q?kcL5YQUr7HOzs234nhB88oVGptR/Chhr/vUblHgXBZ0ZKR3MsTTdruke9MoP?= =?us-ascii?Q?GpybiN4jsc4Of8HkOJ24/c4KNWqsmPGiXDgzdrGBtlcXzHae5VnkaZANyuQU?= =?us-ascii?Q?Bbek+a0skqP2ueeykRhEdHhtQ7PkJiFL8HNmbAKfNFV9+8rLG2LkkZ56traK?= =?us-ascii?Q?5ILxVLsTDSmnHGLidgw3f49hXJllOvdm7UBkF0PCeJT3C6GkieN7odAxpcOG?= =?us-ascii?Q?5huB/bq70KrdvLrZ3CcyVWVUKJ0oPm7H73H9kI9DyPRYezKqjX4dtb/8qG4q?= =?us-ascii?Q?OY3Mc+T+6L2kohjr+0xzegHhUxbZwR7iCLlk7j5edCG2VUk5hJu13C2wUNJj?= =?us-ascii?Q?5DHwj5lymvvluft3XSW2m7A7wUJnKzp/DQE/VGVqe9UYAqCFwUw5YtE5TOaa?= =?us-ascii?Q?sr9kZIGRwrj5FWFI3afX6V/4TUhRnjuT3lc8SSRCMbNeaANJELT/VCO8G8Dl?= =?us-ascii?Q?MJcv+XjSJSxnyGtlBwYxZRhe0pkCTJqTr9YtAhLzCgOdeqLMxQ0RTUAo0w3i?= =?us-ascii?Q?17Xlga3GbSfbD/0EXPBz2puh7XJK+ol7JdFWK+RIpR/CmUwcH+OhJX26mVic?= =?us-ascii?Q?YPFZPyoJESLbyFnnxoeBpVScfatyU+mkSs78QSixz0lRjfB4XaffQQZ3j3yX?= =?us-ascii?Q?VzvQM7pEGAu/oHUaiD5BJQIE/4qFZrMF0P24F1FjIOD+8YoYGtIKvImG8mJi?= =?us-ascii?Q?PVYQ3I+qpX7oaueJHN0fbEsJiS4qyFXpzdvCQO0mqYt7D8r4z/3oJa/H2QSD?= =?us-ascii?Q?4fb7+yJNG6dvv8hg2+FRdUZKfd4XEk+30d0aVRh7zutF/sO46269HB+8gJaZ?= =?us-ascii?Q?4E9y/fh6gEsCTTU1zRecmfQAKmWZ2oTjMLWIXWFTcl0CDEU6jqY4FAa3uDSa?= =?us-ascii?Q?k6X9G/dh6C1FWWGjRhc2p1Xgh22BwR7vHi4EqFaVz6y63ut5bwlUJ0Vq0pKo?= =?us-ascii?Q?rRePihnTQGbd111Vqk3KLpvouqcflfacNOWxgNsJa5ymbg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN0PR10MB5128.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BVPLPvkAu3ibUvAhgtwJ3ZXmFUKINphPV5UJhqQKU3ygvFht/i9z6b83tBmx?= =?us-ascii?Q?l1RhJB0m+iJVHDBWnAzKj/UCqZVGdaaRdK3H0kFfKDhxOG3XART1JrQKdNQB?= =?us-ascii?Q?IfRxpKYEOVzxxep8GYyGOtt+EHZsL1NO2sz2Ts98eFtPtwApXO4wBRK7jUBH?= =?us-ascii?Q?QrOJ4MbV4inuvnK8hUAw9Q/JzE9QhtNJUzM0+8l3V6YRszyMJ1ALc8wxe4Bw?= =?us-ascii?Q?bIXxJQd82zOZlp5/l+Hamt2ykdhpOCtxXfLo0WF3TE0zoAqjLWCeXF9wFHh7?= =?us-ascii?Q?8SCuUwbbsOum80I5v29u05WzzoXpbvejyuqchotO9Q+pjJer7rQCF/Iu+fkb?= =?us-ascii?Q?5dlVTPH/fKbedRVk9O/IWAFAgdus57nsmaaZJWbpAlpfvTkUwGiNV0CEghhF?= =?us-ascii?Q?uyttohItKSF1ahwJ7yMDI0cLeTnU4NCBTLELGw4CkuMj1ORB7hGZces9q5Gl?= =?us-ascii?Q?vbURxHVwwXFgT/pL/sE1Qgifg24FOfGiZZP6XlHa+EmslQaOM8k2voNPR2Da?= =?us-ascii?Q?1mtIFQ8jwLARMxhip9HP4FpmuONpebTJp0H088y4xCfByAvm4JW2A2rRi0uQ?= =?us-ascii?Q?mB0Dlx9S/4JqjAjB1GriPDk42s3vcrJCrEC+mm6ToIgY6hLM1MRgZ7og7xe0?= =?us-ascii?Q?LtDxs+4rTkyCKL00gXiIHndVeezQMMQkWz7+FU0P4naEMSb5Fwgy11pVCkUL?= =?us-ascii?Q?x0pwJWz/hCzQZ9xLoa7zN0pecmbX8Qkk8hdd60ft8Epgtv6S2I+P02NCjMQ3?= =?us-ascii?Q?i6ISANZk1pmOIKPplbq/62uVvYAduRlCrpXKLm/XPRJyY6YJqib5ckImGUhl?= =?us-ascii?Q?t8imD4zvDrmkkgBtOo2WpOtVNQpdRgR/gC7YUZYOjgkpnANGmeywWxlia4YN?= =?us-ascii?Q?l8pNkvGUHM0O5kMkmdWjUbctlfZGAxS7eu5Qqf4Kpuli8eJP6oKO5r1rLhjS?= =?us-ascii?Q?2+yslt7EHZF5W/xHttxChuS9lnOYnAavYTAa8o6Xa7l5PvVrxgxkXBHHvQOB?= =?us-ascii?Q?MMxJWcQyiCC776ROKXyQzj4qKzhFIcrkq0NLdJqM2dw9nMdtSwl9h24GrmU3?= =?us-ascii?Q?YsyxiS2k1ovlPmUL9nKn215u02HPRR2fXNumlRZQH+CwjJD0oWJpzeNnCe6P?= =?us-ascii?Q?zZMxJ9senitccE3DneOW6Bs1C3rfYQQBfaMFAD90BeM2Mnc3Nf7ZC2l3hO0G?= =?us-ascii?Q?AiiNdj6UFTaDaJM7AZOOUUGxcumUa5b9lNXu7A3l5UHNVh2ndgXeZOejkjFj?= =?us-ascii?Q?xAZz4tzkvmJeeRFc6o4Tqj0TT0XiFaNKma0EEn86vgU3semtBYxpMh4hjl3Y?= =?us-ascii?Q?6k0Wo05EylTKN+mTmsxcvV513ollB9WtPql6Vx5iLUdXOGej4C7jIgCADqT0?= =?us-ascii?Q?4A+Uf90TvCxLiQGCHuT0TJhQmPpcmYzJMbXdWyLtRGslZSgg1GfwbZ483Te1?= =?us-ascii?Q?AsRDzMfr0gPaLwlceKrNJL0eeCSvCsq50Ga/NhSe5VNsWM7WuRip2Oy3fucM?= =?us-ascii?Q?NZdNiZEkgs7xUQPedi/pBZJolvvaUC+bx9DCnBIMrRO+9R+dkb/Q1bYLWdGK?= =?us-ascii?Q?1NKaweVhm8/qMnFIp7P5m9GyWrehllKNdivxHkhPX2eAyhb6WvRDDxj11OKZ?= =?us-ascii?Q?cA=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 2uhN7UpK5p1c2L0+Dk3Zg9iZDsRGduEbIx5WgEjYCWll+1QHLW6qFpnBFFJHAFMB3zH/DO6z3+8o11OWyCOp2J3o5HkjRedud3VpSPy+oVNLka2uhXUVa+LjEbpLGarsG/3ydX1f++E8p/sg987PbH3WaJ9PWa4i6Vf10K0EwB2C+cHGZk9P6Os9ZTcwTji1l1Q7k8jhbKAWxC5rTpY28E9oZCFCRhKO3BdF3qiZIqfRBwdI4Pjxa4+FdDzwHCAIwpvDcqcR/iY3EQrBo6NJQfdchXtwl8wdNiUu3A9XqtkigbfI18d2zDpjtWkRXbjDAhoYnEV2aWb/LcXoFGJtbVvT0Tgs04EWk7pNfjwmDaz5MPyzfuxjTsG6xaEnUqYXYkF/XBrnTlNlS1mDzVH7sFstx4dRsHa9/05Dk0ml8Amqkflj8Y1R0dZJzFCiscVmomLKc7Wr6iUk/DlzhfQUkUY3q/FwibF2MSdzrvbyxEUxaNrek63KPD/b4KNpf7SyuMpRXuavbwKWhhGgrEVmh6GjGjw9uhpECVuBjbNWPKHe9lLy5RGQ3ypnd+oAenUN/tG/XiTL1ybuOdpQy82saJMeFnQiyaHa5dhZc1Qspng= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5550f7b-cf12-47e1-26b3-08dcccf7ab91 X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Sep 2024 15:38:48.8713 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LmUxe3nTm15zENoBbbwgY9qPchqFBgmfj4wbmpUkQLqh8SUeHuSBQ5/QuJlZjmOqiaGzDHJiniT0n8XoAflwKg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6014 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-04_13,2024-09-04_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 mlxscore=0 mlxlogscore=999 suspectscore=0 malwarescore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2407110000 definitions=main-2409040119 X-Proofpoint-GUID: J8PWBcZIrcVul44D1M454r6g2GrRF8-W X-Proofpoint-ORIG-GUID: J8PWBcZIrcVul44D1M454r6g2GrRF8-W On Tue, Sep 03, 2024 at 10:48:47AM -0400, Scott Mayhew wrote: > RHEL and CentOS do not ship cvsps or perl-TAP-Harness-Archive. For the > former, we'll have to build it from git. For the latter, we can install > it from CPAN, but we'll also have to install the perl-App-cpanminus > package to do so. > > Also add 'make' and 'tar' to the dependencies list. These were > previously getting installed inadvertently by the "Install btrfs-progs" > task in playbooks/roles/devconfig/tasks/install-deps/redhat/main.yml, > which was installing more than just btrfs-progs. > > Signed-off-by: Scott Mayhew > --- > playbooks/roles/gitr/defaults/main.yml | 3 ++ > playbooks/roles/gitr/tasks/main.yml | 62 ++++++++++++++++++++++++++ > playbooks/roles/gitr/vars/RedHat.yml | 7 ++- > 3 files changed, 70 insertions(+), 2 deletions(-) > > diff --git a/playbooks/roles/gitr/defaults/main.yml b/playbooks/roles/gitr/defaults/main.yml > index bcfbaef..ff737ca 100644 > --- a/playbooks/roles/gitr/defaults/main.yml > +++ b/playbooks/roles/gitr/defaults/main.yml > @@ -18,3 +18,6 @@ gitr_thread_single: false > gitr_thread_fast: false > gitr_thread_stress: false > gitr_thread_custom: false > + > +cvsps_git: https://github.com/andreyvit/cvsps.git > +cvsps_data: "{{ data_path }}/cvsps" > diff --git a/playbooks/roles/gitr/tasks/main.yml b/playbooks/roles/gitr/tasks/main.yml > index 330350c..2eafeaa 100644 > --- a/playbooks/roles/gitr/tasks/main.yml > +++ b/playbooks/roles/gitr/tasks/main.yml > @@ -11,6 +11,11 @@ > failed_when: false > tags: vars > > +- name: Set up the /data mount point > + tags: ['data_partition'] > + ansible.builtin.include_role: > + name: create_data_partition > + > - name: Set the name of the test group > tags: vars > ansible.builtin.set_fact: > @@ -42,6 +47,20 @@ > paths: > - 'vars' > > +- name: Update gitr depencies for RHEL/Centos > + tags: gitr > + ansible.builtin.set_fact: > + gitr_packages: "{{ gitr_packages + ['perl-App-cpanminus'] }}" > + when: > + - ansible_distribution != "Fedora" > + > +- name: Update gitr dependencies for Fedora > + tags: gitr > + ansible.builtin.set_fact: > + gitr_packages: "{{ gitr_packages + ['cvsps', 'perl-TAP-Harness-Archive'] }}" > + when: > + - ansible_distribution == "Fedora" > + > - name: Install dependencies for gitr > tags: gitr > become: true > @@ -51,6 +70,49 @@ > name: "{{ gitr_packages }}" > state: present > > +- name: Install CPAN modules for gitr > + tags: gitr > + become: true > + become_flags: 'su - -c' > + become_method: ansible.builtin.sudo > + community.general.cpanm: > + name: "{{ item }}" > + with_items: "{{ gitr_cpan_modules }}" > + when: > + - ansible_distribution != "Fedora" > + > +- name: git clone cvsps > + tags: gitr > + ansible.builtin.git: > + repo: "{{ cvsps_git }}" > + dest: "{{ cvsps_data }}" > + update: true > + retries: 3 > + delay: 5 > + register: result > + until: not result.failed > + when: > + - ansible_distribution != "Fedora" > + > +- name: Build cvsps > + tags: gitr > + community.general.make: > + chdir: "{{ cvsps_data }}" > + jobs: "{{ ansible_processor_nproc }}" > + when: > + - ansible_distribution != "Fedora" > + > +- name: Install cvsps > + tags: gitr > + become: true > + become_flags: 'su - -c' > + become_method: ansible.builtin.sudo > + community.general.make: > + target: install > + chdir: "{{ cvsps_data }}" > + when: > + - ansible_distribution != "Fedora" > + > - name: Set up an iSCSI initiator on the target node > ansible.builtin.include_role: > name: iscsi > diff --git a/playbooks/roles/gitr/vars/RedHat.yml b/playbooks/roles/gitr/vars/RedHat.yml > index 57f2f35..caf9840 100644 > --- a/playbooks/roles/gitr/vars/RedHat.yml > +++ b/playbooks/roles/gitr/vars/RedHat.yml > @@ -1,7 +1,6 @@ > --- > gitr_packages: > - cvs > - - cvsps > - expat-devel > - gcc > - gettext > @@ -9,11 +8,15 @@ gitr_packages: > - git-email > - glibc-utils > - libcurl-devel > + - make > - openssl-devel > - perl-Memoize > - - perl-TAP-Harness-Archive > - perl-Test-Harness > - perl-Test-Simple > - subversion > - subversion-perl > + - tar > - zlib-devel > + > +gitr_cpan_modules: > + - TAP::Harness::Archive > -- > 2.44.0 > > Reviewed-by: Chuck Lever With stock kdevops, I'm seeing some gitr failures (eg, t6300) on Fedora 40 that were not there on Fedora 39. Wondering if this series might help with that. -- Chuck Lever