Re: [PATCH -v2] Resource: fix region_intersects() for CXL memory

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Wed, Sep 04, 2024 at 03:48:44PM +0800, Huang, Ying wrote:
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
> > On Mon, Aug 19, 2024 at 10:34:13AM +0800, Huang Ying wrote:

...

> >> Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
> >> Cc: Dan Williams <dan.j.williams@intel.com>
> >> Cc: David Hildenbrand <david@redhat.com>
> >> Cc: Davidlohr Bueso <dave@stgolabs.net>
> >> Cc: Jonathan Cameron <jonathan.cameron@huawei.com>
> >> Cc: Dave Jiang <dave.jiang@intel.com>
> >> Cc: Alison Schofield <alison.schofield@intel.com>
> >> Cc: Vishal Verma <vishal.l.verma@intel.com>
> >> Cc: Ira Weiny <ira.weiny@intel.com>
> >> Cc: Alistair Popple <apopple@nvidia.com>
> >> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >> Cc: Bjorn Helgaas <bhelgaas@google.com>
> >> Cc: Baoquan He <bhe@redhat.com>
> >
> > You may move Cc list after '---', so it won't unnecessarily pollute the commit
> > message.
> 
> Emm... It appears that it's a common practice to include "Cc" in the
> commit log.

For what benefit? (Note, nowadays we have lore.kernel.org which is under
the control of Linux kernel project)

Personally I see only downsides of these being inside the commit message.

Here is a discussion about this
https://lore.kernel.org/linux-doc/20240423132024.2368662-1-andriy.shevchenko@linux.intel.com/

...

> >> +		ostart = max(res.start, p->start);
> >> +		oend = min(res.end, p->end);
> >
> > Isn't a reinvention of resource_intersection()? With that in place you may also
> > drop the above resource_overlaps().
> 
> sizeof(struct resource) == 8 * sizeof(unsigned long)
> 
> Just want to avoid to define another struct resource on stack.

Is it a problem?

-- 
With Best Regards,
Andy Shevchenko