From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FF8912CDB0 for ; Wed, 4 Sep 2024 19:07:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725476839; cv=none; b=M/G/uwujztuwSYr0LIz+lfHWQCFUt3+d/YO13YL3/gcdsPUHEP/DxTwOURO+XqH51CjGg/hEx86l/7bD7rocCIyCTejlHGE6IjoCRt5AQLCYKpkqqTJEmz4ijt7xDHc9B9IBhgbQRnfl4UGpC/BmhK9uKUsazaSk1l7X6HzL4ho= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725476839; c=relaxed/simple; bh=hLtrV9fo2ENFsppI3EM5//2a1v6xLdR6UciGmLp3E0Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nAjn+6z914rrce6MLO3Xq+T91w5t54fccLBHV/Y5CAD/A9KBTQAe2vnZoYb695i1PSfFF4Rdvh3MoBUsqRU5skF+Hz9ueb2FIk9GQVFn+HgDqB4lxAd+t+5Urj/245FUqNurrc0HxWPRTth71EBoonpIlVsQ1h0WNgZnTidXlu4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=O83/Gbf8; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="O83/Gbf8" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-2da55ea8163so1940147a91.1 for ; Wed, 04 Sep 2024 12:07:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1725476837; x=1726081637; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=o2U7wgEbLS4i4a8ingcWCBDQrhNmwXrz+ffgx64j+qE=; b=O83/Gbf8QHytDjtKBC2VP1NHGE69K97QzsnnPLhood4y27NcYWvbRpAYJZHt9lWN5L piIbJArzYN5Qf7SPBI49vUE2VjW4GYvYSSeWevifsRIo2JwxWESaOWjUw9KNQUlcAOjW M57C0o6ln8DywnEEETUAFokbAoSyohPtRCDiZcplIwBMyuz2tior5wk9DBWcDqSCynVu jAvaHC4YqJY0ofPBytPoIllLrn/HiP7br0fsxdsL6Iq9qfvJZ6jQmTfrZAaTKNkj8iqz t2z+vruq/jHHUU7ujoGLdO82BtEDxwSzFDLuOmaaNt8DQwT2aKkt8z2EJBcsRPlrEHcB kXQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725476837; x=1726081637; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=o2U7wgEbLS4i4a8ingcWCBDQrhNmwXrz+ffgx64j+qE=; b=DiuebWdYZ+iRile86sC6H8ax9e+vA7sI+jGQ66+mQEZ+FaZ3NkO9O06y5HNLL9C4rn 5anpiFefnIPwNmJRbEPUtSPcR/LCJ/JEW0s9SIrpzwnrcYsXkHzNeTv+1QrfJ+ParMLn 9g9/AoAA5uDVwiu/4NKwtCmcAwODJkOy+FqKJuWrsdd/XO/G+6zP2Czw5//xfdsyGjb5 rnc6Z4orp4f/NTgh4NLpcEP9N55X+S9HUvBHOW0LURGUL871+H/37iClt/P0zOM8bUVv lmw66mTIe6BcEncERcziBoYErqf8wSyA1Mblu1tu0lSFcVvyBLisqa2rOkCJPXcWcaOv c7Ow== X-Forwarded-Encrypted: i=1; AJvYcCUWQ2qmULWP9OTuFwpthPEAZ3sdZDRqfvUUVaCu0CEhMnyvMWBsBlGR0KcafitWvZLktgdY77lTAhTvMg==@vger.kernel.org X-Gm-Message-State: AOJu0Yyk5cBxuxmCBg/2bHGw7qX+bgcHWHw5tOskQ5WvAFMbmiuDnrkX w/H8hvs41movewAuPz0BwE2tT1XuuYdPeVyKC8ZfvWPxh8Y069+Se9geuiar99k= X-Google-Smtp-Source: AGHT+IGRXMFw8eODDeHuSZGixob1QmbWy894YR3dac/q8kTYt2afjYPzXJiDq5qdDnRm4AHLgT4d4Q== X-Received: by 2002:a17:90b:300e:b0:2d8:27c3:87d7 with SMTP id 98e67ed59e1d1-2d893284ebdmr13545892a91.8.1725476836620; Wed, 04 Sep 2024 12:07:16 -0700 (PDT) Received: from debug.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2da53740084sm4858056a91.32.2024.09.04.12.07.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Sep 2024 12:07:16 -0700 (PDT) Date: Wed, 4 Sep 2024 12:07:12 -0700 From: Deepak Gupta To: Mark Brown Cc: "Liam R. Howlett" , Richard Henderson , Ivan Kokshaysky , Matt Turner , Vineet Gupta , Russell King , Guo Ren , Huacai Chen , WANG Xuerui , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Andreas Larsson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Chris Zankel , Max Filippov , Andrew Morton , Vlastimil Babka , Lorenzo Stoakes , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-csky@vger.kernel.org, loongarch@lists.linux.dev, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org, Rick Edgecombe Subject: Re: [PATCH 3/3] mm: Care about shadow stack guard gap when getting an unmapped area Message-ID: References: <20240902-mm-generic-shadow-stack-guard-v1-0-9acda38b3dd3@kernel.org> <20240902-mm-generic-shadow-stack-guard-v1-3-9acda38b3dd3@kernel.org> Precedence: bulk X-Mailing-List: linux-alpha@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: On Tue, Sep 03, 2024 at 08:57:20PM +0100, Mark Brown wrote: >On Tue, Sep 03, 2024 at 03:41:49PM -0400, Liam R. Howlett wrote: >> * Mark Brown [240902 15:09]: > >> > +static inline unsigned long stack_guard_placement(vm_flags_t vm_flags) >> > +{ >> > + if (vm_flags & VM_SHADOW_STACK) >> > + return PAGE_SIZE; > >> Is PAGE_SIZE is enough? > >It's what x86 currently uses so it'll be no worse off if it gets moved >to the generic code (there's a comment in the arch code explaing what's >needed there) and it's enough for arm64, we only do single record >pushes/pops or (optionally) writes to unconstrained addresses. It's enough for RISC-V too. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39B39CD4F21 for ; Wed, 4 Sep 2024 19:07:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=z4fmkjI9GloK8lwE4lbOpQlSh43zNokxdnSckmjTW+M=; b=EldXpGD/eOKjOtf8W4DL/IDMW2 9EcDX2Lc6vErXNRE6ea8w+IWLR1akfbkuHgiyDQFbCP587RJcXZLkcln5DwlZEwjU2sPkDjGZHtEg /p5nDD/aU0d4wtmajw0piPkP4SBpBVjZc+5pLQjbgAao02jBvIB82zZICVOKJhQ3YrneA43yCFHGQ EmnscW+XMgyI//TyeZtoXfFiPiGzwIrI9fZ/0P+tAFVKMMUZhAh4vunQuqy+4CdBIhqqm07CSo8k6 GjyZoXdkJetmMSCfJGO8QA8iCXPm3jvNrn10sk93oFtAAa2U5Hwn2fZjkosGs65MkJskVeS4VbZin zuLV/QEQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1slvLc-00000005k2X-39UK; Wed, 04 Sep 2024 19:07:20 +0000 Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1slvLZ-00000005k19-3NfS for linux-snps-arc@lists.infradead.org; Wed, 04 Sep 2024 19:07:20 +0000 Received: by mail-pg1-x535.google.com with SMTP id 41be03b00d2f7-7cd967d8234so4350763a12.2 for ; Wed, 04 Sep 2024 12:07:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1725476837; x=1726081637; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=o2U7wgEbLS4i4a8ingcWCBDQrhNmwXrz+ffgx64j+qE=; b=lEsrQvohUr/XwSlx85mB+79l9dqYPT9N78k1rHpUYZNviu3uj8KXv1FWe0M/vAFxnc JY/v8s6bcLml08QNyQgQ/G4iJnFIC7joTRXYAfhOcsi6eXdaTMZ43fIHoYNiqOB1DN2K aIxDCAUDe5roZfrwXMV65kMRIMj1BhzGqvnmTTWoY+3i8pwOCwxxg5Sb3sm8d6f6nnFf D7lYLQAGJ8lp23i3vDutv81vZA08QFs/NrwpY5mA+bYDKtNJRWTHAUz+k/GrmaZkePfI /l+PIwwAyxdP5VXh6OZNKj2YJnOhgjzt0jOtb/Mve7tkoJTP9NgdP5Ob/WXZEe7lRR8n MoWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725476837; x=1726081637; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=o2U7wgEbLS4i4a8ingcWCBDQrhNmwXrz+ffgx64j+qE=; b=UpPIbTlf2QCVpO6OzQ/KWcOlSD2R9XtsWdk6mHVge78Z70IDX42NjFNWkovJKEH2Jl tOF3m3NTr+Rg6JLH4+j1+1hiUxMlpd8gWWRCKqm+lh5C0hhGy26bDMTb9Ia/C+O32J9X lRiAU3FU7SilsKDGL2u4VfNmMndr6GvQrdGPihtw81E42rWDxbbb6ZUGzKspddbvn2ku bSgMzjkjUOOUDqjE7ADVvDrH9B/D5YJtY/4X0ZldBQNCM3pNHGPyx2fMaf/AjrLd0r/l 02d6z07Sk3sXJHnvKQ+0LACh8sAL8ebnr3QNgP5+KKDaJ2YkqgYYdP+1aFxmHy5HHlFG +CLQ== X-Forwarded-Encrypted: i=1; AJvYcCVSww3LesVLflH+vx7rTS3DkOstDiTYQiwSVFg3DnUoJqvJSypXw9fikluJ58WH19zR0hnuBlKyZTlT1cOj4g==@lists.infradead.org X-Gm-Message-State: AOJu0YzDZjzdm9zdahCty2STk0hD2OlfEDbgSPhrTq01MAn9T5Yd5TXt jVHmUEh+rLNmjuRJhfhj9LXfUGiJohHzYdpxe88A2xaeTGvDIBPghtgf316YTYg= X-Google-Smtp-Source: AGHT+IGRXMFw8eODDeHuSZGixob1QmbWy894YR3dac/q8kTYt2afjYPzXJiDq5qdDnRm4AHLgT4d4Q== X-Received: by 2002:a17:90b:300e:b0:2d8:27c3:87d7 with SMTP id 98e67ed59e1d1-2d893284ebdmr13545892a91.8.1725476836620; Wed, 04 Sep 2024 12:07:16 -0700 (PDT) Received: from debug.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2da53740084sm4858056a91.32.2024.09.04.12.07.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Sep 2024 12:07:16 -0700 (PDT) Date: Wed, 4 Sep 2024 12:07:12 -0700 From: Deepak Gupta To: Mark Brown Cc: "Liam R. Howlett" , Richard Henderson , Ivan Kokshaysky , Matt Turner , Vineet Gupta , Russell King , Guo Ren , Huacai Chen , WANG Xuerui , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Andreas Larsson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Chris Zankel , Max Filippov , Andrew Morton , Vlastimil Babka , Lorenzo Stoakes , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-csky@vger.kernel.org, loongarch@lists.linux.dev, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org, Rick Edgecombe Subject: Re: [PATCH 3/3] mm: Care about shadow stack guard gap when getting an unmapped area Message-ID: References: <20240902-mm-generic-shadow-stack-guard-v1-0-9acda38b3dd3@kernel.org> <20240902-mm-generic-shadow-stack-guard-v1-3-9acda38b3dd3@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240904_120717_881058_973410EB X-CRM114-Status: GOOD ( 12.25 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org On Tue, Sep 03, 2024 at 08:57:20PM +0100, Mark Brown wrote: >On Tue, Sep 03, 2024 at 03:41:49PM -0400, Liam R. Howlett wrote: >> * Mark Brown [240902 15:09]: > >> > +static inline unsigned long stack_guard_placement(vm_flags_t vm_flags) >> > +{ >> > + if (vm_flags & VM_SHADOW_STACK) >> > + return PAGE_SIZE; > >> Is PAGE_SIZE is enough? > >It's what x86 currently uses so it'll be no worse off if it gets moved >to the generic code (there's a comment in the arch code explaing what's >needed there) and it's enough for arm64, we only do single record >pushes/pops or (optionally) writes to unconstrained addresses. It's enough for RISC-V too. _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc