Re: [PATCH v14 3/7] perf version: Update --build-options to use 'supported_features' array

[Arnaldo Carvalho de Melo <acme@kernel.org>]

On Thu, Sep 05, 2024 at 12:36:21AM +0530, Aditya Gupta wrote:
> Hi Arnaldo,
> 
> On 04/09/24 18:35, Arnaldo Carvalho de Melo wrote:
> 
> > On Wed, Sep 04, 2024 at 11:48:32AM +0530, Aditya Gupta wrote:
> > > Now that the feature list has been duplicated in a global
> > > 'supported_features' array, use that array instead of manually checking
> > > status of built-in features.
> > > 
> > > This helps in being consistent with commands such as 'perf check feature',
> > > so commands can use the same array, and any new feature can be added at
> > > one place, in the 'supported_features' array
> > So I tested and applied the first two patches, but it is failing for
> > this 3rd, please rebase from what is in the tmp.perf-tools-next branch
> > at:
> > 
> > https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git
> 
> Thank you !
> 
> I have rebased the patches in v15.
> 
> Patch #1 & #2, are same as already applied in tmp.perf-tools-next branch, so
> they can be ignored or even if applied git am should ignore them.

I dit it with:

[acme@toolbox perf-tools-next]$ b4 am -P3-7 -ctsl --cc-trailers 20240904190132.415212-1-adityag@linux.ibm.com
Grabbing thread from lore.kernel.org/all/20240904190132.415212-1-adityag@linux.ibm.com/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Nothing matching that query.
Analyzing 8 messages in the thread
Looking for additional code-review trailers on lore.kernel.org
Checking attestation on all messages, may take a moment...
---
  ✓ [PATCH v15 3/7] perf version: Update --build-options to use 'supported_features' array
    + Link: https://lore.kernel.org/r/20240904190132.415212-4-adityag@linux.ibm.com
    + Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  ✓ [PATCH v15 4/7] tools/perf/tests: Update test_task_analyzer.sh to use perf check feature
    + Link: https://lore.kernel.org/r/20240904190132.415212-5-adityag@linux.ibm.com
    + Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  ✓ [PATCH v15 5/7] tools/perf/tests: Update probe_vfs_getname.sh script to use perf check feature
    + Link: https://lore.kernel.org/r/20240904190132.415212-6-adityag@linux.ibm.com
    + Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  ✓ [PATCH v15 6/7] perf: Fix inconsistencies in feature names
    + Link: https://lore.kernel.org/r/20240904190132.415212-7-adityag@linux.ibm.com
    + Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  ✓ [PATCH v15 7/7] perf: Add more features to supported_features list
    + Link: https://lore.kernel.org/r/20240904190132.415212-8-adityag@linux.ibm.com
    + Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  ---
  ✓ Signed: DKIM/ibm.com (From: adityag@linux.ibm.com)
---
Total patches: 5 (cherrypicked: 3-7)
---
Cover: ./v15_20240905_adityag_introduce_perf_check_subcommand.cover
 Link: https://lore.kernel.org/r/20240904190132.415212-1-adityag@linux.ibm.com
 Base: not specified
       git am ./v15_20240905_adityag_introduce_perf_check_subcommand.mbx
⬢[acme@toolbox perf-tools-next]$

⬢[acme@toolbox perf-tools-next]$        git am ./v15_20240905_adityag_introduce_perf_check_subcommand.mbx
Applying: perf version: Update --build-options to use 'supported_features' array
Applying: tools/perf/tests: Update test_task_analyzer.sh to use perf check feature
Applying: tools/perf/tests: Update probe_vfs_getname.sh script to use perf check feature
Applying: perf: Fix inconsistencies in feature names
Applying: perf: Add more features to supported_features list
⬢[acme@toolbox perf-tools-next]$

Now test building it one after the other and then the container builds,
eventually will flow to perf-tools-next.

Thanks for persisting and collaborating!

- Arnaldo