From: Carlos Llamas <cmllamas@google.com>
To: Ba Jing <bajing@cmss.chinamobile.com>
Cc: gregkh@linuxfoundation.org, arve@android.com, tkjos@android.com,
maco@android.com, joel@joelfernandes.org, brauner@kernel.org,
surenb@google.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] binder: modify the comment for binder_proc_unlock
Date: Thu, 5 Sep 2024 22:44:41 +0000 [thread overview]
Message-ID: <Zto0WT8biWkrv-43@google.com> (raw)
In-Reply-To: <20240902052330.3115-1-bajing@cmss.chinamobile.com>
On Mon, Sep 02, 2024 at 01:23:30PM +0800, Ba Jing wrote:
> Modify the comment for binder_proc_unlock() to clearly indicate which
> spinlock it releases and to better match the acquire comment block
> in binder_proc_lock().
>
> Signed-off-by: Ba Jing <bajing@cmss.chinamobile.com>
> ---
> Notes:
> v1: https://lore.kernel.org/all/20240830073743.2052-1-bajing@cmss.chinamobile.com/
>
> v2: Reword commit log per suggestions from cmllamas@
> https://lore.kernel.org/all/20240902013636.1739-1-bajing@cmss.chinamobile.com/
>
> v3: Wrap commit message. Add version history.
> https://lore.kernel.org/all/20240902025720.2334-1-bajing@cmss.chinamobile.com/
>
> v4: Modify the commit information.
> https://lore.kernel.org/all/20240902033754.2708-1-bajing@cmss.chinamobile.com/
>
> v5: Change the format and wrap the changelog text at 72 columns.
>
> drivers/android/binder.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index fc55b5d0e4f3..578861d57045 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -277,7 +277,7 @@ _binder_proc_lock(struct binder_proc *proc, int line)
> }
>
> /**
> - * binder_proc_unlock() - Release spinlock for given binder_proc
> + * binder_proc_unlock() - Release outer lock for given binder_proc
> * @proc: struct binder_proc to acquire
> *
> * Release lock acquired via binder_proc_lock()
> --
> 2.33.0
Thanks,
Acked-by: Carlos Llamas <cmllamas@google.com>
prev parent reply other threads:[~2024-09-05 22:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 5:23 [PATCH v5] binder: modify the comment for binder_proc_unlock Ba Jing
2024-09-05 22:44 ` Carlos Llamas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zto0WT8biWkrv-43@google.com \
--to=cmllamas@google.com \
--cc=arve@android.com \
--cc=bajing@cmss.chinamobile.com \
--cc=brauner@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=surenb@google.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.