Re: [PATCH v3 0/9] Tidy some minor things in the stream table/cd table area

[Nicolin Chen <nicolinc@nvidia.com>]

On Tue, Aug 06, 2024 at 08:31:14PM -0300, Jason Gunthorpe wrote:
> Will pointed out that two places referring to the CD/STE struct did not
> get the new types. While auditing this code a few more oddities were
> noticed. Based on a feedback from Mostafa and Nicolin a few more things
> were fixed up too
> 
> - Use types for all the HW structures everywhere even for the L1
>   descriptors that are just a single 8 bytes. This helps with clarity of
>   what everthing is pointing at
> - Use indexing helpers for the STE/CD two level calculations
> - Use sizeof(struct X) instead of open coded math on constants. The sizeof
>   naturally follows the type of the related variable in almost all cases
> - Remove redundant dma_addr_t's and save some memory
> - Remove redundant devm usage
> - Use the modern rbtree API
> 
> Parts of this have been sitting in my tree for a while now, it grew a bit
> since v1, but nothing is particularly profound here. Enough is merged now
> that they can be cleanly based and are seperate from my other series.
> 
> v3:
>  - Rebase to v6.11-rc2
>  - Preserve the "2-level strtab only covers %u/%u bits of SID" without
>    change
>  - Vertically align some of the constants
>  - Use u32 for the type of the index and sid
>  - Fix missing * in le64_to_cpu() in interior patch
>  - Bring back accidently lost "Use the new rb tree helpers" patch

I didn't exclusively test this series but it has been included in
my nesting branch for a while. Considering 2-stage configurations
and vSVA cases are involved during my testings, all my Tested-bys
still stand.

Thanks
Nicolin