From: Niklas Cassel <cassel@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH v5 8/9] ata: libata: Introduce ata_dev_free_resources
Date: Fri, 6 Sep 2024 10:41:38 +0200 [thread overview]
Message-ID: <ZtrAQglvS_6ZKzhq@ryzen.lan> (raw)
In-Reply-To: <20240906015847.229539-9-dlemoal@kernel.org>
On Fri, Sep 06, 2024 at 10:58:46AM +0900, Damien Le Moal wrote:
> Introduce the function ata_dev_free_resources() to free the resources
> allocated to support a device features. For now, this function is
> reduced to calling zpodd_exit() for devices that have this feature
> enabled.
>
> ata_dev_free_resources() is called from ata_eh_dev_disable() as this
> function is always called for all devices attached to a port that is
> being detached and for devices that are being disabled due to being
> removed (detached) from the system or due to errors.
>
> With this change, the call to zpodd_exit() done in ata_port_detach() is
> removed as that function starts by removing all devices attached to the
> port using libata EH, thus resulting in ata_eh_dev_disable() being
> called and the zpodd_exit() function being executed.
>
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
> ---
Reviewed-by: Niklas Cassel <cassel@kernel.org>
next prev parent reply other threads:[~2024-09-06 8:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 1:58 [PATCH v5 0/9] Code cleanup and memory usage reduction Damien Le Moal
2024-09-06 1:58 ` [PATCH v5 1/9] ata: libata: Cleanup libata-transport Damien Le Moal
2024-09-06 1:58 ` [PATCH v5 2/9] ata: libata-scsi: Improve ata_scsi_handle_link_detach() Damien Le Moal
2024-09-06 8:32 ` Niklas Cassel
2024-09-06 1:58 ` [PATCH v5 3/9] ata: libata: Improve __ata_qc_complete() Damien Le Moal
2024-09-06 1:58 ` [PATCH v5 4/9] ata: libata: Move sata_down_spd_limit() to libata-sata.c Damien Le Moal
2024-09-06 1:58 ` [PATCH v5 5/9] ata: libata: Move sata_std_hardreset() definition " Damien Le Moal
2024-09-06 1:58 ` [PATCH v5 6/9] ata: libata: Rename ata_eh_read_sense_success_ncq_log() Damien Le Moal
2024-09-06 1:58 ` [PATCH v5 7/9] ata: libata: Move sector_buf from struct ata_port to struct ata_device Damien Le Moal
2024-09-06 1:58 ` [PATCH v5 8/9] ata: libata: Introduce ata_dev_free_resources Damien Le Moal
2024-09-06 8:41 ` Niklas Cassel [this message]
2024-09-06 1:58 ` [PATCH v5 9/9] ata: libata: Improve CDL resource management Damien Le Moal
2024-09-06 8:51 ` Niklas Cassel
2024-09-06 10:21 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZtrAQglvS_6ZKzhq@ryzen.lan \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.