From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A296415852B; Fri, 6 Sep 2024 11:41:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725622864; cv=none; b=RR8caA6S/kKOgCgwJ4XNLqLKk6xQPuJNC2WOBA+HOZI9tmlFduxKU85LVB03BBvpm/NKFV0JQGwJxvMbEFvPU/Ohw86udnFRJThe4n2G99KQD2wBR9JYaOPw8UNALNfrtS68jCNF0T5Hfwa2tdI1kK6+SOgYI9H+wedwvwWRQPI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725622864; c=relaxed/simple; bh=YGHl4O8g0y5wAhBvvDSoCsRTbOvTVD97w2B1eAugi6k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DzuL4ctg2jtEDbA6f+UdXqpEUeoqrb1f2sYd9fQlO5CnGphsXyEsq8w4RmT1Vbqh/KO8bGHkn2TdpdsXooWRrfSDCBaQNgL1HO31JvToHG01N9XCRiOPRv5d4/9ldrbEkIX9uN+EIxczxB3vxb14U8EvFBXrLabdeV4CnmoJ0K8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=KxpKwfmT; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="KxpKwfmT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725622863; x=1757158863; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=YGHl4O8g0y5wAhBvvDSoCsRTbOvTVD97w2B1eAugi6k=; b=KxpKwfmTn7rCQHOb2owvwfdtDhmYBWVpOhnm5Mg14rF5FSnzCMGSStqj IXazn74c2+N8lL2C5q9tJsvFnyByvT3LhW1unQ+p5QR104w1XqyHD372e 7dW196bnu3nobt6kVelBkN3qm0TJM0VvO4d6gr/lweljb7xAve8X41bA1 FRR5sczL0r4I7PIUPSPqzNFWUv+lqzEF95HjoElawQK2GoxCVp+Z3Rc+d cXTWfTlvyUzzvA/Atwz/1oUaAl065k3n+SoTFe4wKA1PnrJ0HWudUM8ni VYGbybsfmMKUtnPEf1i9VH66IypGByTEnnbu66XatJWqjdxc8GHfx8i+q Q==; X-CSE-ConnectionGUID: 5KzKzNb9ScGyZPu8UtXNUw== X-CSE-MsgGUID: pKnBySZpQk+a2YJ2anc0lA== X-IronPort-AV: E=McAfee;i="6700,10204,11187"; a="35730374" X-IronPort-AV: E=Sophos;i="6.10,207,1719903600"; d="scan'208";a="35730374" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Sep 2024 04:41:03 -0700 X-CSE-ConnectionGUID: WQK9yInwQwaYZ/2sETdENg== X-CSE-MsgGUID: +kM31qQnQxSVCYmefBQkbg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,207,1719903600"; d="scan'208";a="103406212" Received: from smile.fi.intel.com ([10.237.72.54]) by orviesa001.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Sep 2024 04:40:57 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1smXKg-00000005lsd-1cyA; Fri, 06 Sep 2024 14:40:54 +0300 Date: Fri, 6 Sep 2024 14:40:53 +0300 From: Andy Shevchenko To: Andi Shyti Cc: Tyrone Ting , avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, wsa@kernel.org, rand.sec96@gmail.com, wsa+renesas@sang-engineering.com, tali.perry@nuvoton.com, Avi.Fishman@nuvoton.com, tomer.maimon@nuvoton.com, KWLIU@nuvoton.com, JJLIU0@nuvoton.com, kfting@nuvoton.com, openbmc@lists.ozlabs.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/7] i2c: npcm: restore slave addresses array length Message-ID: References: <20240830034640.7049-1-kfting@nuvoton.com> <20240830034640.7049-2-kfting@nuvoton.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Thu, Sep 05, 2024 at 11:36:45PM +0200, Andi Shyti wrote: > On Fri, Aug 30, 2024 at 11:46:34AM GMT, Tyrone Ting wrote: > > The smatch check warning is "buffer overflow 'npcm_i2caddr' 2 <= 9". > > The original design supports 10 slave addresses although only 2 > > addresses are required for current implementation. > > > > Restore the npcm_i2caddr array length to fix the smatch warning. > > > > Fixes: 47d506d1a28f ("i2c: npcm: Remove own slave addresses 2:10") > > Reported-by: Dan Carpenter > > Closes: https://lore.kernel.org/r/202408130818.FgDP5uNm-lkp@intel.com/ > > Signed-off-by: Tyrone Ting > > your email used in From: is different that your e-mail used the > SoB. Is this done in purpose? If so I will keep it as it is, no > problem for me, otherwise I can fix it while applying it. IIRC Linux Next has the respective check and it will become your problem :-) -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB5D9CD5BDD for ; Fri, 6 Sep 2024 11:41:30 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4X0Z7J2Qcyz3cXt for ; Fri, 6 Sep 2024 21:41:16 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1725622871; cv=none; b=eV6UuWBQqZ3c6ABZTjt7I+iZRIoqA/xnpv/VTSSI/Qg+upQLaXGYFjkIOZnryYshyB1UFxNngLNZNU/7DrPwLG4AnBUxtt4FlIdYHhQwuE7ChnVbwpRgPEzP3BezABym2waarVjFHVp8kFTlPJ4kz63p/vT03GS1WrQ4O2cROiPL87d4Ni/76dcpyn/AED7LxZhP7z4T6eGSMO4Tt0ZvNHz5Lg3+F0Nx3/84Y+8Vtkb67JZMmnxkdK2BSiiA8GrsgrJDcWf47HDCAoNmu2xqnrPlvEiev+Rk+LwsDErTiLlODa6Ilb6jaTy5psqWJcgicXo/WRC6gEQmt+Ohtw9KmQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1725622871; c=relaxed/relaxed; bh=ZuBialpnznpp0hGkx7QHMhhGB2qgu5oU9Q5F1shcDEc=; h=DKIM-Signature:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:Content-Disposition:In-Reply-To; b=AqU6n3tA1FIbKKmdzRTkp32pajHStN8fKCa7koO5q+rvLf2X8Cuk3H0hvqSuTtqWpvGx/fwrIbHm5qHQudHVA5PKa4cLaYUGBUK4+x0gOQlSKdqsuSPJQXjrk7mEiSxPWXUmOKhj9xuVlz7+FQWLfuXR/lr59QlTvvB4KSpxRD13SjS6n5oRVDQ7OBlzlTK932r+OCXyGizPcnImBEOVKxWYK6kwdXOY5PKhI43XdwARHcTx8ZNF03sK+VPHjGlcIRX/07MkCavxjzs5ZnhYWW1L8ItA8xTKJ4p3K6k3EANJZzi3r2oRWXXbDC+jDHWWxh3g4AazkxzN7Q1YUyLviw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=El0hFk1F; dkim-atps=neutral; spf=none (client-ip=198.175.65.12; helo=mgamail.intel.com; envelope-from=andriy.shevchenko@linux.intel.com; receiver=lists.ozlabs.org) smtp.mailfrom=linux.intel.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=El0hFk1F; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux.intel.com (client-ip=198.175.65.12; helo=mgamail.intel.com; envelope-from=andriy.shevchenko@linux.intel.com; receiver=lists.ozlabs.org) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4X0Z7842rlz304C for ; Fri, 6 Sep 2024 21:41:06 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725622869; x=1757158869; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=YGHl4O8g0y5wAhBvvDSoCsRTbOvTVD97w2B1eAugi6k=; b=El0hFk1FSpeibnpXbAIJmruYVlshknrInuIHSiJwLfzr9qvDuzsSPiDg AtwRo5vE8X9xjrGy0C0khGen0XdXasFO6xgf4B6+NK5D9NPJBxlkoB6sy A5SBIzKSrhiYESuT3hywF8zQpRcYW5k8tskjQ8MTvYXorCBx7cx9gkMHp zqIMZp3pC3OQhkITAiW+MfgTpJBtPuwcx0xGE0O1oUGJCjWKTxi7sD6x5 5D6meylCOOCAWcf2yoQSmLfP/E0LL9FFBv+TgK9wqZW13QqeOdTUBlBIF MfIdlW82I7r+R9+ICx6rGKWjeQw4hdk/pc3CFS2tXa5G/5OqlGXBReUV8 w==; X-CSE-ConnectionGUID: 2aSaScrDSpWGHlCaGp1/8w== X-CSE-MsgGUID: ak690FqxQNmooS79Lc/1kQ== X-IronPort-AV: E=McAfee;i="6700,10204,11187"; a="35730379" X-IronPort-AV: E=Sophos;i="6.10,207,1719903600"; d="scan'208";a="35730379" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Sep 2024 04:41:03 -0700 X-CSE-ConnectionGUID: WQK9yInwQwaYZ/2sETdENg== X-CSE-MsgGUID: +kM31qQnQxSVCYmefBQkbg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,207,1719903600"; d="scan'208";a="103406212" Received: from smile.fi.intel.com ([10.237.72.54]) by orviesa001.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Sep 2024 04:40:57 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1smXKg-00000005lsd-1cyA; Fri, 06 Sep 2024 14:40:54 +0300 Date: Fri, 6 Sep 2024 14:40:53 +0300 From: Andy Shevchenko To: Andi Shyti Subject: Re: [PATCH v2 1/7] i2c: npcm: restore slave addresses array length Message-ID: References: <20240830034640.7049-1-kfting@nuvoton.com> <20240830034640.7049-2-kfting@nuvoton.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: KWLIU@nuvoton.com, tomer.maimon@nuvoton.com, tmaimon77@gmail.com, wsa+renesas@sang-engineering.com, avifishman70@gmail.com, venture@google.com, openbmc@lists.ozlabs.org, kfting@nuvoton.com, JJLIU0@nuvoton.com, linux-kernel@vger.kernel.org, tali.perry1@gmail.com, wsa@kernel.org, tali.perry@nuvoton.com, linux-i2c@vger.kernel.org, Avi.Fishman@nuvoton.com, Tyrone Ting , rand.sec96@gmail.com, benjaminfair@google.com Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Thu, Sep 05, 2024 at 11:36:45PM +0200, Andi Shyti wrote: > On Fri, Aug 30, 2024 at 11:46:34AM GMT, Tyrone Ting wrote: > > The smatch check warning is "buffer overflow 'npcm_i2caddr' 2 <= 9". > > The original design supports 10 slave addresses although only 2 > > addresses are required for current implementation. > > > > Restore the npcm_i2caddr array length to fix the smatch warning. > > > > Fixes: 47d506d1a28f ("i2c: npcm: Remove own slave addresses 2:10") > > Reported-by: Dan Carpenter > > Closes: https://lore.kernel.org/r/202408130818.FgDP5uNm-lkp@intel.com/ > > Signed-off-by: Tyrone Ting > > your email used in From: is different that your e-mail used the > SoB. Is this done in purpose? If so I will keep it as it is, no > problem for me, otherwise I can fix it while applying it. IIRC Linux Next has the respective check and it will become your problem :-) -- With Best Regards, Andy Shevchenko