All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Zhang Zekun <zhangzekun11@huawei.com>
Cc: patrice.chotard@foss.st.com, andersson@kernel.org,
	linux-remoteproc@vger.kernel.org, chenjun102@huawei.com
Subject: Re: [PATCH v2 3/3] remoteporc: ingenic: Simplify with devm_platform_ioremap_resource_byname()
Date: Fri, 6 Sep 2024 10:00:48 -0600	[thread overview]
Message-ID: <ZtsnMHHYA9zlFdDH@p14s> (raw)
In-Reply-To: <20240906113405.92782-4-zhangzekun11@huawei.com>


You still have missed several instances.  I am dropping this set.

On Fri, Sep 06, 2024 at 07:34:05PM +0800, Zhang Zekun wrote:
> platform_get_resource_byname() and devm_ioremap_resource() can be
> replaced by devm_platform_ioremap_resource_byname(), which can
> simplify the code logic a bit, No functional change here.
> 
> Signed-off-by: Zhang Zekun <zhangzekun11@huawei.com>
> ---
>  drivers/remoteproc/ingenic_rproc.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/remoteproc/ingenic_rproc.c b/drivers/remoteproc/ingenic_rproc.c
> index 9902cce28692..1b78d8ddeacf 100644
> --- a/drivers/remoteproc/ingenic_rproc.c
> +++ b/drivers/remoteproc/ingenic_rproc.c
> @@ -183,8 +183,7 @@ static int ingenic_rproc_probe(struct platform_device *pdev)
>  	vpu->dev = &pdev->dev;
>  	platform_set_drvdata(pdev, vpu);
>  
> -	mem = platform_get_resource_byname(pdev, IORESOURCE_MEM, "aux");
> -	vpu->aux_base = devm_ioremap_resource(dev, mem);
> +	vpu->aux_base = devm_platform_ioremap_resource_byname(pdev, "aux");
>  	if (IS_ERR(vpu->aux_base)) {
>  		dev_err(dev, "Failed to ioremap\n");
>  		return PTR_ERR(vpu->aux_base);
> -- 
> 2.17.1
> 

  reply	other threads:[~2024-09-06 16:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-06 11:34 [PATCH v2 0/3] Simplify with devm_platform_ioremap_resource_byname() Zhang Zekun
2024-09-06 11:34 ` [PATCH v2 1/3] remoteproc: Use devm_platform_ioremap_resource_byname() helper function Zhang Zekun
2024-09-06 11:34 ` [PATCH v2 2/3] remoteproc: da8xx: Simplify with devm_platform_ioremap_resource_byname() Zhang Zekun
2024-09-06 11:34 ` [PATCH v2 3/3] remoteporc: ingenic: " Zhang Zekun
2024-09-06 16:00   ` Mathieu Poirier [this message]
2024-09-07  3:00     ` zhangzekun (A)
2024-09-09 16:07       ` Mathieu Poirier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZtsnMHHYA9zlFdDH@p14s \
    --to=mathieu.poirier@linaro.org \
    --cc=andersson@kernel.org \
    --cc=chenjun102@huawei.com \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=patrice.chotard@foss.st.com \
    --cc=zhangzekun11@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.