Re: [Buildroot] [PATCH v3 1/2] package/iana-assignments: new package

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Dario, All,

On 2024-09-06 19:15 +0200, Dario Binacchi spake thusly:
> The fixing of [1] and related code reviews [2] and [3] highlighted the
> need for a package providing a versioned PEN (Enterprise Numbers)
> registry file from IANA (Internet Assigned Numbers Authority).
> The GitHub repository from which this package originates is a mirror of
> the IANA registries periodically updated from https://www.iana.org/protocols.
> 
> [1] http://autobuild.buildroot.org/results/5ae5ee948d99679cd50d1115a7d46f4368347b4f
> [2] https://patchwork.ozlabs.org/project/buildroot/patch/20240902210055.239859-1-dario.binacchi@amarulasolutions.com
> [3] https://patchwork.ozlabs.org/project/buildroot/patch/20240904174021.2670289-1-dario.binacchi@amarulasolutions.com/
> Co-Developed-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Co-Developed-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
[--SNIP--]
> diff --git a/package/iana-assignments/Config.in b/package/iana-assignments/Config.in
> new file mode 100644
> index 000000000000..b7bd52abd2d1
> --- /dev/null
> +++ b/package/iana-assignments/Config.in
> @@ -0,0 +1,14 @@
> +config BR2_PACKAGE_IANA_ASSIGNMENTS
> +	bool "IANA assignments"

As I suggested, we should 'select PEN' here, otherwise, when the user
enables the iana-assignements package alone, nothing will be done; it
does not make much sense.

Agreed, one may argue that having a single option that is always
selected does not make much sense either. However, in that case, a
dependent package (like ipmitool) can appropriately depend on the PEN
option, and be future-proof in case iana-assignments installs something
else in the future.

Regards,
Yann E. MORIN.

> +	help
> +	  Mirror of the IANA registries periodically updated
> +	  from https://www.iana.org/protocols.
> +
> +	  https://github.com/larseggert/iana-assignments
> +
> +if BR2_PACKAGE_IANA_ASSIGNMENTS
> +
> +config BR2_PACKAGE_IANA_ASSIGNMENTS_PEN_REG
> +	bool "PEN (Enterprise Numbers) registry"
> +
> +endif
> diff --git a/package/iana-assignments/iana-assignments.hash b/package/iana-assignments/iana-assignments.hash
> new file mode 100644
> index 000000000000..c58fb61df292
> --- /dev/null
> +++ b/package/iana-assignments/iana-assignments.hash
> @@ -0,0 +1,2 @@
> +# Locally computed
> +sha256  e7a1f8153715fa9e0f4c5d102f9271bce425a468f58a445e7c5ecdf7105fd460  iana-assignments-bf358dc8d89b7939557220b8055699b42a4133e9.tar.gz
> diff --git a/package/iana-assignments/iana-assignments.mk b/package/iana-assignments/iana-assignments.mk
> new file mode 100644
> index 000000000000..824b26d4ecf6
> --- /dev/null
> +++ b/package/iana-assignments/iana-assignments.mk
> @@ -0,0 +1,18 @@
> +################################################################################
> +#
> +# iana-assignments
> +#
> +################################################################################
> +
> +IANA_ASSIGNMENTS_VERSION = bf358dc8d89b7939557220b8055699b42a4133e9
> +IANA_ASSIGNMENTS_SITE = $(call github,larseggert,iana-assignments,$(IANA_ASSIGNMENTS_VERSION))
> +
> +ifeq ($(BR2_PACKAGE_IANA_ASSIGNMENTS_PEN_REG),y)
> +define IANA_ASSIGNMENTS_INSTALL_PEN_REG
> +	$(INSTALL) -D -m 0644 $(@D)/enterprise-numbers/enterprise-numbers \
> +		$(TARGET_DIR)/usr/share/misc/iana/enterprise-numbers
> +endef
> +IANA_ASSIGNMENTS_POST_INSTALL_TARGET_HOOKS += IANA_ASSIGNMENTS_INSTALL_PEN_REG
> +endif
> +
> +$(eval $(generic-package))
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot