Re: [Buildroot] [PATCH v3 1/4] package/andes-spi-burn: new package

[Yu-Chien Peter Lin via buildroot <buildroot@buildroot.org>]

Hi Thomas,

On Sat, Sep 14, 2024 at 09:00:30PM +0200, Thomas Petazzoni wrote:
> [EXTERNAL MAIL]
> 
> Hello,
> 
> On Tue, 10 Sep 2024 14:26:32 +0800
> Yu Chien Peter Lin via buildroot <buildroot@buildroot.org> wrote:
> 
> > Add a new package for Andes AE350 SPI_burn tool to program
> > flash memory.
> >
> > Signed-off-by: Yu Chien Peter Lin <peterlin@andestech.com>
> 
> Thanks for this new iteration. Unfortunately, there's still something
> that doesn't work. It fails to build for me with:
> 
> /usr/bin/ld: cannot find -lm: No such file or directory
> /usr/bin/ld: cannot find -lc: No such file or directory
> collect2: error: ld returned 1 exit status
> make[1]: *** [Makefile_SPIburn_linux:25: SPI_burn] Error 1
> 
> that's because you link with -static, and I don't have the static
> version of libc/libm installed on my machine.
> 
> So I wanted to patch that out, but the code is not even in the Github
> repo at https://github.com/andestech/meta-andes/, so I can't create
> a pull request. All you have published is a ZIP file with the source
> code, buried deep inside the meta-andes Yocto layer repository. This
> really isn't nice, and prevents people (like me) from actually
> contributing fixes (like removing this bogus -static flag).
> 
> Could you instead create a proper Github repository for this project,
> so that people can submit fixes, so that you can do tags, releases, etc.

Thank you for the review. I am in the process of creating a
dedicated GitHub repository for SPI_burn and will send PATCHv4
once the logistical issues are resolved.

> > diff --git a/DEVELOPERS b/DEVELOPERS
> > index 069965680b..aab5a6c05f 100644
> > --- a/DEVELOPERS
> > +++ b/DEVELOPERS
> > @@ -2487,6 +2487,7 @@ N:      Yu Chien Peter Lin <peterlin@andestech.com>
> >  F:   board/andes
> >  F:   configs/andes_ae350_45_defconfig
> >  F:   package/kmon/
> > +F:   package/andes-spi-burn/
> 
> Alphabetic ordering is not correct here.

Will fix, thanks.

Best regards,
Peter Lin

> Best regards,
> 
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot