From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4D08178396; Fri, 20 Sep 2024 14:33:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726842788; cv=none; b=KG56bX3ELGzoarX9CNDX2grbBXbTJX5hY+5VWgg3mK8pE2G9YAPJSsffvYnlJMpdtaVlH/cesA7Bh8x0UT/aRb+MEzUZzH/xTbPH+Uv2LYzUCRyIoBmwltVtd9qMPbNzqdZXfvoV0d+L+QqKfTwmOkL+tvlceUDWtGeQGZrSVgs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726842788; c=relaxed/simple; bh=FmZ1iPfYLpvXQ9iWVPvde2w99WvWCFNwTvXH1ZHG+/s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UzqEnCgBdEMcczaeWSkyE81jlUU/itrFR1XgDxgertZojPuZ/69cwW+YIoDaVo7tCbziKZ+KAXHeiquFZcZxFnFpy26NtHY3m4qb6p7XoFaeTIak5CJ5stVwi1qyKLc0hvMtJutRKSvKhfQdDpBRDIHpu7aTHx7i2juXIkUtiGM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=GmMCohQH; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="GmMCohQH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1726842787; x=1758378787; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=FmZ1iPfYLpvXQ9iWVPvde2w99WvWCFNwTvXH1ZHG+/s=; b=GmMCohQH8no8BCjmhg/odyRi82iH7gau16LIWcz6qnkvwFjpia/ovSAW MNQStV2KEUbIXm/fFCRbLXX0xYlFpu++zq7XfrAkQTMom2rtSpYJl6RNl AuM/bpfT7HAqDYZw5RSnINzyrH4InLElKqdtMZNoldkCcuMBa+45Qdbgv BYZa4ma/d06vLhMWfR29OgVYWfs5NP4MM5vytrSC5hsvlZT4wv0pCd3yS PzHTdsENT1NB0agcgXOkDA0z6PAwl2q0JKCmAsNAUM6mVIO+Vz+ZknKYu Fr0mfTZyC5xV6dnOnH0mp/HRFGRFxWQQ625XmYbWy51fiR3BDY5EBqTp/ Q==; X-CSE-ConnectionGUID: Mc18WBIiSWWDAbJWnO/Cgw== X-CSE-MsgGUID: hzfXoMrETRKwXEDEOsXPOA== X-IronPort-AV: E=McAfee;i="6700,10204,11200"; a="29638678" X-IronPort-AV: E=Sophos;i="6.10,244,1719903600"; d="scan'208";a="29638678" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2024 07:33:06 -0700 X-CSE-ConnectionGUID: VlqCpYX8QHyARjpiYlo3Pg== X-CSE-MsgGUID: eQh73CTxSP6P2ajTxgRzEg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,244,1719903600"; d="scan'208";a="70198558" Received: from smile.fi.intel.com ([10.237.72.54]) by orviesa010.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2024 07:33:01 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1sregs-0000000AwL1-2MqZ; Fri, 20 Sep 2024 17:32:58 +0300 Date: Fri, 20 Sep 2024 17:32:58 +0300 From: Andy Shevchenko To: warp5tw@gmail.com Cc: avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, andi.shyti@kernel.org, wsa@kernel.org, rand.sec96@gmail.com, wsa+renesas@sang-engineering.com, tali.perry@nuvoton.com, Avi.Fishman@nuvoton.com, tomer.maimon@nuvoton.com, KWLIU@nuvoton.com, JJLIU0@nuvoton.com, kfting@nuvoton.com, openbmc@lists.ozlabs.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 4/6] i2c: npcm: Modify the client address assignment Message-ID: References: <20240920101820.44850-1-kfting@nuvoton.com> <20240920101820.44850-5-kfting@nuvoton.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240920101820.44850-5-kfting@nuvoton.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Fri, Sep 20, 2024 at 06:18:18PM +0800, warp5tw@gmail.com wrote: > From: Tyrone Ting > > From: Tyrone Ting It seems all your mails have an issue. > Store the client address earlier since it might get called in > the i2c_recover_bus logic flow at the early stage of the func() > npcm_i2c_master_xfer. You got my comment really wrong. func() in my example was to refer to _a_ function mentioned in the text. And IIRC I even posted the example, like: i2c_recover_bus(). -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE993C78854 for ; Fri, 20 Sep 2024 14:33:26 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4X9FHG6hD1z3cQx for ; Sat, 21 Sep 2024 00:33:14 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=198.175.65.14 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1726842790; cv=none; b=mmkdb/HKQgRT9JjSkTTYL1OjwqQVPXXR0aYlzhsmm/w+3IymEDfcaO37E0jy4qtOC7L9M6e0SLSH/kqeyXAFlfG2L8zSoyYbrPbdZvfOa6YJnDnGcG0Jqm59dbsacJdgVtWbJiBZdDeAam8DWoELNbxOeHwwE+lB2j6MwJ3Gjz0cHpi4OAcuDxo3YRVPl6bTn04mTjjBYDi1Wy5enEAIjgoSZg+hA/LJkb53osVYwjcdjgSrt9iHw2NIyY84JBS4oSEDBT0ExFmRgpnXUUVQKbgYOsM561YGAN/tM7QWxMGtJhsHrN7nLcz+WtPCSmEYstDdEOEDA70AR88OautR2w== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1726842790; c=relaxed/relaxed; bh=9VK5+kcQg7hEc43tRiHJKpoIevPWo/Ko0TUcBiXgHBQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Qa1i4xL4mJn8mA6LTspSpgBu4UAExK69fYEtyKAbOsacfDtGBXAJM7M0MlApzUtVb8VMJQaHoePyzT/uH3oAtvW6P7DX5awPF042ttGVb3zAy530e1MbItv6/kojWGnbIIk6r0RbOMtyP0WD+Isr1GKzeIsDMfeIkLmwVI+rNtGlvsCzpVwU41QY4RWahQRYJrlUjM/SKQXn2wiR4MH0YQBt4ixtD9UkqrzqtzPJzBL2jZlwchiRrvw55+T7KRrQg9YBsqo3VpdlIdE+iHsgUPC5q8WF1hxMLRr6McsDzJZTE42fWPyKb5nXaZirMi28L6plaeJsPVmMLIjs14wrQQ== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=md+kZtQI; dkim-atps=neutral; spf=none (client-ip=198.175.65.14; helo=mgamail.intel.com; envelope-from=andriy.shevchenko@linux.intel.com; receiver=lists.ozlabs.org) smtp.mailfrom=linux.intel.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=md+kZtQI; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux.intel.com (client-ip=198.175.65.14; helo=mgamail.intel.com; envelope-from=andriy.shevchenko@linux.intel.com; receiver=lists.ozlabs.org) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4X9FHB016Lz2xnQ for ; Sat, 21 Sep 2024 00:33:09 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1726842790; x=1758378790; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=FmZ1iPfYLpvXQ9iWVPvde2w99WvWCFNwTvXH1ZHG+/s=; b=md+kZtQI3p6hjkmAjHpvafET9nj4Nv5Ra+xyhxZaSwOUDYwoPkeizv+v gzFkaszZYr5HZ7aaFPh0nzg1hs9rDYQEoTN/16ohfljwGFNiCpyyLJi7t Sw3WA8mb+qh+310WnJdCcZk30HAZCcpx7/Fwz8Vzss2tYkrwndLHUe+f/ l/zLwjxrNHPZ+3bQ0NPPsYN+xmALdecGGJNJcVLx5gENAMq7++EsjCCIk GEwyB9DK9SMFdAtvQ9ex5q95ml3Q2sFEs6JmPa+O0olQTKbHDsDfOoKX/ ru1TxhSeOO/6/F3wvOLbrbTDu+f1b9aZxThOszFd1OvcBKVDhKwtnhOEY w==; X-CSE-ConnectionGUID: bGxYnx9kTIWCIhPpCleC1A== X-CSE-MsgGUID: xemhsyVqQ1e2v6ZwXOHiqQ== X-IronPort-AV: E=McAfee;i="6700,10204,11200"; a="29638675" X-IronPort-AV: E=Sophos;i="6.10,244,1719903600"; d="scan'208";a="29638675" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2024 07:33:06 -0700 X-CSE-ConnectionGUID: VlqCpYX8QHyARjpiYlo3Pg== X-CSE-MsgGUID: eQh73CTxSP6P2ajTxgRzEg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,244,1719903600"; d="scan'208";a="70198558" Received: from smile.fi.intel.com ([10.237.72.54]) by orviesa010.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2024 07:33:01 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1sregs-0000000AwL1-2MqZ; Fri, 20 Sep 2024 17:32:58 +0300 Date: Fri, 20 Sep 2024 17:32:58 +0300 From: Andy Shevchenko To: warp5tw@gmail.com Subject: Re: [PATCH v4 4/6] i2c: npcm: Modify the client address assignment Message-ID: References: <20240920101820.44850-1-kfting@nuvoton.com> <20240920101820.44850-5-kfting@nuvoton.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240920101820.44850-5-kfting@nuvoton.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: KWLIU@nuvoton.com, tomer.maimon@nuvoton.com, linux-kernel@vger.kernel.org, benjaminfair@google.com, wsa+renesas@sang-engineering.com, avifishman70@gmail.com, venture@google.com, openbmc@lists.ozlabs.org, kfting@nuvoton.com, JJLIU0@nuvoton.com, tali.perry@nuvoton.com, tali.perry1@gmail.com, wsa@kernel.org, andi.shyti@kernel.org, linux-i2c@vger.kernel.org, Avi.Fishman@nuvoton.com, rand.sec96@gmail.com, tmaimon77@gmail.com Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Fri, Sep 20, 2024 at 06:18:18PM +0800, warp5tw@gmail.com wrote: > From: Tyrone Ting > > From: Tyrone Ting It seems all your mails have an issue. > Store the client address earlier since it might get called in > the i2c_recover_bus logic flow at the early stage of the func() > npcm_i2c_master_xfer. You got my comment really wrong. func() in my example was to refer to _a_ function mentioned in the text. And IIRC I even posted the example, like: i2c_recover_bus(). -- With Best Regards, Andy Shevchenko