From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Julian Sun <sunjunchao2870@gmail.com>,
linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz,
stable@vger.kernel.org
Subject: Re: [PATCH 3/3] vfs: return -EOVERFLOW in generic_remap_checks() when overflow check fails
Date: Fri, 20 Sep 2024 08:07:29 -0700 [thread overview]
Message-ID: <Zu2PsafDRpsu3Ryu@infradead.org> (raw)
In-Reply-To: <20240920150213.GD21853@frogsfrogsfrogs>
On Fri, Sep 20, 2024 at 08:02:13AM -0700, Darrick J. Wong wrote:
> > Which isn't exactly the integer overflow case described here :)
>
> Hm? This patch is touching the error code you get for failing alignment
> checks, not the one you get for failing check_add_overflow. EOVERFLOW
> seems like an odd return code for unaligned arguments. Though you're
> right that EINVAL is verrry vague.
I misread the patch (or rather mostly read the description). Yes,
-EOVERFLOW is rather odd here. And generic_copy_file_checks doesn't
even have alignment checks, so the message is wrong as well. I'll
wait for Jun what the intention was here - maybe the diff got
misapplied and this was supposed to be applied to an overflow
check that returns -EINVAL?
next prev parent reply other threads:[~2024-09-20 15:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 12:30 [PATCH 3/3] vfs: return -EOVERFLOW in generic_remap_checks() when overflow check fails Julian Sun
2024-09-20 12:31 ` kernel test robot
2024-09-20 14:19 ` Christoph Hellwig
2024-09-20 14:37 ` Darrick J. Wong
2024-09-20 14:58 ` Christoph Hellwig
2024-09-20 15:02 ` Darrick J. Wong
2024-09-20 15:07 ` Christoph Hellwig [this message]
2024-09-20 16:10 ` Julian Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zu2PsafDRpsu3Ryu@infradead.org \
--to=hch@infradead.org \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=sunjunchao2870@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.