From: Daniel Kiper via Grub-devel <grub-devel@gnu.org>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: Daniel Kiper <daniel.kiper@oracle.com>,
GRUB development <grub-devel@gnu.org>
Subject: Re: [PATCH 1/1] riscv: use time register in grub_efi_get_time_ms()
Date: Tue, 10 Sep 2024 14:59:10 +0200 [thread overview]
Message-ID: <ZuBCnhtWf++LZqrN@tomti.i.net-space.pl> (raw)
In-Reply-To: <aaf71bc1-5ede-43d8-bbbd-bf8b7806c13a@canonical.com>
On Tue, Sep 10, 2024 at 11:54:20AM +0200, Heinrich Schuchardt wrote:
> On 13.08.24 15:52, Daniel Kiper wrote:
> > On Mon, Aug 12, 2024 at 04:13:18PM +0200, Heinrich Schuchardt wrote:
> > > The cycle register is not guaranteed to count at constant frequency.
> > > If it is counting at all depends on the state the performance monitoring
> > > unit.
> > >
> > > Use the time register to measure time.
> > >
> > > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> >
> > Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
> >
> > Daniel
>
> Hello Daniel,
>
> Thanks for your review. Does anything prevent merging the patch?
Oh, I skipped it by mistake. Sorry about that. I have added it to the queue.
Daniel
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
prev parent reply other threads:[~2024-09-10 13:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 14:13 [PATCH 1/1] riscv: use time register in grub_efi_get_time_ms() Heinrich Schuchardt
2024-08-13 13:52 ` Daniel Kiper via Grub-devel
2024-09-10 9:54 ` Heinrich Schuchardt
2024-09-10 12:59 ` Daniel Kiper via Grub-devel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuBCnhtWf++LZqrN@tomti.i.net-space.pl \
--to=grub-devel@gnu.org \
--cc=daniel.kiper@oracle.com \
--cc=heinrich.schuchardt@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.